[Libvir] [Patch] Compilation cleanup
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Hi,
This patch fixes following message in compilation.
===============
xm_internal.h:64: warning: 'xenXMDomainAttachDevice' declared 'static' but
never defined
xm_internal.h:65: warning: 'xenXMDomainDetachDevice' declared 'static' but
never defined
===============
Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com>
Thanks
Atsushi SAKAI
Attachments:
- fix_libvirt_xm_compile.patch (application/octet-stream — 1.5 KB)
On Thu, 2008-02-07 at 16:40 +0900, Atsushi SAKAI wrote:
-static int xenXMDomainAttachDevice(virDomainPtr domain, const char
*xml);
-static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
+int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml);
+int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
These functions are only used in xm_internal.c, so it's best to keep
them static. See the patch I sent earlier.
Cheers,
Mark.
Hi, Mark
Thank you for your suggestion.
Would you give me a pointer about your patch?
Thanks
Atsushi SAKAI
Mark McLoughlin <markmc(a)redhat.com> wrote:
On Thu, 2008-02-07 at 16:40 +0900, Atsushi SAKAI wrote:
> -static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml);
> -static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
> +int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml);
> +int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
These functions are only used in xm_internal.c, so it's best to keep
them static. See the patch I sent earlier.
Cheers,
Mark.
On Thu, 2008-02-07 at 18:44 +0900, Atsushi SAKAI wrote:
Hi, Mark
Thank you for your suggestion.
Would you give me a pointer about your patch?
http://www.redhat.com/archives/libvir-list/2008-February/msg00062.html
Cheers,
Mark.
Hi, Mark
Thank you!
You patch is better than me.
c.f.
I am just looking for virt-tools on MinGW.
I miss it.
Thanks
Atsushi SAKAI
Mark McLoughlin <markmc(a)redhat.com> wrote:
On Thu, 2008-02-07 at 18:44 +0900, Atsushi SAKAI wrote:
> Hi, Mark
>
> Thank you for your suggestion.
> Would you give me a pointer about your patch?
http://www.redhat.com/archives/libvir-list/2008-February/msg00062.html
Cheers,
Mark.
6132
days inactive
6132
days old
4 comments
2 participants
tags (0)
participants (2)
-
Atsushi SAKAI -
Mark McLoughlin