[Libvir] [Patch] Compilation cleanup
Hi, This patch fixes following message in compilation. =============== xm_internal.h:64: warning: 'xenXMDomainAttachDevice' declared 'static' but never defined xm_internal.h:65: warning: 'xenXMDomainDetachDevice' declared 'static' but never defined =============== Signed-off-by: Atsushi SAKAI <sakaia@jp.fujitsu.com> Thanks Atsushi SAKAI
On Thu, 2008-02-07 at 16:40 +0900, Atsushi SAKAI wrote:
-static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml); -static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml); +int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml); +int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
These functions are only used in xm_internal.c, so it's best to keep them static. See the patch I sent earlier. Cheers, Mark.
Hi, Mark Thank you for your suggestion. Would you give me a pointer about your patch? Thanks Atsushi SAKAI Mark McLoughlin <markmc@redhat.com> wrote:
On Thu, 2008-02-07 at 16:40 +0900, Atsushi SAKAI wrote:
-static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml); -static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml); +int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml); +int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
These functions are only used in xm_internal.c, so it's best to keep them static. See the patch I sent earlier.
Cheers, Mark.
On Thu, 2008-02-07 at 18:44 +0900, Atsushi SAKAI wrote:
Hi, Mark
Thank you for your suggestion. Would you give me a pointer about your patch?
http://www.redhat.com/archives/libvir-list/2008-February/msg00062.html Cheers, Mark.
Hi, Mark Thank you! You patch is better than me. c.f. I am just looking for virt-tools on MinGW. I miss it. Thanks Atsushi SAKAI Mark McLoughlin <markmc@redhat.com> wrote:
On Thu, 2008-02-07 at 18:44 +0900, Atsushi SAKAI wrote:
Hi, Mark
Thank you for your suggestion. Would you give me a pointer about your patch?
http://www.redhat.com/archives/libvir-list/2008-February/msg00062.html
Cheers, Mark.
participants (2)
-
Atsushi SAKAI -
Mark McLoughlin