[libvirt] [PATCH] Fix virsh net-info output for consistency
From: Hao Liu <hliu@redhat.com> All *-info virsh commands output a list of comma seperated key-val pairs. But virsh net-info command misses this comma for key "Name" and "UUID". Signed-off-by: Hao Liu <hliu@redhat.com> --- tools/virsh-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 8ddd5ca..44a676b 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -367,10 +367,10 @@ cmdNetworkInfo(vshControl *ctl, const vshCmd *cmd) if (!(network = vshCommandOptNetwork(ctl, cmd, NULL))) return false; - vshPrint(ctl, "%-15s %s\n", _("Name"), virNetworkGetName(network)); + vshPrint(ctl, "%-15s %s\n", _("Name:"), virNetworkGetName(network)); if (virNetworkGetUUIDString(network, uuid) == 0) - vshPrint(ctl, "%-15s %s\n", _("UUID"), uuid); + vshPrint(ctl, "%-15s %s\n", _("UUID:"), uuid); active = virNetworkIsActive(network); if (active >= 0) -- 1.8.3.1
ACK. -- Regards, Alex ----- Original Message ----- From: hliu@redhat.com To: libvir-list@redhat.com Sent: Tuesday, November 19, 2013 2:20:57 PM Subject: [libvirt] [PATCH] Fix virsh net-info output for consistency From: Hao Liu <hliu@redhat.com> All *-info virsh commands output a list of comma seperated key-val pairs. But virsh net-info command misses this comma for key "Name" and "UUID". Signed-off-by: Hao Liu <hliu@redhat.com> --- tools/virsh-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 8ddd5ca..44a676b 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -367,10 +367,10 @@ cmdNetworkInfo(vshControl *ctl, const vshCmd *cmd) if (!(network = vshCommandOptNetwork(ctl, cmd, NULL))) return false; - vshPrint(ctl, "%-15s %s\n", _("Name"), virNetworkGetName(network)); + vshPrint(ctl, "%-15s %s\n", _("Name:"), virNetworkGetName(network)); if (virNetworkGetUUIDString(network, uuid) == 0) - vshPrint(ctl, "%-15s %s\n", _("UUID"), uuid); + vshPrint(ctl, "%-15s %s\n", _("UUID:"), uuid); active = virNetworkIsActive(network); if (active >= 0) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
At Tue, 19 Nov 2013 04:30:45 -0500 (EST), Alex Jia wrote:
ACK.
-- Regards, Alex
----- Original Message ----- From: hliu@redhat.com To: libvir-list@redhat.com Sent: Tuesday, November 19, 2013 2:20:57 PM Subject: [libvirt] [PATCH] Fix virsh net-info output for consistency
From: Hao Liu <hliu@redhat.com>
All *-info virsh commands output a list of comma seperated key-val pairs. But virsh net-info command misses this comma for key "Name" and "UUID".
s/comma/colon/ ? What about the translations, do they need updating too? Claudio -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:<http://www.av-test.org> Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern
On 11/19/2013 02:46 AM, Claudio Bley wrote:
All *-info virsh commands output a list of comma seperated key-val pairs. But virsh net-info command misses this comma for key "Name" and "UUID".
s/comma/colon/ ?
Yes.
What about the translations, do they need updating too?
The new strings are marked for translation, so the translation update will automatically happen on the next release. I'll go ahead and pushed the touched up commit. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (4)
-
Alex Jia -
Claudio Bley -
Eric Blake -
hliu＠redhat.com