On 10/22/2013 06:29 AM, Jim Fehlig wrote: > On systems where gnutls uses libgcrypt, I'm seeing the following > build failure > > libvirt.c:314: error: variable 'virTLSThreadImpl' has initializer but incomplete type > libvirt.c:319: error: 'GCRY_THREAD_OPTION_PTHREAD' undeclared here (not in a function) > ... > > Fix by undefining WITH_GNUTLS_GCRYPT in config-post.h > > Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; > --- > > Although I'm more confident in this fix vs the previously reported > virt-login-shell build failure, I'd still prefer an ACK before pushing. > I'm not sure on the other one yet, but can definitely ACK this one.

On 10/22/2013 04:59 PM, Jim Fehlig wrote: > Michal pushed the other one that Daniel ACKed. One thing that concerned > me, which I forgot to mention in the mail or commit message, was this > comment above libvirt_setuid_rpc_client in src/Makefile.am > > # Since virt-login-shell will be setuid, we must do everything > # we can to avoid linking to other libraries. We can't eliminate every library, but we can assume that some very basic libraries are capable of being safely used in setuid apps (selinux, apparmor, and libc among that list). Meanwhile, we do have proof that other libraries are not so friendly; among them, Daniel analyzed using LD_PRELOAD that at least libnspr.so (used by libcurl.so) has at least one unprotected getenv() within a constructor that could be used merely by loading the shared library into memory as a way to cause an overwrite of an unintended file in a setuid app. So maybe the comment could be tweaked to say "we avoid linking to all but very basic and well-audited libraries".