[libvirt] [PATCH] Fix locking issue in testVolumeLookupByPath
The attached patch fixes a locking issue in the test driver, specifically testStorageVolumeLookupByPath. We were only unlocking the pool object if it was running. This fixed a deadlock I was seeing while adding some new tests to virtinst's test framework. Thanks, Cole
On Wed, Dec 10, 2008 at 03:27:37PM -0500, Cole Robinson wrote:
The attached patch fixes a locking issue in the test driver, specifically testStorageVolumeLookupByPath. We were only unlocking the pool object if it was running. This fixed a deadlock I was seeing while adding some new tests to virtinst's test framework.
Ouch, I hope there isn't too many of those, ACK ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Daniel Veillard wrote:
On Wed, Dec 10, 2008 at 03:27:37PM -0500, Cole Robinson wrote:
The attached patch fixes a locking issue in the test driver, specifically testStorageVolumeLookupByPath. We were only unlocking the pool object if it was running. This fixed a deadlock I was seeing while adding some new tests to virtinst's test framework.
Ouch, I hope there isn't too many of those, ACK !
Daniel
Thanks, applied now. - Cole
participants (2)
-
Cole Robinson -
Daniel Veillard