The C library will now ignore an attempt to register an event loop twice. It is unable to report an error in this case though due to the C API returning 'void'. To improve this we must manually report an error at the python level. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- libvirt-override.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index a3a0508..9eba4ed 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -5427,13 +5427,12 @@ static PyObject * libvirt_virEventRegisterImpl(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) { - /* Unref the previously-registered impl (if any) */ - Py_XDECREF(addHandleObj); - Py_XDECREF(updateHandleObj); - Py_XDECREF(removeHandleObj); - Py_XDECREF(addTimeoutObj); - Py_XDECREF(updateTimeoutObj); - Py_XDECREF(removeTimeoutObj); + if (addHandleObj || updateHandleObj || removeHandleObj || + addTimeoutObj || updateTimeoutObj || removeTimeoutObj) { + PyErr_SetString(PyExc_RuntimeError, + "Event loop is already registered"); + return NULL; + } /* Parse and check arguments */ if (!PyArg_ParseTuple(args, (char *) "OOOOOO:virEventRegisterImpl", -- 2.13.5