[libvirt] [PATCH] fix missing VLAN id for Qbg example
For IEEE 802.1Qbg, it is necessary to use a VLAN interface. vepa itself does not require a VLAN interface. Signed-off-by: Gerhard Stenzel <stenzel at de.ibm.com> =================================================================== --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1440,6 +1440,10 @@ the Virtual Station Interface (VSI) represents the virtual interface of a virtual machine. </p> + <p> + Please note, that IEEE 802.1Qbg requires a non-zero value for the + VLAN ID. + </p> <dl> <dt><code>managerid</code></dt> <dd>The VSI Manager ID identifies the database containing the VSI type @@ -1466,7 +1470,7 @@ <interface type='direct'/> ... <interface type='direct'> - <source dev='eth0' mode='vepa'/> + <source dev='eth0.2' mode='vepa'/> <virtualport type="802.1Qbg"> <parameters managerid="11" typeid="1193047" typeidversion="2" instanceid="09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f"/> </virtualport> =================================================================== Best regards, Gerhard Stenzel ------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
On 05/02/2011 08:49 AM, Gerhard Stenzel wrote:
For IEEE 802.1Qbg, it is necessary to use a VLAN interface. vepa itself does not require a VLAN interface.
Signed-off-by: Gerhard Stenzel <stenzel at de.ibm.com>
=================================================================== --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1440,6 +1440,10 @@ the Virtual Station Interface (VSI) represents the virtual interface of a virtual machine. </p> + <p> + Please note, that IEEE 802.1Qbg requires a non-zero value for the
The comma is not necessary grammatically.
+ VLAN ID. + </p>
ACK and pushed with that nit fixed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 05/02/2011 11:14 AM, Eric Blake wrote:
On 05/02/2011 08:49 AM, Gerhard Stenzel wrote:
For IEEE 802.1Qbg, it is necessary to use a VLAN interface. vepa itself does not require a VLAN interface.
Just so I understand correctly - the 802.1Qbg standard requires using a VLAN, but the vepa implementation doesn't have that restriction, so it is still okay for someone using a vepa switch to not use a VLAN. Correct?
Signed-off-by: Gerhard Stenzel<stenzel at de.ibm.com>
=================================================================== --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1440,6 +1440,10 @@ the Virtual Station Interface (VSI) represents the virtual interface of a virtual machine. </p> +<p> + Please note, that IEEE 802.1Qbg requires a non-zero value for the The comma is not necessary grammatically.
+ VLAN ID. +</p> ACK and pushed with that nit fixed.
And it's already up on the website! Is the website content constantly refreshed directly from git? (I had assumed it was being updated at each release...)
On 05/02/2011 10:07 AM, Laine Stump wrote:
ACK and pushed with that nit fixed.
And it's already up on the website! Is the website content constantly refreshed directly from git? (I had assumed it was being updated at each release...)
I don't know if it's a commit trigger (instant) or just an hourly cron job, but in my experience, all doc edits do show up online within an hour of the git push. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Mon, May 02, 2011 at 10:15:11AM -0600, Eric Blake wrote:
On 05/02/2011 10:07 AM, Laine Stump wrote:
ACK and pushed with that nit fixed.
And it's already up on the website! Is the website content constantly refreshed directly from git? (I had assumed it was being updated at each release...)
I don't know if it's a commit trigger (instant) or just an hourly cron job, but in my experience, all doc edits do show up online within an hour of the git push.
Yes it's updated directly from git + buid on an hourly cron job :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Mon, 2011-05-02 at 12:07 -0400, Laine Stump wrote:
Just so I understand correctly - the 802.1Qbg standard requires using a VLAN, but the vepa implementation doesn't have that restriction, so it is still okay for someone using a vepa switch to not use a VLAN. Correct? yes
-- Best regards, Gerhard Stenzel, ----------------------------------------------------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
participants (4)
-
Daniel Veillard -
Eric Blake -
Gerhard Stenzel -
Laine Stump