[libvirt] [PATCH] Fix typo in error message
by rewriting it completely from: error: unsupported configuration: virtio only support device address type 'PCI' to: error: unsupported configuration: virtio disk cannot have an address of type drive Since we now support CCW addresses as well. --- src/qemu/qemu_command.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 63d43d4..a747eb4 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2423,8 +2423,9 @@ qemuAssignDevicePCISlots(virDomainDefPtr def, continue; if (def->disks[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtio only support device address type 'PCI'")); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("virtio disk cannot have an address of type %s"), + virDomainDeviceAddressTypeToString(def->disks[i]->info.type)); goto error; } -- 2.0.5
On Mon, Mar 23, 2015 at 12:29:42PM +0100, Ján Tomko wrote: Just a question: where is the typo mentioned in $subject?
by rewriting it completely from: error: unsupported configuration: virtio only support device address type 'PCI'
to:
error: unsupported configuration: virtio disk cannot have an address of type drive
Since we now support CCW addresses as well. --- src/qemu/qemu_command.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 63d43d4..a747eb4 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2423,8 +2423,9 @@ qemuAssignDevicePCISlots(virDomainDefPtr def, continue;
if (def->disks[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtio only support device address type 'PCI'")); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("virtio disk cannot have an address of type %s"),
I would wrap the %s with single quote '.
+ virDomainDeviceAddressTypeToString(def->disks[i]->info.type)); goto error; }
-- 2.0.5
ACK
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 03/23/2015 06:12 AM, Pavel Hrdina wrote:
On Mon, Mar 23, 2015 at 12:29:42PM +0100, Ján Tomko wrote:
Just a question: where is the typo mentioned in $subject?
by rewriting it completely from: error: unsupported configuration: virtio only support device address type 'PCI'
'support' should have been 'supports' -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (3)
-
Eric Blake -
Ján Tomko -
Pavel Hrdina