[libvirt] [PATCH] libvirt: Document UNDEFINE_NVRAM in UndefineFlags doc
--- src/libvirt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index caacc2e..dfca4f6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -8760,6 +8760,10 @@ virDomainUndefine(virDomainPtr domain) * whether this flag is present. On hypervisors where snapshots do * not use libvirt metadata, this flag has no effect. * + * If the domain has any nvram specified, then including + * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag + * will cause the undefine process to fail. + * * Returns 0 in case of success, -1 in case of error */ int -- 2.1.0
On Tue, Oct 14, 2014 at 12:03:59PM +0200, Cole Robinson wrote:
--- src/libvirt.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/src/libvirt.c b/src/libvirt.c index caacc2e..dfca4f6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -8760,6 +8760,10 @@ virDomainUndefine(virDomainPtr domain) * whether this flag is present. On hypervisors where snapshots do * not use libvirt metadata, this flag has no effect. * + * If the domain has any nvram specified, then including + * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag + * will cause the undefine process to fail. + * * Returns 0 in case of success, -1 in case of error */ int
ACK, Martin
On 10/14/2014 12:46 PM, Martin Kletzander wrote:
On Tue, Oct 14, 2014 at 12:03:59PM +0200, Cole Robinson wrote:
--- src/libvirt.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/src/libvirt.c b/src/libvirt.c index caacc2e..dfca4f6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -8760,6 +8760,10 @@ virDomainUndefine(virDomainPtr domain) * whether this flag is present. On hypervisors where snapshots do * not use libvirt metadata, this flag has no effect. * + * If the domain has any nvram specified, then including + * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag + * will cause the undefine process to fail. + * * Returns 0 in case of success, -1 in case of error */ int
ACK,
Martin
Thanks, pushed now - Cole
participants (2)
-
Cole Robinson -
Martin Kletzander