[libvirt] [PATCH] Make sure AC_ARG_WITH is always executed
--- I'm not sure whether it's good autoconf style to have AC_ARG_WITH in a conditional so this patch moves it out. Cheers, -- Guido configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 97752f4..d02b9d2 100644 --- a/configure.ac +++ b/configure.ac @@ -1418,13 +1418,12 @@ elif test "with_secdriver_apparmor" != "no" ; then fi AM_CONDITIONAL([WITH_SECDRIVER_APPARMOR], [test "$with_secdriver_apparmor" != "no"]) -if test "$with_apparmor" != "no"; then AC_ARG_WITH([apparmor-profiles], [AS_HELP_STRING([--with-apparmor-profiles], [install apparmor profiles @<:@default=no@:>@])], [with_apparmor_profiles=yes], [with_apparmor_profiles=no]) -else +if test "$with_apparmor" = "no"; then with_apparmor_profiles="no" fi AM_CONDITIONAL([WITH_APPARMOR_PROFILES], [test "$with_apparmor_profiles" != "no"]) -- 1.8.5.2
On 01/07/2014 04:10 PM, Guido Günther wrote:
--- I'm not sure whether it's good autoconf style to have AC_ARG_WITH in a conditional so this patch moves it out.
Much of the code within AC_ARG_WITH gets executed unconditionally (because it gets hoisted to earlier parts of the configure than where you actually invoked it in configure.ac), so you are correct that using it unconditionally is better style. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Tue, Jan 07, 2014 at 04:19:14PM -0700, Eric Blake wrote:
On 01/07/2014 04:10 PM, Guido Günther wrote:
--- I'm not sure whether it's good autoconf style to have AC_ARG_WITH in a conditional so this patch moves it out.
Much of the code within AC_ARG_WITH gets executed unconditionally (because it gets hoisted to earlier parts of the configure than where you actually invoked it in configure.ac), so you are correct that using it unconditionally is better style. ACK. Pushed now. Thanks. -- Guido
participants (2)
-
Eric Blake -
Guido Günther