[libvirt] [PATCH] daemon: Remove deprecated HAL from init script dependencies
The init script for the daemon requests to start HAL although it has been deprecated long time ago. This patch removes the dependency. --- daemon/libvirtd.init.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.init.in b/daemon/libvirtd.init.in index 3c49b1f..f66ddad 100644 --- a/daemon/libvirtd.init.in +++ b/daemon/libvirtd.init.in @@ -8,7 +8,6 @@ # Required-Start: $network messagebus # Should-Start: $named # Should-Start: xend -# Should-Start: hal # Should-Start: avahi-daemon # Required-Stop: $network messagebus # Should-Stop: $named -- 1.7.3.4
On 03/02/2012 08:33 AM, Peter Krempa wrote:
The init script for the daemon requests to start HAL although it has been deprecated long time ago. This patch removes the dependency. --- daemon/libvirtd.init.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.init.in b/daemon/libvirtd.init.in index 3c49b1f..f66ddad 100644 --- a/daemon/libvirtd.init.in +++ b/daemon/libvirtd.init.in @@ -8,7 +8,6 @@ # Required-Start: $network messagebus # Should-Start: $named # Should-Start: xend -# Should-Start: hal
Should we make this a configure decision, as in: configure.ac: if test $with_hal = yes; then AC_SUBST([INIT_HAL], [Should-Start: hal]) else AC_SUBST([INIT_HAL], []) fi libvirtd.init.in: # @INIT_HAL@ Then again, in typing it out, I think that's overkill. So ACK to your patch, as-is. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 03/02/2012 04:38 PM, Eric Blake wrote:
On 03/02/2012 08:33 AM, Peter Krempa wrote:
The init script for the daemon requests to start HAL although it has been deprecated long time ago. This patch removes the dependency. --- daemon/libvirtd.init.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.init.in b/daemon/libvirtd.init.in index 3c49b1f..f66ddad 100644 --- a/daemon/libvirtd.init.in +++ b/daemon/libvirtd.init.in @@ -8,7 +8,6 @@ # Required-Start: $network messagebus # Should-Start: $named # Should-Start: xend -# Should-Start: hal
Should we make this a configure decision, as in:
I was considering this option, but I don't think that anybody will ever try to use HAL with recent libvirt again.
configure.ac: if test $with_hal = yes; then AC_SUBST([INIT_HAL], [Should-Start: hal]) else AC_SUBST([INIT_HAL], []) fi
libvirtd.init.in: # @INIT_HAL@
Then again, in typing it out, I think that's overkill. So ACK to your patch, as-is.
Thanks; pushed. Peter
participants (2)
-
Eric Blake -
Peter Krempa