[libvirt] [PATCH] fix build by correcting functions order and src/Makefile.am
commit 30c61901 added new functions to libvirt_private.syms not alpabetically sorted and erroneously added vz sources to STATEFUL_DRIVER_SOURCE_FILES, which triggered check-aclrules running while vz driver isn't ready for it yet. Pushing under build-breaker rule. --- src/Makefile.am | 1 - src/libvirt_private.syms | 12 ++++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 08ff301..f5e57c0 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -630,7 +630,6 @@ DRIVER_SOURCE_FILES = \ $(NULL) STATEFUL_DRIVER_SOURCE_FILES = \ - $(VZ_DRIVER_SOURCES) \ $(BHYVE_DRIVER_SOURCES) \ $(INTERFACE_DRIVER_SOURCES) \ $(LIBXL_DRIVER_SOURCES) \ diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1bcb3af..a9025f5 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -916,6 +916,11 @@ virCPUx86MakeData; # datatypes.h virConnectClass; +virConnectCloseCallbackDataCall; +virConnectCloseCallbackDataClass; +virConnectCloseCallbackDataGetCallback; +virConnectCloseCallbackDataRegister; +virConnectCloseCallbackDataUnregister; virDomainClass; virDomainSnapshotClass; virGetConnect; @@ -929,20 +934,15 @@ virGetSecret; virGetStoragePool; virGetStorageVol; virGetStream; -virConnectCloseCallbackDataGetCallback; -virNewConnectCloseCallbackData; -virConnectCloseCallbackDataUnregister; -virConnectCloseCallbackDataRegister; -virConnectCloseCallbackDataCall; virInterfaceClass; virNetworkClass; +virNewConnectCloseCallbackData; virNodeDeviceClass; virNWFilterClass; virSecretClass; virStoragePoolClass; virStorageVolClass; virStreamClass; -virConnectCloseCallbackDataClass; # fdstream.h -- 2.4.3
On 04/13/2016 08:23 PM, Maxim Nestratov wrote:
commit 30c61901 added new functions to libvirt_private.syms not alpabetically sorted and erroneously added vz sources to STATEFUL_DRIVER_SOURCE_FILES, which triggered check-aclrules running while vz driver isn't ready for it yet.
Pushing under build-breaker rule.
---
This fixes the build for me. ACK. Thanks for taking time out of your evening (and late night too, I think?) to fix this :-)
14.04.2016 3:57, Laine Stump пишет:
On 04/13/2016 08:23 PM, Maxim Nestratov wrote:
commit 30c61901 added new functions to libvirt_private.syms not alpabetically sorted and erroneously added vz sources to STATEFUL_DRIVER_SOURCE_FILES, which triggered check-aclrules running while vz driver isn't ready for it yet.
Pushing under build-breaker rule.
---
This fixes the build for me. ACK.
Thanks for taking time out of your evening (and late night too, I think?) to fix this :-)
Yeah, it was pretty late :), but I stick to the rule that I have to clean up after myself thus, my fault - my trouble. Sorry for involving you and anyone else in sorting out mess I created. Anyway I can state that a habit to run 'make check' before every push is ingrained in me now. Best, Maxim
participants (2)
-
Laine Stump -
Maxim Nestratov