[libvirt] nwfilter: Don't compile nwfilter driver on other systems than Linux
Don't compile the nwfilter driver (instantiating the rules) on other systems than Linux. Signed-off-by: Stefan Berger <stefanb@us.ibm.com> diff --git a/configure.ac b/configure.ac index 23181dd..4cb0f50 100644 --- a/configure.ac +++ b/configure.ac @@ -1361,7 +1361,7 @@ fi AM_CONDITIONAL([WITH_SECRETS], [test "$with_secrets" = "yes"]) with_nwfilter=yes -if test "$with_libvirtd" = "no"; then +if test "$with_libvirtd" = "no" || test `uname -s` != "Linux"; then with_nwfilter=no fi if test "$with_nwfilter" = "yes" ; then
On 09/27/2010 12:02 PM, Stefan Berger wrote:
Don't compile the nwfilter driver (instantiating the rules) on other systems than Linux.
Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
diff --git a/configure.ac b/configure.ac index 23181dd..4cb0f50 100644 --- a/configure.ac +++ b/configure.ac @@ -1361,7 +1361,7 @@ fi AM_CONDITIONAL([WITH_SECRETS], [test "$with_secrets" = "yes"])
with_nwfilter=yes -if test "$with_libvirtd" = "no"; then +if test "$with_libvirtd" = "no" || test `uname -s` != "Linux"; then
NACK as written. This would fail when cross-compiling. Instead, you should check $host or $host_os. Hmm, configure.ac already has an AM_CONDITIONAL for WITH_LINUX; which means $with_linux is also a reasonable thing to check. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 09/28/2010 04:17 AM, Eric Blake wrote:
On 09/27/2010 12:02 PM, Stefan Berger wrote:
Don't compile the nwfilter driver (instantiating the rules) on other systems than Linux. <snip> NACK as written. This would fail when cross-compiling.
Instead, you should check $host or $host_os.
Hmm, configure.ac already has an AM_CONDITIONAL for WITH_LINUX; which means $with_linux is also a reasonable thing to check.
Sounds like this could be beneficial for the OSX platform, where it's presently getting compiled for libvirtd. :)
participants (3)
-
Eric Blake -
Justin Clift -
Stefan Berger