[libvirt] [PATCH] libvirt-guests: newline between output sentences

Right now, libvirt-guests gives awkward output. It's possible to force faster failure by setting /etc/sysconfig/libvirt-guests to use: ON_SHUTDOWN=shutdown PARALLEL_SHUTDOWN=0 SHUTDOWN_TIMEOUT=1 ON_BOOT=ignore at which point, we see: $ service libvirt-guests restart Running guests on default URI: a, b, d, c Shutting down guests on default URI... Starting shutdown on guest: a Shutdown of guest a failed to complete in time.Starting shutdown on guest: b Shutdown of guest b failed to complete in time.Starting shutdown on guest: d Shutdown of guest d failed to complete in time.Starting shutdown on guest: c Shutdown of guest c failed to complete in time.libvirt-guests is configured not to start any guests on boot * tools/libvirt-guests.sh.in (shutdown_guest): Add missing newline. Reported off-list by Xuesong Zhang. --- tools/libvirt-guests.sh.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 1c9c46b..4f2e203 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -269,6 +269,7 @@ shutdown_guest() else eval_gettext "Shutdown of guest \$name complete." fi + echo fi } -- 1.8.1.4

On 2013年03月20日 22:56, Eric Blake wrote:
Right now, libvirt-guests gives awkward output. It's possible to force faster failure by setting /etc/sysconfig/libvirt-guests to use:
ON_SHUTDOWN=shutdown PARALLEL_SHUTDOWN=0 SHUTDOWN_TIMEOUT=1 ON_BOOT=ignore
at which point, we see:
$ service libvirt-guests restart Running guests on default URI: a, b, d, c Shutting down guests on default URI... Starting shutdown on guest: a Shutdown of guest a failed to complete in time.Starting shutdown on guest: b Shutdown of guest b failed to complete in time.Starting shutdown on guest: d Shutdown of guest d failed to complete in time.Starting shutdown on guest: c Shutdown of guest c failed to complete in time.libvirt-guests is configured not to start any guests on boot
* tools/libvirt-guests.sh.in (shutdown_guest): Add missing newline. Reported off-list by Xuesong Zhang. --- tools/libvirt-guests.sh.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 1c9c46b..4f2e203 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -269,6 +269,7 @@ shutdown_guest() else eval_gettext "Shutdown of guest \$name complete." fi + echo fi }
ACK

On 03/20/2013 10:08 PM, Osier Yang wrote:
On 2013年03月20日 22:56, Eric Blake wrote:
Right now, libvirt-guests gives awkward output. It's possible to force faster failure by setting /etc/sysconfig/libvirt-guests to use:
* tools/libvirt-guests.sh.in (shutdown_guest): Add missing newline. Reported off-list by Xuesong Zhang. ---
ACK
Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake
-
Osier Yang