[libvirt] [PATCH] virsh: fix a typo in the memtune help description

--- tools/virsh.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 6c48a62..4e37f2d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2894,8 +2894,9 @@ cmdSetmaxmem(vshControl *ctl, const vshCmd *cmd) * "memtune" command */ static const vshCmdInfo info_memtune[] = { - {"help", N_("Get/Set memory paramters")}, - {"desc", N_("Get/Set the current memory paramters for the guest domain.\n" \ + {"help", N_("Get or set memory parameters")}, + {"desc", N_("Get or set the current memory parameters for a guest" \ + " domain.\n" \ " To get the memory parameters use following command: \n\n" \ " virsh # memtune <domain>")}, {NULL, NULL} -- 1.7.3.2

于 2010年12月08日 12:20, Justin Clift 写道:
--- tools/virsh.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c index 6c48a62..4e37f2d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2894,8 +2894,9 @@ cmdSetmaxmem(vshControl *ctl, const vshCmd *cmd) * "memtune" command */ static const vshCmdInfo info_memtune[] = { - {"help", N_("Get/Set memory paramters")}, - {"desc", N_("Get/Set the current memory paramters for the guest domain.\n" \ + {"help", N_("Get or set memory parameters")}, + {"desc", N_("Get or set the current memory parameters for a guest" \ + " domain.\n" \ " To get the memory parameters use following command: \n\n" \ " virsh # memtune<domain>")}, {NULL, NULL} should we describe what's the diffrence with bunch of "dommemstat", "setmem", and "setmaxmem"?
- Osier

On 08/12/2010, at 4:40 PM, Osier Yang wrote:
于 2010年12月08日 12:20, Justin Clift 写道:
--- tools/virsh.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c index 6c48a62..4e37f2d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2894,8 +2894,9 @@ cmdSetmaxmem(vshControl *ctl, const vshCmd *cmd) * "memtune" command */ static const vshCmdInfo info_memtune[] = { - {"help", N_("Get/Set memory paramters")}, - {"desc", N_("Get/Set the current memory paramters for the guest domain.\n" \ + {"help", N_("Get or set memory parameters")}, + {"desc", N_("Get or set the current memory parameters for a guest" \ + " domain.\n" \ " To get the memory parameters use following command: \n\n" \ " virsh # memtune<domain>")}, {NULL, NULL} should we describe what's the diffrence with bunch of "dommemstat", "setmem", and "setmaxmem"?
Thats not a bad idea at all. What's the best way to describe the difference between them? :)

On 12/07/2010 09:20 PM, Justin Clift wrote:
--- tools/virsh.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c index 6c48a62..4e37f2d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2894,8 +2894,9 @@ cmdSetmaxmem(vshControl *ctl, const vshCmd *cmd) * "memtune" command */ static const vshCmdInfo info_memtune[] = { - {"help", N_("Get/Set memory paramters")}, - {"desc", N_("Get/Set the current memory paramters for the guest domain.\n" \ + {"help", N_("Get or set memory parameters")}, + {"desc", N_("Get or set the current memory parameters for a guest" \ + " domain.\n" \
ACK (added the missing 'e' in parameters). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On 09/12/2010, at 1:51 AM, Eric Blake wrote:
On 12/07/2010 09:20 PM, Justin Clift wrote:
--- tools/virsh.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c index 6c48a62..4e37f2d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c <snip>
ACK (added the missing 'e' in parameters).
Thanks, pushed.
participants (3)
-
Eric Blake
-
Justin Clift
-
Osier Yang