[libvirt] make syntax-check error due to bad email addr
Hi all, make syntax-check is reporting an error with the AUTHORS file, which seems to be coming from an incorrect address for Jim Fehlig. $ make syntax-check GFDL_version 2.60 GFDL_version TAB_in_indentation 0.03 TAB_in_indentation Wundef_boolean 0.25 Wundef_boolean avoid_ctype_macros 0.14 avoid_ctype_macros avoid_if_before_free 7.60 avoid_if_before_free avoid_write 0.03 avoid_write cast_of_argument_to_free 0.12 cast_of_argument_to_free cast_of_x_alloc_return_value 0.11 cast_of_x_alloc_return_value changelog 0.02 changelog check_author_list jfehlig@linux-ypgk.site maint.mk: committer(s) not listed in AUTHORS make: *** [sc_check_author_list] Error 1 $ This is the git log entry it may be from: commit b1eb7f2e987d21b1711e86e5cb63a69abfce82f1 Author: Jim Fehlig <jfehlig@linux-ypgk.site> Date: Fri Jun 4 10:04:03 2010 -0600 Fixes for commit 211dd1e9 Fixes for issues in commit 211dd1e9 noted by by Jim Meyering. 1. Allocate content buffer of size content_length + 1 to ensure NUL-termination. 2. Limit content buffer size to 64k 3. Fix whitespace issue V2: - Add comment to clarify allocation of content buffer - Add ATTRIBUTE_NONNULL where appropriate - User NULLSTR macro Adding the incorrect email to the AUTHORS file is a workaround, but is someone ok to fix the cause? Regards and best wishes, Justin Clift -- Salasaga - Open Source eLearning IDE http://www.salasaga.org
Justin Clift wrote:
make syntax-check is reporting an error with the AUTHORS file, which seems to be coming from an incorrect address for Jim Fehlig. ... check_author_list jfehlig@linux-ypgk.site maint.mk: committer(s) not listed in AUTHORS make: *** [sc_check_author_list] Error 1 $
This is the git log entry it may be from:
commit b1eb7f2e987d21b1711e86e5cb63a69abfce82f1 Author: Jim Fehlig <jfehlig@linux-ypgk.site> ...
Adding the incorrect email to the AUTHORS file is a workaround, but is someone ok to fix the cause?
Thanks for reporting that. I've fixed it by pushing this change:
From ef77388ba4ba0bf37d426a7c2f7a983571acc3ea Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Sun, 6 Jun 2010 10:27:28 +0200 Subject: [PATCH] avoid syntax-check failure
* .mailmap: Map a stray commit-author email address to the canonical one. Reported by Justin Clift. --- .mailmap | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.mailmap b/.mailmap index dff04b9..8c1eed3 100644 --- a/.mailmap +++ b/.mailmap @@ -10,3 +10,4 @@ <meyering@redhat.com> <jim@meyering.net> <socketpair@gmail.com> <socketpair gmail com> <soren@canonical.com> <soren@ubuntu.com> +<jfehlig@novell.com> <jfehlig@linux-ypgk.site> -- 1.7.1.445.gc54f1
Jim Meyering wrote:
Justin Clift wrote:
make syntax-check is reporting an error with the AUTHORS file, which seems to be coming from an incorrect address for Jim Fehlig.
...
check_author_list jfehlig@linux-ypgk.site maint.mk: committer(s) not listed in AUTHORS make: *** [sc_check_author_list] Error 1 $
This is the git log entry it may be from:
commit b1eb7f2e987d21b1711e86e5cb63a69abfce82f1 Author: Jim Fehlig <jfehlig@linux-ypgk.site>
...
Adding the incorrect email to the AUTHORS file is a workaround, but is someone ok to fix the cause?
Thanks for reporting that. I've fixed it by pushing this change:
From ef77388ba4ba0bf37d426a7c2f7a983571acc3ea Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Sun, 6 Jun 2010 10:27:28 +0200 Subject: [PATCH] avoid syntax-check failure
* .mailmap: Map a stray commit-author email address to the canonical one. Reported by Justin Clift. --- .mailmap | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.mailmap b/.mailmap index dff04b9..8c1eed3 100644 --- a/.mailmap +++ b/.mailmap @@ -10,3 +10,4 @@ <meyering@redhat.com> <jim@meyering.net> <socketpair@gmail.com> <socketpair gmail com> <soren@canonical.com> <soren@ubuntu.com> +<jfehlig@novell.com> <jfehlig@linux-ypgk.site>
Damn, I was working remote last week and committed that from a rarely used laptop with a lame .gitconfig. Apologies for the oversight :-(. Regards, Jim
participants (3)
-
Jim Fehlig -
Jim Meyering -
Justin Clift