On Mon, Oct 27, 2008 at 02:46:47PM -0400, David Lively wrote: > Since the version of this I posted last week still had some outstaning > TODO items that I have since finished, I'm re-submitting the whole > thing. I consider this a "complete submission" since I don't think it's > necessary to implement any additional functionality to make this > acceptable. (The two remaining unimplemented items are > virNodeDeviceCreate / Destroy and a real Devkit impl, neither of which > needs to be done immediately, for reasons discussed earlier.) > > These patches implement the node device enumeration functionality, as > discussed here: > https://www.redhat.com/archives/libvir-list/2008-September/msg00398.html > > I've broken it into the following pieces: > 1-public-api additions to the public API > 2-internal-api additions to the internal API > 3-local-node-drivers the HAL & DeviceKit implementations > 4-remote-node-driver the remote driver > 5-virsh-support virsh support > 6-python-bindings python bindings > 7-java-bindings Java bindings (for libvirt-java) Hi Dave, Just in case you're wondering why there is no comment on those, I don't think there is a problem with the patches, my take is that we need to commit first the modularization fron Dan Berrange before pushing your patches due to HAL licencing. I intend to push them before the 0.5.0 release next week, so unless we get more comment on your patches, the current state will be used as the base. If you could just check that commit done in the meantime don't clash or change behaviour that would be nice, thanks in advance ! Daniel

Daniel(s) - In the attached set of patches, I've merged in DanB's reworking of the headers, etc. and adjusted my code accordingly. I've also renamed "NodeDriver" to "DeviceMonitor", as discussed with DanV, and added a --cap option to the virsh node-list-devices command.