[libvirt] [PATCH] 0/7 host ("node") device enumeration - completed submission
Since the version of this I posted last week still had some outstaning TODO items that I have since finished, I'm re-submitting the whole thing. I consider this a "complete submission" since I don't think it's necessary to implement any additional functionality to make this acceptable. (The two remaining unimplemented items are virNodeDeviceCreate / Destroy and a real Devkit impl, neither of which needs to be done immediately, for reasons discussed earlier.) These patches implement the node device enumeration functionality, as discussed here: https://www.redhat.com/archives/libvir-list/2008-September/msg00398.html I've broken it into the following pieces: 1-public-api additions to the public API 2-internal-api additions to the internal API 3-local-node-drivers the HAL & DeviceKit implementations 4-remote-node-driver the remote driver 5-virsh-support virsh support 6-python-bindings python bindings 7-java-bindings Java bindings (for libvirt-java) Dave
This patch contains the public API changes for host device enumeration.
This patch contains additions to the internal API for host device enumeration.
This patch contains the HAL-based implementation, and a preliminary DeviceKit-based implementation, of node device enumeration. The Devkit impl is very incomplete, mostly because Devkit itself is very immature at this stage.
This patch contains the remote implementation of node device enumeration.
This patch contains virsh support for node device enumeration.
This patch contains python bindings for node device enumeration.
This patch (for libvirt-java) contains Java bindings for node device enumeration.
On Mon, Oct 27, 2008 at 02:46:47PM -0400, David Lively wrote:
Since the version of this I posted last week still had some outstaning TODO items that I have since finished, I'm re-submitting the whole thing. I consider this a "complete submission" since I don't think it's necessary to implement any additional functionality to make this acceptable. (The two remaining unimplemented items are virNodeDeviceCreate / Destroy and a real Devkit impl, neither of which needs to be done immediately, for reasons discussed earlier.)
These patches implement the node device enumeration functionality, as discussed here: https://www.redhat.com/archives/libvir-list/2008-September/msg00398.html
I've broken it into the following pieces: 1-public-api additions to the public API 2-internal-api additions to the internal API 3-local-node-drivers the HAL & DeviceKit implementations 4-remote-node-driver the remote driver 5-virsh-support virsh support 6-python-bindings python bindings 7-java-bindings Java bindings (for libvirt-java)
Hi Dave, Just in case you're wondering why there is no comment on those, I don't think there is a problem with the patches, my take is that we need to commit first the modularization fron Dan Berrange before pushing your patches due to HAL licencing. I intend to push them before the 0.5.0 release next week, so unless we get more comment on your patches, the current state will be used as the base. If you could just check that commit done in the meantime don't clash or change behaviour that would be nice, thanks in advance ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Daniel(s) - In the attached set of patches, I've merged in DanB's reworking of the headers, etc. and adjusted my code accordingly. I've also renamed "NodeDriver" to "DeviceMonitor", as discussed with DanV, and added a --cap option to the virsh node-list-devices command. Dave On Tue, 2008-11-04 at 14:30 +0100, Daniel Veillard wrote:
On Mon, Oct 27, 2008 at 02:46:47PM -0400, David Lively wrote:
Since the version of this I posted last week still had some outstaning TODO items that I have since finished, I'm re-submitting the whole thing. I consider this a "complete submission" since I don't think it's necessary to implement any additional functionality to make this acceptable. (The two remaining unimplemented items are virNodeDeviceCreate / Destroy and a real Devkit impl, neither of which needs to be done immediately, for reasons discussed earlier.)
These patches implement the node device enumeration functionality, as discussed here: https://www.redhat.com/archives/libvir-list/2008-September/msg00398.html
I've broken it into the following pieces: 1-public-api additions to the public API 2-internal-api additions to the internal API 3-local-node-drivers the HAL & DeviceKit implementations 4-remote-node-driver the remote driver 5-virsh-support virsh support 6-python-bindings python bindings 7-java-bindings Java bindings (for libvirt-java)
Hi Dave,
Just in case you're wondering why there is no comment on those, I don't think there is a problem with the patches, my take is that we need to commit first the modularization fron Dan Berrange before pushing your patches due to HAL licencing. I intend to push them before the 0.5.0 release next week, so unless we get more comment on your patches, the current state will be used as the base. If you could just check that commit done in the meantime don't clash or change behaviour that would be nice,
thanks in advance !
Daniel
P.S. Patch 7/7 (Java bindings for host dev enum) hasn't changed. On Thu, 2008-11-06 at 21:32 -0500, David Lively wrote:
Daniel(s) - In the attached set of patches, I've merged in DanB's reworking of the headers, etc. and adjusted my code accordingly. I've also renamed "NodeDriver" to "DeviceMonitor", as discussed with DanV, and added a --cap option to the virsh node-list-devices command.
On Thu, Nov 06, 2008 at 09:32:17PM -0500, David Lively wrote:
Daniel(s) - In the attached set of patches, I've merged in DanB's reworking of the headers, etc. and adjusted my code accordingly. I've also renamed "NodeDriver" to "DeviceMonitor", as discussed with DanV, and added a --cap option to the virsh node-list-devices command.
BTW, I've not forgotton about these patches. They are all basically sane. I'm doing a little more work on my driver modularization patches to avoid the DBus / GPL issue, and have re-diffed your patches ontop of this. I'll post a combined set real soon, and then we can mergethe whole lot in one go. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Tue, Nov 11, 2008 at 09:46:18PM +0000, Daniel P. Berrange wrote:
On Thu, Nov 06, 2008 at 09:32:17PM -0500, David Lively wrote:
Daniel(s) - In the attached set of patches, I've merged in DanB's reworking of the headers, etc. and adjusted my code accordingly. I've also renamed "NodeDriver" to "DeviceMonitor", as discussed with DanV, and added a --cap option to the virsh node-list-devices command.
BTW, I've not forgotton about these patches. They are all basically sane. I'm doing a little more work on my driver modularization patches to avoid the DBus / GPL issue, and have re-diffed your patches ontop of this. I'll post a combined set real soon, and then we can mergethe whole lot in one go.
and then I will apply the libvirt-java patch independently :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
David Lively