On Thu, 2016-02-11 at 13:18 +0100, Michal Privoznik wrote:

After a03cbfe0fb9 we switched to a plain close() instead of VIR_FORCE_CLOSE(). This makes sense because it's a mocking library and thus should not require anything from libvirt. However, we forgot add an exemption to our 'forbid close' rule.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> ---  cfg.mk | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cfg.mk b/cfg.mk index 3f78842..dbd22a7 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1158,7 +1158,7 @@ exclude_file_name_regexp--sc_prohibit_strdup = \    ^(docs/|examples/|src/util/virstring\.c|tests/vir(netserverclient|cgroup)mock.c$$)    exclude_file_name_regexp--sc_prohibit_close = \ -  (\.p[yl]$$|\.spec\.in$$|^docs/|^(src/util/virfile\.c|src/libvirt-stream\.c|tests/vir(cgroup|pci)mock\.c)$$) +  (\.p[yl]$$|\.spec\.in$$|^docs/|^(src/util/virfile\.c|src/libvirt- stream\.c|tests/vir((cgroup|pci)mock|portallocatortest)\.c)$$)    exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \    (^tests/(qemuhelp|nodeinfo|virpcitest)data/|\.diff$$)

Yup, my bad. I'll try to split off the mock part of virportallocatortest.c instead, so we can still enjoy this check for the non-mock part of the test case. Stay tuned. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team