[libvirt PATCH 0/3] AUTHORS: Convert to reStructuredText
Plus some other adjustments. Andrea Bolognani (3): AUTHORS: Convert to reStructuredText AUTHORS: Some small tweaks AUTHORS: Remove Emacs file variables AUTHORS.in | 103 ----------------------------------- AUTHORS.rst.in | 99 +++++++++++++++++++++++++++++++++ libvirt.spec.in | 2 +- meson.build | 4 +- scripts/meson-gen-authors.py | 2 +- 5 files changed, 103 insertions(+), 107 deletions(-) delete mode 100644 AUTHORS.in create mode 100644 AUTHORS.rst.in -- 2.26.2
Now that we have moved to Meson, we are no longer required to use a specific name for this file, and since the rest of our documentation is in reStructuredText format and uses a matching file extension, we can give the AUTHORS file the same treatment. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- AUTHORS.in | 103 ---------------------------------- AUTHORS.rst.in | 104 +++++++++++++++++++++++++++++++++++ libvirt.spec.in | 2 +- meson.build | 4 +- scripts/meson-gen-authors.py | 2 +- 5 files changed, 108 insertions(+), 107 deletions(-) delete mode 100644 AUTHORS.in create mode 100644 AUTHORS.rst.in diff --git a/AUTHORS.in b/AUTHORS.in deleted file mode 100644 index f4ab42ea9f..0000000000 --- a/AUTHORS.in +++ /dev/null @@ -1,103 +0,0 @@ - libvirt Authors - =============== - -The libvirt project was initiated by: - -Daniel Veillard <veillard@redhat.com> or <daniel@veillard.com> - -The primary maintainers and people with commit access rights: - -Andrea Bolognani <abologna@redhat.com> -Cédric Bosdonnat <cbosdonnat@suse.com> -Christian Ehrhardt <christian.ehrhardt@canonical.com> -Christophe Fergeau <cfergeau@redhat.com> -Cole Robinson <crobinso@redhat.com> -Daniel P. Berrangé <berrange@redhat.com> -Daniel Veillard <veillard@redhat.com> -Eric Blake <eblake@redhat.com> -Erik Skultety <eskultet@redhat.com> -Fabiano Fidêncio <fidencio@redhat.com> -Guido Günther <agx@sigxcpu.org> -Ján Tomko <jtomko@redhat.com> -Jim Fehlig <jfehlig@suse.com> -Jiří Denemark <jdenemar@redhat.com> -Laine Stump <laine@redhat.com> -Martin Kletzander <mkletzan@redhat.com> -Michal Prívozník <mprivozn@redhat.com> -Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> -Pavel Hrdina <phrdina@redhat.com> -Peter Krempa <pkrempa@redhat.com> -Pino Toscano <ptoscano@redhat.com> -Richard W.M. Jones <rjones@redhat.com> -Roman Bogorodskiy <bogorodskiy@gmail.com> - -Previous maintainers: - -Alex Jia <ajia@redhat.com> -Anthony Liguori <aliguori@us.ibm.com> -Atsushi SAKAI <sakaia@jp.fujitsu.com> -Chris Lalancette <clalance@redhat.com> -Claudio Bley <claudio.bley@gmail.com> -Dan Smith <danms@us.ibm.com> -Dave Allan <dallan@redhat.com> -Dave Leskovec <dlesko@linux.vnet.ibm.com> -Dmitry Guryanov <dguryanov@parallels.com> -Doug Goldstein <cardoe@gentoo.org> -Gao Feng <gaofeng@cn.fujitsu.com> -Guannan Ren <gren@redhat.com> -Jim Meyering <meyering@redhat.com> -John Ferlan <jferlan@redhat.com> -John Levon <john.levon@sun.com> -Justin Clift <jclift@redhat.com> -Karel Zak <kzak@redhat.com> -Katerina Koukiou <kkoukiou@redhat.com> -Mark McLoughlin <markmc@redhat.com> -Matthias Bolte <matthias.bolte@googlemail.com> -Maxim Nestratov <mnestratov@virtuozzo.com> -Osier Yang <jyang@redhat.com> -Stefan Berger <stefanb@us.ibm.com> -Wen Congyang <wency@cn.fujitsu.com> - -Patches have also been contributed by: - -Abel Míguez Rodríguez <amiguezr@pdi.ucm.es> -Amit Shah <amit.shah@redhat.com> -Andrew Puch <apuch@redhat.com> -Anton Protopopov <aspsk2@gmail.com> -Ben Guthro <ben.guthro@gmail.com> -Daniel Hokka Zakrisson <daniel@hozac.com> -Dan Wendlandt <dan@nicira.com> -David Lively <dlively@virtualiron.com> -David Lutterkort <dlutter@redhat.com> -Evgeniy Sokolov <evg@openvz.org> -Hugh Brock <hbrock@redhat.com> -Itamar Heim <iheim@redhat.com> -James Morris <jmorris@namei.org> -Javier Fontan <jfontan@gmail.com> -Jeremy Katz <katzj@redhat.com> -Kaitlin Rupert <kaitlin@linux.vnet.ibm.com> -Kazuki Mizushima <mizushima.kazuk@jp.fujitsu.com> -Mads Chr. Olesen <shiyee@shiyee.dk> -Mark Johnson <johnson.nh@gmail.com> -Markus Armbruster <armbru@redhat.com> -Masayuki Sunou <fj1826dm@aa.jp.fujitsu.com> -Matthias Witte <witte@netzquadrat.de> -Michel Ponceau <michel.ponceau@bull.net> -Nobuhiro Itou <fj0873gn@aa.jp.fujitsu.com> -Pete Vetere <pvetere@redhat.com> -Philippe Berthault <philippe.berthault@Bull.net> -Saori Fukuta <fukuta.saori@jp.fujitsu.com> -Shigeki Sakamoto <fj0588di@aa.jp.fujitsu.com> -Shuveb Hussain <shuveb@binarykarma.com> -Stefan de Konink <dekonink@kinkrsoftware.nl> -Takahashi Tomohiro <takatom@jp.fujitsu.com> -Tatsuro Enokura <fj7716hz@aa.jp.fujitsu.com> - -@contributorslist@ - -The libvirt logo was designed by Diana Fong - --- End -;; Local Variables: -;; coding: utf-8 -;; End: diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in new file mode 100644 index 0000000000..5a651b22db --- /dev/null +++ b/AUTHORS.rst.in @@ -0,0 +1,104 @@ +=============== +libvirt Authors +=============== + +The libvirt project was initiated by: + +* Daniel Veillard <veillard@redhat.com> or <daniel@veillard.com> + +The primary maintainers and people with commit access rights: + +* Andrea Bolognani <abologna@redhat.com> +* Cédric Bosdonnat <cbosdonnat@suse.com> +* Christian Ehrhardt <christian.ehrhardt@canonical.com> +* Christophe Fergeau <cfergeau@redhat.com> +* Cole Robinson <crobinso@redhat.com> +* Daniel P. Berrangé <berrange@redhat.com> +* Daniel Veillard <veillard@redhat.com> +* Eric Blake <eblake@redhat.com> +* Erik Skultety <eskultet@redhat.com> +* Fabiano Fidêncio <fidencio@redhat.com> +* Guido Günther <agx@sigxcpu.org> +* Ján Tomko <jtomko@redhat.com> +* Jim Fehlig <jfehlig@suse.com> +* Jiří Denemark <jdenemar@redhat.com> +* Laine Stump <laine@redhat.com> +* Martin Kletzander <mkletzan@redhat.com> +* Michal Prívozník <mprivozn@redhat.com> +* Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> +* Pavel Hrdina <phrdina@redhat.com> +* Peter Krempa <pkrempa@redhat.com> +* Pino Toscano <ptoscano@redhat.com> +* Richard W.M. Jones <rjones@redhat.com> +* Roman Bogorodskiy <bogorodskiy@gmail.com> + +Previous maintainers: + +* Alex Jia <ajia@redhat.com> +* Anthony Liguori <aliguori@us.ibm.com> +* Atsushi SAKAI <sakaia@jp.fujitsu.com> +* Chris Lalancette <clalance@redhat.com> +* Claudio Bley <claudio.bley@gmail.com> +* Dan Smith <danms@us.ibm.com> +* Dave Allan <dallan@redhat.com> +* Dave Leskovec <dlesko@linux.vnet.ibm.com> +* Dmitry Guryanov <dguryanov@parallels.com> +* Doug Goldstein <cardoe@gentoo.org> +* Gao Feng <gaofeng@cn.fujitsu.com> +* Guannan Ren <gren@redhat.com> +* Jim Meyering <meyering@redhat.com> +* John Ferlan <jferlan@redhat.com> +* John Levon <john.levon@sun.com> +* Justin Clift <jclift@redhat.com> +* Karel Zak <kzak@redhat.com> +* Katerina Koukiou <kkoukiou@redhat.com> +* Mark McLoughlin <markmc@redhat.com> +* Matthias Bolte <matthias.bolte@googlemail.com> +* Maxim Nestratov <mnestratov@virtuozzo.com> +* Osier Yang <jyang@redhat.com> +* Stefan Berger <stefanb@us.ibm.com> +* Wen Congyang <wency@cn.fujitsu.com> + +Patches have also been contributed by: + +* Abel Míguez Rodríguez <amiguezr@pdi.ucm.es> +* Amit Shah <amit.shah@redhat.com> +* Andrew Puch <apuch@redhat.com> +* Anton Protopopov <aspsk2@gmail.com> +* Ben Guthro <ben.guthro@gmail.com> +* Daniel Hokka Zakrisson <daniel@hozac.com> +* Dan Wendlandt <dan@nicira.com> +* David Lively <dlively@virtualiron.com> +* David Lutterkort <dlutter@redhat.com> +* Evgeniy Sokolov <evg@openvz.org> +* Hugh Brock <hbrock@redhat.com> +* Itamar Heim <iheim@redhat.com> +* James Morris <jmorris@namei.org> +* Javier Fontan <jfontan@gmail.com> +* Jeremy Katz <katzj@redhat.com> +* Kaitlin Rupert <kaitlin@linux.vnet.ibm.com> +* Kazuki Mizushima <mizushima.kazuk@jp.fujitsu.com> +* Mads Chr. Olesen <shiyee@shiyee.dk> +* Mark Johnson <johnson.nh@gmail.com> +* Markus Armbruster <armbru@redhat.com> +* Masayuki Sunou <fj1826dm@aa.jp.fujitsu.com> +* Matthias Witte <witte@netzquadrat.de> +* Michel Ponceau <michel.ponceau@bull.net> +* Nobuhiro Itou <fj0873gn@aa.jp.fujitsu.com> +* Pete Vetere <pvetere@redhat.com> +* Philippe Berthault <philippe.berthault@Bull.net> +* Saori Fukuta <fukuta.saori@jp.fujitsu.com> +* Shigeki Sakamoto <fj0588di@aa.jp.fujitsu.com> +* Shuveb Hussain <shuveb@binarykarma.com> +* Stefan de Konink <dekonink@kinkrsoftware.nl> +* Takahashi Tomohiro <takatom@jp.fujitsu.com> +* Tatsuro Enokura <fj7716hz@aa.jp.fujitsu.com> + +@contributorslist@ + +The libvirt logo was designed by Diana Fong + +-- End +;; Local Variables: +;; coding: utf-8 +;; End: diff --git a/libvirt.spec.in b/libvirt.spec.in index f024f7bfc4..a39d250680 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1487,7 +1487,7 @@ exit 0 %files %files docs -%doc AUTHORS NEWS.rst README.rst +%doc AUTHORS.rst NEWS.rst README.rst %doc libvirt-docs/* %files daemon diff --git a/meson.build b/meson.build index 35e3da6e55..8d18ce3493 100644 --- a/meson.build +++ b/meson.build @@ -2300,7 +2300,7 @@ if git endforeach authors = run_command(python3_prog, meson_gen_authors_prog.path(), env: runutf8) - authors_file = 'AUTHORS.in' + authors_file = 'AUTHORS.rst.in' authors_conf = configuration_data() authors_conf.set('contributorslist', authors.stdout()) @@ -2314,7 +2314,7 @@ if git # Using return values from configure_file in add_dist_script is possible since 0.55.0 dist_files = [ 'libvirt.spec', - 'AUTHORS', + 'AUTHORS.rst', ] foreach file : dist_files diff --git a/scripts/meson-gen-authors.py b/scripts/meson-gen-authors.py index f58bf6383b..8551e9ea68 100755 --- a/scripts/meson-gen-authors.py +++ b/scripts/meson-gen-authors.py @@ -5,4 +5,4 @@ import os meson_source_root = os.environ['MESON_SOURCE_ROOT'] os.chdir(meson_source_root) -os.system('git log --pretty=format:"%aN <%aE>" | sort -u') +os.system('git log --pretty=format:"* %aN <%aE>" | sort -u') -- 2.26.2
On a Tuesday in 2020, Andrea Bolognani wrote:
Now that we have moved to Meson, we are no longer required to use a specific name for this file, and since the rest of our documentation is in reStructuredText format and uses a matching file extension, we can give the AUTHORS file the same treatment.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- AUTHORS.in | 103 ---------------------------------- AUTHORS.rst.in | 104 +++++++++++++++++++++++++++++++++++ libvirt.spec.in | 2 +- meson.build | 4 +- scripts/meson-gen-authors.py | 2 +- 5 files changed, 108 insertions(+), 107 deletions(-) delete mode 100644 AUTHORS.in create mode 100644 AUTHORS.rst.in
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- AUTHORS.rst.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in index 5a651b22db..9c4e1a3726 100644 --- a/AUTHORS.rst.in +++ b/AUTHORS.rst.in @@ -2,11 +2,11 @@ libvirt Authors =============== -The libvirt project was initiated by: +The libvirt project was started by: * Daniel Veillard <veillard@redhat.com> or <daniel@veillard.com> -The primary maintainers and people with commit access rights: +Primary maintainers and people with commit access rights are: * Andrea Bolognani <abologna@redhat.com> * Cédric Bosdonnat <cbosdonnat@suse.com> @@ -32,7 +32,7 @@ The primary maintainers and people with commit access rights: * Richard W.M. Jones <rjones@redhat.com> * Roman Bogorodskiy <bogorodskiy@gmail.com> -Previous maintainers: +Previous maintainers are: * Alex Jia <ajia@redhat.com> * Anthony Liguori <aliguori@us.ibm.com> @@ -96,7 +96,7 @@ Patches have also been contributed by: @contributorslist@ -The libvirt logo was designed by Diana Fong +The libvirt logo was designed by Diana Fong. -- End ;; Local Variables: -- 2.26.2
On a Tuesday in 2020, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Missing commit message.
--- AUTHORS.rst.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in index 5a651b22db..9c4e1a3726 100644 --- a/AUTHORS.rst.in +++ b/AUTHORS.rst.in @@ -2,11 +2,11 @@ libvirt Authors ===============
-The libvirt project was initiated by: +The libvirt project was started by:
What's wrong with initiated?
* Daniel Veillard <veillard@redhat.com> or <daniel@veillard.com>
-The primary maintainers and people with commit access rights: +Primary maintainers and people with commit access rights are:
What is the benefit of adding the word 'are'?
* Andrea Bolognani <abologna@redhat.com> * Cédric Bosdonnat <cbosdonnat@suse.com> @@ -32,7 +32,7 @@ The primary maintainers and people with commit access rights: * Richard W.M. Jones <rjones@redhat.com> * Roman Bogorodskiy <bogorodskiy@gmail.com>
-Previous maintainers: +Previous maintainers are:
* Alex Jia <ajia@redhat.com> * Anthony Liguori <aliguori@us.ibm.com>
@@ -96,7 +96,7 @@ Patches have also been contributed by:
@contributorslist@
-The libvirt logo was designed by Diana Fong +The libvirt logo was designed by Diana Fong.
This hunk looks good. Jano
-- End ;; Local Variables: -- 2.26.2
On Tue, 2020-08-25 at 18:47 +0200, Ján Tomko wrote:
On a Tuesday in 2020, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Missing commit message.
I figured this kind of changes didn't require much in the way of explanation.
-The libvirt project was initiated by: +The libvirt project was started by:
What's wrong with initiated?
It seems unnecessarily formal.
-The primary maintainers and people with commit access rights: +Primary maintainers and people with commit access rights are:
What is the benefit of adding the word 'are'?
Two of the existing lists take the following form: "The libvirt project was initiated by X" "Patches have also been contributed by X" This change makes the remaining two lists similar: "Primary maintainers are X" "Previous maintainers are X" It's ultimately mostly down to preferences... If you don't like the changes in this patch I will happily drop it, the one I really care about is the first one in the series.
-The libvirt logo was designed by Diana Fong +The libvirt logo was designed by Diana Fong.
This hunk looks good.
\o/ -- Andrea Bolognani / Red Hat / Virtualization
vim seems to be able to process the file just fine without a modeline, so it's probably fair to assume Emacs doesn't need any extra help either. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- AUTHORS.rst.in | 5 ----- 1 file changed, 5 deletions(-) diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in index 9c4e1a3726..6182b262ee 100644 --- a/AUTHORS.rst.in +++ b/AUTHORS.rst.in @@ -97,8 +97,3 @@ Patches have also been contributed by: @contributorslist@ The libvirt logo was designed by Diana Fong. - --- End -;; Local Variables: -;; coding: utf-8 -;; End: -- 2.26.2
On a Tuesday in 2020, Andrea Bolognani wrote:
vim seems to be able to process the file just fine without a modeline, so it's probably fair to assume Emacs doesn't need any extra help either.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- AUTHORS.rst.in | 5 ----- 1 file changed, 5 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
participants (2)
-
Andrea Bolognani -
Ján Tomko