[libvirt PATCH v2] rpm: Explain BuildRequires on qemu-img
It's not used as part of the build process or searched for at build time, and the QEMU driver detects its path at runtime, so one could think that the BuildRequires is unnecessary. But we actually need it to be present at build time in order to run the full test suite. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c542ec3b2b..1f77cd90b7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -310,7 +310,7 @@ BuildRequires: util-linux %if %{with_qemu} # For managing ACLs BuildRequires: libacl-devel -# From QEMU RPMs +# From QEMU RPMs, used by virstoragetest BuildRequires: /usr/bin/qemu-img %endif # For LVM drivers -- 2.40.1
On Wed, May 10, 2023 at 03:08:37PM +0200, Andrea Bolognani wrote:
It's not used as part of the build process or searched for at build time, and the QEMU driver detects its path at runtime, so one could think that the BuildRequires is unnecessary. But we actually need it to be present at build time in order to run the full test suite.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Now pushed as trivial. -- Andrea Bolognani / Red Hat / Virtualization
participants (1)
-
Andrea Bolognani