[libvirt] [PATCH] Fix lv scanning with encrypted volumes
See https://bugzilla.redhat.com/show_bug.cgi?id=470693 Using ':' as a delimiter for the lvs command isn't reliable, since it looks like encrypted volume groups have a colon in the physical device name, which throws of the regex. The attached patch changes the delimiter to ','. Maintains existing behavior for me, just waiting on confirmation from the reporter that this indeed does the job. Thanks, Cole
On Wed, Nov 12, 2008 at 04:37:16PM -0500, Cole Robinson wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=470693
Using ':' as a delimiter for the lvs command isn't reliable, since it looks like encrypted volume groups have a colon in the physical device name, which throws of the regex. The attached patch changes the delimiter to ','.
Maintains existing behavior for me, just waiting on confirmation from the reporter that this indeed does the job.
ACK if it fixes the bug. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Daniel P. Berrange wrote:
On Wed, Nov 12, 2008 at 04:37:16PM -0500, Cole Robinson wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=470693
Using ':' as a delimiter for the lvs command isn't reliable, since it looks like encrypted volume groups have a colon in the physical device name, which throws of the regex. The attached patch changes the delimiter to ','.
Maintains existing behavior for me, just waiting on confirmation from the reporter that this indeed does the job.
ACK if it fixes the bug.
Daniel
Okay, reporter confirmed the fix. I've just pushed this. Thanks, Cole
participants (2)
-
Cole Robinson -
Daniel P. Berrange