[libvirt] [PATCH] Bump minimum libvirt requirement to 1.2.13
libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi -LIBVIRT_REQUIRED=1.2.9 +LIBVIRT_REQUIRED=1.2.13 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED) PKG_CHECK_MODULES(QEMU, libvirt-qemu) AC_SUBST([QEMU_CFLAGS]) -- 2.5.5
On Thu, Apr 21, 2016 at 6:20 AM, Christophe Fergeau <cfergeau@redhat.com> wrote:
libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi
-LIBVIRT_REQUIRED=1.2.9 +LIBVIRT_REQUIRED=1.2.13 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED) PKG_CHECK_MODULES(QEMU, libvirt-qemu) AC_SUBST([QEMU_CFLAGS]) -- 2.5.5
I'm okay with this patch, it doesn't break any of the platforms I'm supporting (EL7, Fedora 22+). -- 真実はいつも一つ！/ Always, there's only one truth!
On Thu, Apr 21, 2016 at 7:18 AM, Neal Gompa <ngompa13@gmail.com> wrote:
On Thu, Apr 21, 2016 at 6:20 AM, Christophe Fergeau <cfergeau@redhat.com> wrote:
libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi
-LIBVIRT_REQUIRED=1.2.9 +LIBVIRT_REQUIRED=1.2.13 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED) PKG_CHECK_MODULES(QEMU, libvirt-qemu) AC_SUBST([QEMU_CFLAGS]) -- 2.5.5
I'm okay with this patch, it doesn't break any of the platforms I'm supporting (EL7, Fedora 22+).
Actually, I just realized that you need to also correct src/config.m4 as well, since that one still says the minimum version is 1.2.8. -- 真実はいつも一つ！/ Always, there's only one truth!
On Thu, Apr 21, 2016 at 07:26:07AM -0400, Neal Gompa wrote:
Actually, I just realized that you need to also correct src/config.m4 as well, since that one still says the minimum version is 1.2.8.
Ah thanks, I grepped for 1.2.9 to see if I missed any version elsewhere, did not think there could be a different version in config.m4. Christophe
Why not add ifdef? I'm OK with this,but may be good think to not break build because of small changes like this. 21 Апр 2016 г. 13:22 пользователь "Christophe Fergeau" <cfergeau@redhat.com> написал:
libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi
-LIBVIRT_REQUIRED=1.2.9 +LIBVIRT_REQUIRED=1.2.13 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED) PKG_CHECK_MODULES(QEMU, libvirt-qemu) AC_SUBST([QEMU_CFLAGS]) -- 2.5.5
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (4)
-
Christophe Fergeau -
Michal Privoznik -
Neal Gompa -
Vasiliy Tolstov