[libvirt] [libvirt PATCH] node_device: Clean up unused macros

All of these macros are not used anymore, remove them. --- src/node_device/node_device_driver.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_device_driver.h index 2dff70f..0f62c83 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -28,15 +28,6 @@ # include "driver.h" # include "node_device_conf.h" -# define LINUX_SYSFS_SCSI_HOST_PREFIX "/sys/class/scsi_host/" -# define LINUX_SYSFS_SCSI_HOST_POSTFIX "device" -# define LINUX_SYSFS_FC_HOST_PREFIX "/sys/class/fc_host/" - -# define VPORT_CREATE 0 -# define VPORT_DELETE 1 -# define LINUX_SYSFS_VPORT_CREATE_POSTFIX "/vport_create" -# define LINUX_SYSFS_VPORT_DELETE_POSTFIX "/vport_delete" - # define LINUX_NEW_DEVICE_WAIT_TIME 60 # ifdef WITH_HAL -- 1.8.1.4

On Mon, May 13, 2013 at 06:14:52PM +0800, Osier Yang wrote:
All of these macros are not used anymore, remove them.
s/are not used anymore, remove/are now unused, so remove/
--- src/node_device/node_device_driver.h | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_device_driver.h index 2dff70f..0f62c83 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -28,15 +28,6 @@ # include "driver.h" # include "node_device_conf.h"
-# define LINUX_SYSFS_SCSI_HOST_PREFIX "/sys/class/scsi_host/" -# define LINUX_SYSFS_SCSI_HOST_POSTFIX "device" -# define LINUX_SYSFS_FC_HOST_PREFIX "/sys/class/fc_host/" - -# define VPORT_CREATE 0 -# define VPORT_DELETE 1 -# define LINUX_SYSFS_VPORT_CREATE_POSTFIX "/vport_create" -# define LINUX_SYSFS_VPORT_DELETE_POSTFIX "/vport_delete" - # define LINUX_NEW_DEVICE_WAIT_TIME 60
# ifdef WITH_HAL
ACK with commit message change Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

On 13/05/13 18:18, Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 06:14:52PM +0800, Osier Yang wrote:
All of these macros are not used anymore, remove them. s/are not used anymore, remove/are now unused, so remove/
--- src/node_device/node_device_driver.h | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_device_driver.h index 2dff70f..0f62c83 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -28,15 +28,6 @@ # include "driver.h" # include "node_device_conf.h"
-# define LINUX_SYSFS_SCSI_HOST_PREFIX "/sys/class/scsi_host/" -# define LINUX_SYSFS_SCSI_HOST_POSTFIX "device" -# define LINUX_SYSFS_FC_HOST_PREFIX "/sys/class/fc_host/" - -# define VPORT_CREATE 0 -# define VPORT_DELETE 1 -# define LINUX_SYSFS_VPORT_CREATE_POSTFIX "/vport_create" -# define LINUX_SYSFS_VPORT_DELETE_POSTFIX "/vport_delete" - # define LINUX_NEW_DEVICE_WAIT_TIME 60
# ifdef WITH_HAL ACK with commit message change
Thanks, pushed with the change.
participants (2)
-
Daniel P. Berrange
-
Osier Yang