[PATCH 0/1]scripts: Fix the parameter of warning function - Devel - Libvirt List Archives

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

December

[PATCH 0/1]scripts: Fix the parameter of warning function

[PATCH] scripts: Fix the parameter...

[PATCH] scripts: Fix the parameter...

luzhipeng

Saturday, 12 March 2022 Sat, 12 Mar '22

1:41 a.m.

luzhipeng (1): scripts: Fix the parameter of warning function scripts/apibuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.0.windows.1

Reply

Show replies by date

luzhipeng

Saturday, 12 March Sat, 12 Mar

1:42 a.m.

New subject: [PATCH 1/1] scripts: Fix the parameter of warning function

--- scripts/apibuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/apibuild.py b/scripts/apibuild.py index bdd3077c48..99b16f47fa 100755 --- a/scripts/apibuild.py +++ b/scripts/apibuild.py @@ -317,7 +317,7 @@ class index: if type in type_map: type_map[type][name] = d else: - self.warning("Unable to register type ", type) + self.warning("Unable to register type %s" % type) if name == debugsym and not quiet: print("New symbol: %s" % (d)) -- 2.34.0.windows.1

Reply

Michal Prívozník

Monday, 14 March Mon, 14 Mar

5:16 a.m.

New subject: [PATCH 1/1] scripts: Fix the parameter of warning function

On 3/12/22 08:42, luzhipeng wrote:

--- scripts/apibuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/apibuild.py b/scripts/apibuild.py index bdd3077c48..99b16f47fa 100755 --- a/scripts/apibuild.py +++ b/scripts/apibuild.py @@ -317,7 +317,7 @@ class index: if type in type_map: type_map[type][name] = d else: - self.warning("Unable to register type ", type) + self.warning("Unable to register type %s" % type) if name == debugsym and not quiet: print("New symbol: %s" % (d))

Hey, the patch is correct. However, in order to be merged couple of requirements have to be met: 1) the commit message must contain your Signed-off-by line: https://libvirt.org/hacking.html#developer-certificate-of-origin 2) speaking of commit message - you should introduce one. If I'd look at this commit in git log (long after it's been pushed), I would have no idea what it does and what problem it's fixing. It doesn't have to be long, in fact the shorter the better. But too short is not good either. I'm open to make an exception and if you reply to this e-mail with the commit message and your Signed-off-by line I can amend those and merge. Michal

Reply

1014

days inactive

1016

days old

devel@lists.libvirt.org

Manage subscription

2 comments

2 participants

tags (0)

participants (2)

luzhipeng
Michal Prívozník