On Monday, November 25, 2019, Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; wrote: > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3ad9fd5a). > > Please don't start any deprecation process. This requires certain consultation within my company. Rest assured that everyone's opinion will be taken into account while doing consiltation.

On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: > On Monday, November 25, 2019, Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; > wrote: > > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > > logical change was in 2005 (9542611a6). After we can count 164 > > maintenance commits (QEMU API changes) with the exception of > > 1 fix in 2015 (memory leak, commit 3ad9fd5a). > > > > > Please don't start any deprecation process. This requires certain > consultation within my company. Rest assured that everyone's opinion will > be taken into account while doing consiltation. The idea of having a deprecation process is precisely to allow time for people like to provide feedback before any deletion takes place. So this is not a reason to delay starting of deprecation.

The process lasts for 2 releases before we delete anything: https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features When we start the clock now, it is deprecated when 5.0 releases in April 2020, and still deprecated with 5.1 in August 2020. The code won't be deleted until Sep 2020 when 5.2 dev cycle opens, and there's still time to undelete it right up until the 5.2 feature freeze in late Oct 2020. That's 11 months away, which is plenty of time for feedback IMHO. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commits (QEMU API changes) with the exception of 1 fix in 2015 (memory leak, commit 3ad9fd5a). This machine was introduced as a proof of concept to run a MIPS CPU. 2 years later, the Malta machine was add (commit 5856de80) modeling a real platform. Note also this machine has no specification except 5 lines in the header of this file: * emulates a simple machine with ISA-like bus. * ISA IO space mapped to the 0x14000000 (PHYS) and * ISA memory at the 0x10000000 (PHYS, 16Mb in size). * All peripherial devices are attached to this "bus" with * the standard PC ISA addresses. It is time to deprecate this obsolete machine. Users are recommended to use the Malta board, which hardware is well documented. Signed-off-by: Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; --- qemu-deprecated.texi | 5 +++++ hw/mips/mips_r4k.c | 1 + MAINTAINERS | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-)

On Tuesday, November 26, 2019, Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; wrote: > > Hi Aleksandar, > > On 11/26/19 9:46 PM, Aleksandar Markovic wrote: >> >> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé >> <philmd(a)redhat.com&gt; wrote: >>> >>> >>> The r4k machine was introduced in 2005 (6af0bf9c7) and its last >>> logical change was in 2005 (9542611a6). After we can count 164 >>> maintenance commits (QEMU API changes) with the exception of >>> 1 fix in 2015 (memory leak, commit 3ad9fd5a). >>> >>> This machine was introduced as a proof of concept to run a MIPS >>> CPU. 2 years later, the Malta machine was add (commit 5856de80) >>> modeling a real platform. >>> >>> Note also this machine has no specification except 5 lines in >>> the header of this file: >>> >>> * emulates a simple machine with ISA-like bus. >>> * ISA IO space mapped to the 0x14000000 (PHYS) and >>> * ISA memory at the 0x10000000 (PHYS, 16Mb in size). >>> * All peripherial devices are attached to this "bus" with >>> * the standard PC ISA addresses. >>> >>> It is time to deprecate this obsolete machine. Users are >>> recommended to use the Malta board, which hardware is well >>> documented. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; >>> --- >> >> >> Philippe, >> >> I see you added "libvir-list" in "cc". Was it a mistake, or there was >> some purpose? > > > I don't pick the series recipient manually, I send my series with git-publish. Here it used the default QEMU profile. > > All profiles call git-sendmail with the cc-cmd set to the get_maintainer.pl script: > > $ cat .gitpublish > # > # Common git-publish profiles that can be used to send patches to QEMU upstream. > # > # See https://github.com/stefanha/git-publish for more information > # > [gitpublishprofile "default"] > base = master > to = qemu-devel(a)nongnu.org > cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null > > Having a closer look, libvir-list list was Cc'ed because it is listed as reviewer of the qemu-deprecated.texi file, which was modified. > > ./scripts/get_maintainer.pl -f qemu-deprecated.texi > libvir-list(a)redhat.com (reviewer:Incompatible changes) > qemu-devel(a)nongnu.org (open list:All patches CC here) > OK. No problem. It just looked strange. As far as consuktations, I am just waiting for some responses within company to establish if somebody is perhaps using this machine with some ancient kernel. I got some opinions that are in favor of R4000 machine deprecating, but I need to wait for all relevant departments to confirm. What happened to TileGX?

On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; wrote: > > Hi Aleksandar, > > On 11/27/19 7:47 PM, Aleksandar Markovic wrote: >> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé >> <philmd(a)redhat.com&gt; wrote: >>> >>> The r4k machine was introduced in 2005 (6af0bf9c7) and its last >>> logical change was in 2005 (9542611a6). After we can count 164 >>> maintenance commits (QEMU API changes) with the exception of >>> 1 fix in 2015 (memory leak, commit 3ad9fd5a). >>> >>> This machine was introduced as a proof of concept to run a MIPS >>> CPU. 2 years later, the Malta machine was add (commit 5856de80) >>> modeling a real platform. >>> > > Since you queued this patch, do you mind adding Aurelien comment to the > patch description, as it appears important information: > > ''' > The Linux kernel support for this machine has been dropped more > than 10 years ago in this commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit... > ''' > > I was not sure when sending the patch, but as an improvement, we can > also remove Aurelien and Aleksandar Rikalo from the MAINTAINERS section. > > And I assume we can also add (which was explicit in your previous patch): > Acked-by: Aurelien Jarno <aurelien(a)aurel32.net&gt; > > If you want I can resend this patch with all that amended. > No need to resend, I'll fix the things while applying.