[libvirt] [PATCH python 0/2] Python binding for node device update event API
Jovanka Gulicoska (2): Add support for node device update callback event-test: support node device update callback examples/event-test.py | 4 ++++ libvirt-override-virConnect.py | 10 ++++++++ libvirt-override.c | 54 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+) -- 2.7.4
--- libvirt-override-virConnect.py | 10 ++++++++ libvirt-override.c | 54 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py index 87c5483..fb3d476 100644 --- a/libvirt-override-virConnect.py +++ b/libvirt-override-virConnect.py @@ -357,6 +357,16 @@ cb(self, virNodeDevice(self, _obj=dev), event, detail, opaque) return 0 + def _dispatchNodeDeviceEventGenericCallback(self, dev, cbData): + """Dispatches events to python user node device + generic event callbacks + """ + cb = cbData["cb"] + opaque = cbData["opaque"] + + cb(self, virNodeDevice(self, _obj=dev), opaque) + return 0 + def nodeDeviceEventDeregisterAny(self, callbackID): """Removes a Node Device Event Callback. De-registering for a node device callback will disable delivery of this event type""" diff --git a/libvirt-override.c b/libvirt-override.c index f6590e4..07d1d19 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -9067,6 +9067,56 @@ libvirt_virConnectNodeDeviceEventLifecycleCallback(virConnectPtr conn ATTRIBUTE_ return ret; } +static int +libvirt_virConnectNodeDeviceEventGenericCallback(virConnectPtr conn ATTRIBUTE_UNUSED, + virNodeDevicePtr dev, + void *opaque) +{ + PyObject *pyobj_cbData = (PyObject*)opaque; + PyObject *pyobj_dev; + PyObject *pyobj_ret = NULL; + PyObject *pyobj_conn; + PyObject *dictKey; + int ret = -1; + + LIBVIRT_ENSURE_THREAD_STATE; + + if (!(dictKey = libvirt_constcharPtrWrap("conn"))) + goto cleanup; + pyobj_conn = PyDict_GetItem(pyobj_cbData, dictKey); + Py_DECREF(dictKey); + + /* Create a python instance of this virNodeDevicePtr */ + virNodeDeviceRef(dev); + if (!(pyobj_dev = libvirt_virNodeDevicePtrWrap(dev))) { + virNodeDeviceFree(dev); + goto cleanup; + } + Py_INCREF(pyobj_cbData); + + /* Call the Callback Dispatcher */ + pyobj_ret = PyObject_CallMethod(pyobj_conn, + (char*)"_dispatchNodeDeviceEventGenericCallback", + (char*)"OO", + pyobj_dev, + pyobj_cbData); + + Py_DECREF(pyobj_cbData); + Py_DECREF(pyobj_dev); + + cleanup: + if (!pyobj_ret) { + DEBUG("%s - ret:%p\n", __FUNCTION__, pyobj_ret); + PyErr_Print(); + } else { + Py_DECREF(pyobj_ret); + ret = 0; + } + + LIBVIRT_RELEASE_THREAD_STATE; + return ret; +} + static PyObject * libvirt_virConnectNodeDeviceEventRegisterAny(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) @@ -9098,6 +9148,10 @@ libvirt_virConnectNodeDeviceEventRegisterAny(PyObject *self ATTRIBUTE_UNUSED, cb = VIR_NODE_DEVICE_EVENT_CALLBACK(libvirt_virConnectNodeDeviceEventLifecycleCallback); break; + case VIR_NODE_DEVICE_EVENT_ID_UPDATE: + cb = VIR_NODE_DEVICE_EVENT_CALLBACK(libvirt_virConnectNodeDeviceEventGenericCallback); + break; + case VIR_NODE_DEVICE_EVENT_ID_LAST: break; } -- 2.7.4
--- examples/event-test.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 9b59b92..e43a2f8 100755 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -597,6 +597,9 @@ def myNodeDeviceEventLifecycleCallback(conn, dev, event, detail, opaque): nodeDeviceEventToString(event), detail)) +def myNodeDeviceEventUpdateCallback(conn, dev, opaque): + print("myNodeDeviceEventUpdateCallback: Node device %s" % dev.name()) + ########################################################################## # Set up and run the program ########################################################################## @@ -693,6 +696,7 @@ def main(): vc.storagePoolEventRegisterAny(None, libvirt.VIR_STORAGE_POOL_EVENT_ID_REFRESH, myStoragePoolEventRefreshCallback, None) vc.nodeDeviceEventRegisterAny(None, libvirt.VIR_NODE_DEVICE_EVENT_ID_LIFECYCLE, myNodeDeviceEventLifecycleCallback, None) + vc.nodeDeviceEventRegisterAny(None, libvirt.VIR_NODE_DEVICE_EVENT_ID_UPDATE, myNodeDeviceEventUpdateCallback, None) vc.setKeepAlive(5, 3) -- 2.7.4
On 08/17/2016 04:27 AM, Jovanka Gulicoska wrote:
Jovanka Gulicoska (2): Add support for node device update callback event-test: support node device update callback
examples/event-test.py | 4 ++++ libvirt-override-virConnect.py | 10 ++++++++ libvirt-override.c | 54 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+)
ACK and pushed Thanks, Cole
participants (2)
-
Cole Robinson -
Jovanka Gulicoska