[libvirt] [PATCH] remote: Fill snapshot argument in remoteDomainSnapshotListAllChildren

The remote driver did not fill the required snapshot parent argument in the RPC call structure that caused a client crash when trying to use this new API. --- src/remote/remote_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index b9e2127..afd367b 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5015,6 +5015,7 @@ remoteDomainSnapshotListAllChildren(virDomainSnapshotPtr parent, args.need_results = !!snapshots; args.flags = flags; + make_nonnull_domain_snapshot(&args.snapshot, parent); memset(&ret, 0, sizeof(ret)); if (call (parent->domain->conn, -- 1.7.8.6

On 03.08.2012 11:57, Peter Krempa wrote:
The remote driver did not fill the required snapshot parent argument in the RPC call structure that caused a client crash when trying to use this new API. --- src/remote/remote_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index b9e2127..afd367b 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5015,6 +5015,7 @@ remoteDomainSnapshotListAllChildren(virDomainSnapshotPtr parent,
args.need_results = !!snapshots; args.flags = flags; + make_nonnull_domain_snapshot(&args.snapshot, parent);
memset(&ret, 0, sizeof(ret)); if (call (parent->domain->conn,
ACK Michal

On 08/03/12 11:59, Michal Privoznik wrote:
On 03.08.2012 11:57, Peter Krempa wrote:
The remote driver did not fill the required snapshot parent argument in the RPC call structure that caused a client crash when trying to use this new API. --- src/remote/remote_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Pushed; Thanks! Peter
participants (2)
-
Michal Privoznik
-
Peter Krempa