[libvirt] VMware ESX: Allow leading dots in VMX config entry names
Hi, '.encoding = "UTF-8"' is a valid VMX config entry, so the virConfParser must accept it in VMX mode. This patch lets the parser accept those names with leading dots. Regards, Matthias
On 27/07/09 12:25, Matthias Bolte wrote:
'.encoding = "UTF-8"' is a valid VMX config entry, so the virConfParser must accept it in VMX mode. This patch lets the parser accept those names with leading dots.
With that patch ESX4i gets a bit further but barfs on a version check: error: internal error Expecting VMX entry 'virtualHW.version' to be "4" but found "7" Tom -- Tom Hughes (tom@compton.nu) http://www.compton.nu/
2009/7/27 Tom Hughes <tom@compton.nu>:
On 27/07/09 12:25, Matthias Bolte wrote:
'.encoding = "UTF-8"' is a valid VMX config entry, so the virConfParser must accept it in VMX mode. This patch lets the parser accept those names with leading dots.
With that patch ESX4i gets a bit further but barfs on a version check:
error: internal error Expecting VMX entry 'virtualHW.version' to be "4" but found "7"
Tom
It seems that I should setup an ESXi 4 just in case there are more differences between version 3.5 and 4.0. See the other patch regarding VI API 4.0, that one should fix the virtualHW.version problem and make the version checking more robust. Regards, Matthias
On 27/07/09 13:28, Matthias Bolte wrote:
It seems that I should setup an ESXi 4 just in case there are more differences between version 3.5 and 4.0.
See the other patch regarding VI API 4.0, that one should fix the virtualHW.version problem and make the version checking more robust.
Latest git code is now able to connect to 4i, list domains, and dumpxml their definitions. Tom -- Tom Hughes (tom@compton.nu) http://www.compton.nu/
On Mon, Jul 27, 2009 at 01:44:44PM +0100, Tom Hughes wrote:
On 27/07/09 13:28, Matthias Bolte wrote:
It seems that I should setup an ESXi 4 just in case there are more differences between version 3.5 and 4.0.
See the other patch regarding VI API 4.0, that one should fix the virtualHW.version problem and make the version checking more robust.
Latest git code is now able to connect to 4i, list domains, and dumpxml their definitions.
Great, thanks for the quick feedback ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Mon, Jul 27, 2009 at 01:25:01PM +0200, Matthias Bolte wrote:
Hi,
'.encoding = "UTF-8"' is a valid VMX config entry, so the virConfParser must accept it in VMX mode. This patch lets the parser accept those names with leading dots.
Okay, simple, applied ! thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Daniel Veillard -
Matthias Bolte -
Tom Hughes