noon
This also adjusts the argument name which should be 'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com>
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f81d20e5f7..bfa7211894 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf,
/* qemuBuildTLSx509BackendProps:
* @tlspath: path to the TLS credentials
- * @listen: boolen listen for client or server setting
+ * @isListen: boolen listen for client or server setting
* @verifypeer: boolean to enable peer verification (form of authorization)
* @alias: alias for the TLS credentials object
* @secalias: if one exists, the alias of the security object for passwordid
@@ -917,7 +917,7 @@ qemuBuildTLSx509BackendProps(const char *tlspath,
/* qemuBuildTLSx509CommandLine:
* @cmd: Pointer to command
* @tlspath: path to the TLS credentials
- * @listen: boolen listen for client or server setting
+ * @isListen: boolean listen for client or server setting
* @verifypeer: boolean to enable peer verification (form of authorization)
* @certEncSecretAlias: alias of a 'secret' object for decrypting TLS private
key
* (optional)
--
2.21.0
noon
New subject: [libvirt] [PATCH 2/2] doc: Fix 'encryption' documentation
There are 2 examples of use of <encryption> which uses a 'type'
attribute rather than 'format' as documented in the XML schema:
<define name='encryption'>
<element name='encryption'>
<attribute name='format'>
<choice>
<value>default</value>
<value>qcow</value>
<value>luks</value>
</choice>
</attribute>
<interleave>
<ref name='secret'/>
<optional>
<element name='cipher'>
<ref name='keycipher'/>
</element>
<element name='ivgen'>
<ref name='keyivgen'/>
</element>
</optional>
</interleave>
</element>
</define>
This also matches what virStorageEncryptionParseNode() is doing.
Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com>
---
docs/formatdomain.html.in | 2 +-
docs/formatstorage.html.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 0e3799061d..4052eb2528 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2761,7 +2761,7 @@
<write_iops_sec>100000</write_iops_sec>
</iotune>
<boot order='2'/>
- <encryption type='...'>
+ <encryption format='...'>
...
</encryption>
<shareable/>
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
index 2a7604d136..dd2f27e54c 100644
--- a/docs/formatstorage.html.in
+++ b/docs/formatstorage.html.in
@@ -761,7 +761,7 @@
<mtime>1341930622.047245868</mtime>
<ctime>1341930622.047245868</ctime>
</timestamps>
- <encryption type='...'>
+ <encryption format='...'>
...
</encryption>
<compat>1.1</compat>
--
2.21.0
12:13 p.m.
On Wednesday, 27 March 2019 12:00:21 CET Christophe Fergeau wrote:
This also adjusts the argument name which should be
'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com>
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f81d20e5f7..bfa7211894 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf,
/* qemuBuildTLSx509BackendProps:
* @tlspath: path to the TLS credentials
- * @listen: boolen listen for client or server setting
+ * @isListen: boolen listen for client or server setting
Still "boolen"...
--
Pino Toscano
12:20 p.m.
On Wed, Mar 27, 2019 at 12:13:41PM +0100, Pino Toscano wrote:
On Wednesday, 27 March 2019 12:00:21 CET Christophe Fergeau wrote:
> This also adjusts the argument name which should be 'isListen' in both
> cases rather than 'listen'.
>
> Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com>
> ---
> src/qemu/qemu_command.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index f81d20e5f7..bfa7211894 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf,
>
> /* qemuBuildTLSx509BackendProps:
> * @tlspath: path to the TLS credentials
> - * @listen: boolen listen for client or server setting
> + * @isListen: boolen listen for client or server setting
Still "boolen"...
Oops... going to send a v2 !
Christophe
2003
days inactive
2003
days old
3 comments
2 participants
participants (2)
-
Christophe Fergeau -
Pino Toscano