2011/5/4 Eric Blake <eblake@redhat.com>:

Detected by clang.

* src/esx/esx_util.c (esxUtil_ParseDatastorePath): No need to increment. ---  src/esx/esx_util.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index 9ef947c..640e984 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -2,7 +2,7 @@  /*  * esx_util.c: utility functions for the VMware ESX driver  * - * Copyright (C) 2010 Red Hat, Inc. + * Copyright (C) 2010-2011 Red Hat, Inc.  * Copyright (C) 2009 Matthias Bolte <matthias.bolte@googlemail.com>  * Copyright (C) 2009 Maximilian Wilhelm <max@rfc2324.org>  * @@ -332,7 +332,7 @@ esxUtil_ParseDatastorePath(const char *datastorePath, char **datastoreName,         preliminaryFileName = strrchr(preliminaryDirectoryAndFileName, '/');

        if (preliminaryFileName != NULL) { -            *preliminaryFileName++ = '\0'; +            *preliminaryFileName = '\0';         }

        if (esxVI_String_DeepCopyValue(directoryName, -- 1.7.4.4

This fixes the problem, but I prefer the attached patch. Matthias