On 12/10/2014 08:25 AM, Hao Liu wrote:

Signed-off-by: Hao Liu <hliu@redhat.com> --- HACKING | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

This file is generated from docs/hacking.html.in. You should edit that one instead, regenerate HACKING and include both in the patch. Jan

diff --git a/HACKING b/HACKING index 884e78c..94d9d2c 100644 --- a/HACKING +++ b/HACKING @@ -383,8 +383,9 @@ single-'statement' loop: each has only one 'line' in its body. single_line_stmt(); // {} is optional (not enforced either way)

while (expr1 && - expr2) // multi-line, at same indentation, {} required + expr2) { // multi-line, at same indentation, {} required single_line_stmt(); + }

However, the moment your loop/if/else body extends on to a second line, for whatever reason (even if it's just an added comment), then you should add