10:29 a.m.
While reviewing patches [1] I've found two problems with syntax-check
which are trivial to fix. These are the patches I've pushed.
1: https://www.redhat.com/archives/libvir-list/2020-March/msg01124.html
Michal Prívozník (2):
syntax-check: Disallow plain fork() in src/libvirt.c
syntax-check.mk: Drop needless _src2 variable
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.24.1
10:29 a.m.
New subject: [PATCH 1/2] syntax-check: Disallow plain fork() in src/libvirt.c
The last usage of plain fork() was removed in v0.9.7-rc1~50, but
we forgot to update the syntax-check exemption list accordingly.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 45bcf45e80..888e358848 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -2016,7 +2016,7 @@ exclude_file_name_regexp--sc_prohibit_close = \
exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \
(^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|\.diff|tests/virconfdata/no-newline\.conf$$)
-_src2=src/(util/(vircommand|virdaemon)|libvirt|lxc/lxc_controller)
+_src2=src/(util/(vircommand|virdaemon)|lxc/lxc_controller)
exclude_file_name_regexp--sc_prohibit_fork_wrappers = \
(^($(_src2)|tests/testutils)\.c$$)
--
2.24.1
10:38 a.m.
New subject: [PATCH 1/2] syntax-check: Disallow plain fork() in src/libvirt.c
On Fri, Mar 27, 2020 at 04:29:54PM +0100, Michal Privoznik wrote:
The last usage of plain fork() was removed in v0.9.7-rc1~50, but
we forgot to update the syntax-check exemption list accordingly.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
10:29 a.m.
New subject: [PATCH 2/2] syntax-check.mk: Drop needless _src2 variable
The aim was to break a long line, but it is not long anymore.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 888e358848..db3c0cff0f 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -2016,9 +2016,8 @@ exclude_file_name_regexp--sc_prohibit_close = \
exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \
(^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|\.diff|tests/virconfdata/no-newline\.conf$$)
-_src2=src/(util/(vircommand|virdaemon)|lxc/lxc_controller)
exclude_file_name_regexp--sc_prohibit_fork_wrappers = \
- (^($(_src2)|tests/testutils)\.c$$)
+ (^(src/(util/(vircommand|virdaemon)|lxc/lxc_controller)|tests/testutils)\.c$$)
exclude_file_name_regexp--sc_prohibit_gethostname = ^src/util/vir(util|log)\.c$$
--
2.24.1
10:39 a.m.
New subject: [PATCH 2/2] syntax-check.mk: Drop needless _src2 variable
On Fri, Mar 27, 2020 at 04:29:55PM +0100, Michal Privoznik wrote:
The aim was to break a long line, but it is not long anymore.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
1731
days inactive
1731
days old
4 comments
2 participants
participants (2)
-
Daniel P. Berrangé -
Michal Privoznik