[libvirt] [PATCH 0/2] Cosmetic changes to the banner SVGs to enable object alignment
Erik Skultety (2): docs: logos: Remove empty text elements from the banner SVGs docs: logos: Resize the 'Drop shadow' filter bounding box docs/logos/logo-banner-dark.svg | 39 +++++---------------------------------- docs/logos/logo-banner-light.svg | 39 +++++---------------------------------- 2 files changed, 10 insertions(+), 68 deletions(-) -- 2.13.6
These just add to the confusion when opened in inkscape. Signed-off-by: Erik Skultety <eskultet@redhat.com> --- docs/logos/logo-banner-dark.svg | 33 --------------------------------- docs/logos/logo-banner-light.svg | 33 --------------------------------- 2 files changed, 66 deletions(-) diff --git a/docs/logos/logo-banner-dark.svg b/docs/logos/logo-banner-dark.svg index f9b7d95e2..0af83fd59 100644 --- a/docs/logos/logo-banner-dark.svg +++ b/docs/logos/logo-banner-dark.svg @@ -604,39 +604,6 @@ id="path2809" d="M 203.927,231.912 80.383,53.463 c 3.583,-3.084 8.164,-5.73 13.116,-7.479 6.902,12.484 25.22,44.608 54.336,88.542 22.713,34.272 46.085,68.024 64.139,91.973 -2.35,2.316 -5.102,4.145 -8.047,5.413 z m -3.597,1.245 c -1.392,0.368 -2.805,0.615 -4.223,0.733 L 75.218,59.278 c 0.699,-1.099 1.537,-2.181 2.494,-3.23 z" /> </g> - <text - xml:space="preserve" - style="font-style:normal;font-weight:normal;font-size:40px;line-height:125%;font-family:Sans;text-align:start;letter-spacing:0px;word-spacing:0px;text-anchor:start;fill:#000000;fill-opacity:1;stroke:none;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" - x="-408.52026" - y="53.587437" - id="text5053" - transform="rotate(1.0000002)"><tspan - sodipodi:role="line" - id="tspan5055" - x="-408.52026" - y="88.978058" /></text> - <text - xml:space="preserve" - style="font-style:normal;font-weight:normal;font-size:90px;line-height:125%;font-family:Sans;text-align:start;letter-spacing:0px;word-spacing:0px;text-anchor:start;fill:#000000;fill-opacity:1;stroke:none;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" - x="-525.88629" - y="-232.88652" - id="text5057" - transform="rotate(1.0000002)"><tspan - sodipodi:role="line" - id="tspan5059" - x="-525.88629" - y="-153.25761" /></text> - <text - xml:space="preserve" - style="font-style:normal;font-weight:normal;font-size:40px;line-height:125%;font-family:Sans;text-align:start;letter-spacing:0px;word-spacing:0px;text-anchor:start;fill:#000000;fill-opacity:1;stroke:none;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" - x="543.02759" - y="-200.07454" - id="text5069" - transform="rotate(1.0000002)"><tspan - sodipodi:role="line" - id="tspan5071" - x="543.02759" - y="-164.68391" /></text> </g> <text xml:space="preserve" diff --git a/docs/logos/logo-banner-light.svg b/docs/logos/logo-banner-light.svg index 5ce32537f..4349534cb 100644 --- a/docs/logos/logo-banner-light.svg +++ b/docs/logos/logo-banner-light.svg @@ -601,39 +601,6 @@ style="clip-rule:evenodd;fill:url(#radialGradient4507-5);fill-opacity:1;fill-rule:evenodd" inkscape:connector-curvature="0" /> </g> - <text - transform="rotate(1.0000002)" - id="text5053-8" - y="53.587437" - x="-408.52026" - style="font-style:normal;font-weight:normal;font-size:40px;line-height:125%;font-family:Sans;text-align:start;letter-spacing:0px;word-spacing:0px;text-anchor:start;fill:#000000;fill-opacity:1;stroke:none;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" - xml:space="preserve"><tspan - y="88.978058" - x="-408.52026" - id="tspan5055-5" - sodipodi:role="line" /></text> - <text - transform="rotate(1.0000002)" - id="text5057-0" - y="-232.88652" - x="-525.88629" - style="font-style:normal;font-weight:normal;font-size:90px;line-height:125%;font-family:Sans;text-align:start;letter-spacing:0px;word-spacing:0px;text-anchor:start;fill:#000000;fill-opacity:1;stroke:none;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" - xml:space="preserve"><tspan - y="-153.25761" - x="-525.88629" - id="tspan5059-6" - sodipodi:role="line" /></text> - <text - transform="rotate(1.0000002)" - id="text5069-4" - y="-200.07454" - x="543.02759" - style="font-style:normal;font-weight:normal;font-size:40px;line-height:125%;font-family:Sans;text-align:start;letter-spacing:0px;word-spacing:0px;text-anchor:start;fill:#000000;fill-opacity:1;stroke:none;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" - xml:space="preserve"><tspan - y="-164.68391" - x="543.02759" - id="tspan5071-6" - sodipodi:role="line" /></text> </g> <text id="text5811-2" -- 2.13.6
Inkscape makes "Drop shadow" filter's bounding box unnecessarily large. Since inkscape will make a union of all the objects to form an image, which means that our logos end up having an undesired "space" padding from one side only which in turn makes usage of vertical alignment of objects clumsy, since it the spacing would always make it look as out of alignment. The official way to "fix" this is to fiddle with the coordinates of the box and adjust its dimensions, not ideal as it lacks precision, but makes a difference. Signed-off-by: Erik Skultety <eskultet@redhat.com> --- docs/logos/logo-banner-dark.svg | 6 +++++- docs/logos/logo-banner-light.svg | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/logos/logo-banner-dark.svg b/docs/logos/logo-banner-dark.svg index 0af83fd59..47080bb40 100644 --- a/docs/logos/logo-banner-dark.svg +++ b/docs/logos/logo-banner-dark.svg @@ -22,7 +22,11 @@ <filter style="color-interpolation-filters:sRGB" inkscape:label="Drop Shadow" - id="filter5799"> + id="filter5799" + x="-0.030000000000000000" + y="-0.030000000000000000" + width="1.0800000000000000" + height="1.0800000000000000"> <feFlood flood-opacity="1" flood-color="rgb(0,0,0)" diff --git a/docs/logos/logo-banner-light.svg b/docs/logos/logo-banner-light.svg index 4349534cb..5f7b4e561 100644 --- a/docs/logos/logo-banner-light.svg +++ b/docs/logos/logo-banner-light.svg @@ -22,7 +22,11 @@ <filter style="color-interpolation-filters:sRGB" inkscape:label="Drop Shadow" - id="filter5799-39"> + id="filter5799-39" + x="-0.030000000000000000" + y="-0.030000000000000000" + width="1.0800000000000000" + height="1.0800000000000000"> <feFlood flood-opacity="1" flood-color="rgb(0,0,0)" -- 2.13.6
On 02/25/2018 11:45 PM, Erik Skultety wrote:
Erik Skultety (2): docs: logos: Remove empty text elements from the banner SVGs docs: logos: Resize the 'Drop shadow' filter bounding box
docs/logos/logo-banner-dark.svg | 39 +++++---------------------------------- docs/logos/logo-banner-light.svg | 39 +++++---------------------------------- 2 files changed, 10 insertions(+), 68 deletions(-)
ACK and safe for freeze. Don't we need to regenerate PNGs esp. after 2/2? Michal
On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote:
On 02/25/2018 11:45 PM, Erik Skultety wrote:
Erik Skultety (2): docs: logos: Remove empty text elements from the banner SVGs docs: logos: Resize the 'Drop shadow' filter bounding box
docs/logos/logo-banner-dark.svg | 39 +++++---------------------------------- docs/logos/logo-banner-light.svg | 39 +++++---------------------------------- 2 files changed, 10 insertions(+), 68 deletions(-)
ACK and safe for freeze. Don't we need to regenerate PNGs esp. after 2/2?
Well, actually, yes, we should, I'll do that later today, but for a different reason - for PNG, you'd normally just resize the canvas if spacing was an issue for you, but if you look at the big version of our logo at the webpage from a close distance, you can see that the shape of the dropped shadow in the upper left corner isn't smooth, in fact, it looks like there's some vertical cut out. Thanks, Erik
On Mon, Feb 26, 2018 at 12:20:49PM +0100, Erik Skultety wrote:
On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote:
On 02/25/2018 11:45 PM, Erik Skultety wrote:
Erik Skultety (2): docs: logos: Remove empty text elements from the banner SVGs docs: logos: Resize the 'Drop shadow' filter bounding box
docs/logos/logo-banner-dark.svg | 39 +++++---------------------------------- docs/logos/logo-banner-light.svg | 39 +++++---------------------------------- 2 files changed, 10 insertions(+), 68 deletions(-)
ACK and safe for freeze. Don't we need to regenerate PNGs esp. after 2/2?
Well, actually, yes, we should, I'll do that later today, but for a different reason - for PNG, you'd normally just resize the canvas if spacing was an issue for you, but if you look at the big version of our logo at the webpage from a close distance, you can see that the shape of the dropped shadow in the upper left corner isn't smooth, in fact, it looks like there's some vertical cut out.
There's also a little clipping on the top-right corner of the box. I think this is caused by slight differences in how inkscape and gimp interpret the SVG file. I used gimp because inkscape created badly antialiased images at the lower resolutions. I think we might be able to address it by using inkscape to create a large PNG (eg 2048 pixels), and then use GIMP to resize that large image to smaller bitmaps. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Mon, Feb 26, 2018 at 11:41:16AM +0000, Daniel P. Berrangé wrote:
On Mon, Feb 26, 2018 at 12:20:49PM +0100, Erik Skultety wrote:
On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote:
On 02/25/2018 11:45 PM, Erik Skultety wrote:
Erik Skultety (2): docs: logos: Remove empty text elements from the banner SVGs docs: logos: Resize the 'Drop shadow' filter bounding box
docs/logos/logo-banner-dark.svg | 39 +++++---------------------------------- docs/logos/logo-banner-light.svg | 39 +++++---------------------------------- 2 files changed, 10 insertions(+), 68 deletions(-)
ACK and safe for freeze. Don't we need to regenerate PNGs esp. after 2/2?
Well, actually, yes, we should, I'll do that later today, but for a different reason - for PNG, you'd normally just resize the canvas if spacing was an issue for you, but if you look at the big version of our logo at the webpage from a close distance, you can see that the shape of the dropped shadow in the upper left corner isn't smooth, in fact, it looks like there's some vertical cut out.
There's also a little clipping on the top-right corner of the box. I think this is caused by slight differences in how inkscape and gimp interpret the SVG file.
'Clipping' - that's the correct terminology I was looking for, thanks. Anyhow, I didn't notice the top-right corner, thanks for pointing that out.
I used gimp because inkscape created badly antialiased images at the lower resolutions. I think we might be able to address it by using inkscape to create a large PNG (eg 2048 pixels), and then use GIMP to resize that large image to smaller bitmaps.
Okay, I'll send a separate series for that and once that's good to go, I'll push it along with this series. Erik
participants (3)
-
Daniel P. Berrangé -
Erik Skultety -
Michal Privoznik