[libvirt] [PATCH] conf: fix not jump to cleanup when parse a host id is invalid
https://bugzilla.redhat.com/show_bug.cgi?id=1196503 We already check whether the host id is valid or not, add a jump to forbid invalid host id. Signed-off-by: Luyao Huang <lhuang@redhat.com> --- src/conf/network_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 3d8bf05..52fcf3d 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -717,6 +717,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName, virReportError(VIR_ERR_XML_ERROR, _("Invalid character '%c' in id '%s' of network '%s'"), *cp, id, networkName); + goto cleanup; } } -- 1.8.3.1
On Thu, Feb 26, 2015 at 02:14:20PM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1196503
We already check whether the host id is valid or not, add a jump to forbid invalid host id.
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- src/conf/network_conf.c | 1 + 1 file changed, 1 insertion(+)
ACK Introduced by v1.0.3-rc1~7, I will push it to v1.1.3-maint and v1.2.9-maint as well. Jan
On 02/26/2015 03:56 PM, Ján Tomko wrote:
On Thu, Feb 26, 2015 at 02:14:20PM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1196503
We already check whether the host id is valid or not, add a jump to forbid invalid host id.
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- src/conf/network_conf.c | 1 + 1 file changed, 1 insertion(+) ACK
Thanks for your quick review.
Introduced by v1.0.3-rc1~7, I will push it to v1.1.3-maint and v1.2.9-maint as well.
Jan
Luyao
participants (3)
-
Ján Tomko -
lhuang -
Luyao Huang