On Thu, Jul 04, 2013 at 11:48:22AM +0200, Ján Tomko wrote:
Partially revert cdd703f's revert of c163410, as linking with
clang
with --param=ssp-buffer-size=4 still fails with:
"argument unused during compilation".
---
This is technically a build-breaker fix, but I haven't pushed it yet,
to prevent reverting a revert of a revert.
m4/virt-compile-warnings.m4 | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index c6794b7..8731b70 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -185,6 +185,13 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
dnl gl_WARN_ADD([-fstack-protector])
gl_WARN_ADD([-fstack-protector-all])
gl_WARN_ADD([--param=ssp-buffer-size=4])
+ dnl Even though it supports it, clang complains about
+ dnl use of --param=ssp-buffer-size=4 unless used with
+ dnl the -c arg. It doesn't like it when used with args
+ dnl that just link together .o files. Unfortunately
+ dnl we can't avoid that with automake, so we must turn
+ dnl off the following clang specific warning
+ gl_WARN_ADD([-Wno-unused-command-line-argument])
;;
*-*-freebsd*)
dnl FreeBSD ships old gcc 4.2.1 which doesn't handle
ACK, I was just about to say this needed reverting too.
The gnulib update only fixed the detection of supported
compiler flags. It didn't (and can't) fix this flaw in
automake.
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|:
http://entangle-photo.org -o-
http://live.gnome.org/gtk-vnc :|