[libvirt] [PATCH] [configure] Fix libvirt dependency, and use $VAPIGEN
This is a rather trivial patch to raise the minimum libvirt dependency; at least 0.9.4 is required. In addition, it fixes the direct usage of `vapigen`, and uses the result of the AC_PATH_PROG(VAPIGEN ...) call earlier so that the binary to be used can be overridden as that macro was meant to allow. Thanks! configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
From: Nirbheek Chauhan <nirbheek@gentoo.org> libvirt-0.9.4 is needed for at least VIR_DOMAIN_EVENT_SUSPENDED_RESTORED, etc from c1ff5dc63dc9d9ec05485bb695cbc66850759ee5 . $VAPIGEN from AC_PATH_PROG should be used instead of the raw binary `vapigen` otherwise it's not possible to override the vapigen binary to be used. --- configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ac7a8f..4f87b37 100644 --- a/configure.ac +++ b/configure.ac @@ -10,7 +10,7 @@ AC_CANONICAL_HOST AM_SILENT_RULES([yes]) -LIBVIRT_REQUIRED=0.5.0 +LIBVIRT_REQUIRED=0.9.4 GLIB2_REQUIRED=2.10.0 GOBJECT2_REQUIRED=2.10.0 GIO_REQUIRED=2.10.0 @@ -217,7 +217,7 @@ if test "x$enable_introspection" = "xyes" ; then fi if test "x$enable_vala" != "xno" ; then AC_MSG_CHECKING([$VAPIGEN support for --metadatadir]) - vapigen --help | grep metadatadir 1>/dev/null 2>&1 + $VAPIGEN --help | grep metadatadir 1>/dev/null 2>&1 if test $? != 0 ; then if test "x$enable_vala" == "xcheck" ; then enable_vala=no -- 1.7.3.4
On Mon, Nov 07, 2011 at 02:55:01PM +0530, nirbheek@gentoo.org wrote:
From: Nirbheek Chauhan <nirbheek@gentoo.org>
libvirt-0.9.4 is needed for at least VIR_DOMAIN_EVENT_SUSPENDED_RESTORED, etc from c1ff5dc63dc9d9ec05485bb695cbc66850759ee5 .
$VAPIGEN from AC_PATH_PROG should be used instead of the raw binary `vapigen` otherwise it's not possible to override the vapigen binary to be used. --- configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac index 0ac7a8f..4f87b37 100644 --- a/configure.ac +++ b/configure.ac @@ -10,7 +10,7 @@ AC_CANONICAL_HOST
AM_SILENT_RULES([yes])
-LIBVIRT_REQUIRED=0.5.0 +LIBVIRT_REQUIRED=0.9.4 GLIB2_REQUIRED=2.10.0 GOBJECT2_REQUIRED=2.10.0 GIO_REQUIRED=2.10.0 @@ -217,7 +217,7 @@ if test "x$enable_introspection" = "xyes" ; then fi if test "x$enable_vala" != "xno" ; then AC_MSG_CHECKING([$VAPIGEN support for --metadatadir]) - vapigen --help | grep metadatadir 1>/dev/null 2>&1 + $VAPIGEN --help | grep metadatadir 1>/dev/null 2>&1 if test $? != 0 ; then if test "x$enable_vala" == "xcheck" ; then enable_vala=no
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 07.11.2011 10:25, nirbheek@gentoo.org wrote:
This is a rather trivial patch to raise the minimum libvirt dependency; at least 0.9.4 is required. In addition, it fixes the direct usage of `vapigen`, and uses the result of the AC_PATH_PROG(VAPIGEN ...) call earlier so that the binary to be used can be overridden as that macro was meant to allow.
Thanks!
configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Just for the record, this is for libvirt-glib Michal
On Mon, Nov 7, 2011 at 3:33 PM, Michal Privoznik <mprivozn@redhat.com> wrote:
On 07.11.2011 10:25, nirbheek@gentoo.org wrote:
This is a rather trivial patch to raise the minimum libvirt dependency; at least 0.9.4 is required. In addition, it fixes the direct usage of `vapigen`, and uses the result of the AC_PATH_PROG(VAPIGEN ...) call earlier so that the binary to be used can be overridden as that macro was meant to allow.
Just for the record, this is for libvirt-glib
Ah yes, I forgot to put that in the subject, didn't I? Sorry about that. :-)
On 11/07/2011 03:03 AM, Michal Privoznik wrote:
On 07.11.2011 10:25, nirbheek@gentoo.org wrote:
This is a rather trivial patch to raise the minimum libvirt dependency; at least 0.9.4 is required. In addition, it fixes the direct usage of `vapigen`, and uses the result of the AC_PATH_PROG(VAPIGEN ...) call earlier so that the binary to be used can be overridden as that macro was meant to allow.
Thanks!
configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Just for the record, this is for libvirt-glib
To make it easier for yourself, add this to libvirt-glib/.git/config: [format] subjectprefix = libvirt-glib PATCH (or similarly for any other libvrit-SUB project). Then your patches will automatically be prefixed with designation that it is for a subproject and not for the top-level libvirt.git, which will help in sorting threads as long as all the subprojects still share the primary libvir-list mailing list. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Mon, Nov 7, 2011 at 10:10 PM, Eric Blake <eblake@redhat.com> wrote:
To make it easier for yourself, add this to libvirt-glib/.git/config:
[format] subjectprefix = libvirt-glib PATCH
(or similarly for any other libvrit-SUB project). Then your patches will automatically be prefixed with designation that it is for a subproject and not for the top-level libvirt.git, which will help in sorting threads as long as all the subprojects still share the primary libvir-list mailing list.
Thank you for the tip! I've added this now. :) -- ~Nirbheek Chauhan Gentoo GNOME+Mozilla Team
participants (5)
-
Daniel P. Berrange -
Eric Blake -
Michal Privoznik -
Nirbheek Chauhan -
nirbheek＠gentoo.org