[libvirt] [PATCH] secret: Fix error for private secrets
When trying to get the value of a private secret, the code used 'operation denied' error. That error is specified as an error for read-only connections trying to perform denied operation. The following error seems more accurate. To compare the difference: - BEFORE error: operation secret is private forbidden for read only access - AFTER error: Invalid secret: secret is private --- src/secret/secret_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 2ad66dd..67c7323 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -1,7 +1,7 @@ /* * secret_driver.c: local driver for secret manipulation API * - * Copyright (C) 2009-2011 Red Hat, Inc. + * Copyright (C) 2009-2012 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -990,7 +990,7 @@ secretGetValue(virSecretPtr obj, size_t *value_size, unsigned int flags, if ((internalFlags & VIR_SECRET_GET_VALUE_INTERNAL_CALL) == 0 && secret->def->private) { - virReportError(VIR_ERR_OPERATION_DENIED, "%s", + virReportError(VIR_ERR_INVALID_SECRET, "%s", _("secret is private")); goto cleanup; } -- 1.7.12
On 09/18/12 15:53, Martin Kletzander wrote:
When trying to get the value of a private secret, the code used 'operation denied' error. That error is specified as an error for read-only connections trying to perform denied operation. The following error seems more accurate.
To compare the difference: - BEFORE error: operation secret is private forbidden for read only access
- AFTER error: Invalid secret: secret is private --- src/secret/secret_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACK, the previous version of the error message didn't make sense. Peter
On 09/18/2012 04:09 PM, Peter Krempa wrote:
On 09/18/12 15:53, Martin Kletzander wrote:
When trying to get the value of a private secret, the code used 'operation denied' error. That error is specified as an error for read-only connections trying to perform denied operation. The following error seems more accurate.
To compare the difference: - BEFORE error: operation secret is private forbidden for read only access
- AFTER error: Invalid secret: secret is private --- src/secret/secret_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACK, the previous version of the error message didn't make sense.
Peter
Thanks, pushed. Martin
participants (2)
-
Martin Kletzander -
Peter Krempa