Richard W.M. Jones wrote: I should add that I use it like this: dnl Check for libvirt, sets LIBVIRT_VERSION. AC_LIBVIRT dnl Libvirt must be >= 0.2.1 AC_MSG_CHECKING([libvirt >= 0.2.1]) if test $LIBVIRT_VERSION -ge 2001; then AC_MSG_RESULT([ok]) else AC_MSG_ERROR([please upgrade your libvirt library]) fi Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

Daniel P. Berrange wrote: Hmmm. pkg-config doesn't work with packages installed in non-standard places. (In fact for me the use of PKG_CHECK_MODULES in configure.in prevents me from installing on Debian at all, but that's possibly another story). However the real reason I went down this route was to check for the libvirt-python bindings ... See the bottom of the attached file. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

"Richard W.M. Jones" <rjones(a)redhat.com&gt; wrote: Hi Rich, In general, the autoconf "way" is to perform feature tests, rather than version-number comparison tests. The problem with the latter is that the invoking code can end up looking really obtuse, much like portable pre-autoconf #ifdef spaghetti C did. Also, if there's a way to do the test solely at compile- or link-time, that'd be good, since a run-test causes trouble when cross-compiling. With a library like libvirt, you might want to provide autoconf tests that detect "version X.Y or newer" by checking for some public symbol that was introduced in version X.Y, or maybe by a compile-check for a changed signature in a published header. If you really need the version of the library itself and can't rely on pkg-config (not everyone has that, and it's not always spelled that way), then you might consider making libvirt publish a symbol like __libvirt_version_X_Y_Z. Then an autoconf macro could find the version number with just a few link tests. Of course, that won't help for versions that predate the addition of the first __libvirt_version_X_Y_Z symbol. Jim

Hi Rich, I'd stick with just using pkg-config to check for the library itself and using a runtime check for supported drivers. As for checking for the python module, I don't really think virt-manager wants to do this at build time since it's not actually a build dep. Personally I think I'd prefer an install time check for python modules rather than runtime checks, but it seems that runtime checking is the usual python way. Cheers, Mark.