[libvirt] [PATCH] bhyve: caps: Log error message when CPU init fails
virBhyveCapsInitCPU will raise a libvirt error; even though we treat it as non-fatal we should log the actual message. --- src/bhyve/bhyve_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index d2970a2..93faaed 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -97,7 +97,7 @@ virBhyveCapsBuild(void) goto error; if (virBhyveCapsInitCPU(caps, virArchFromHost()) < 0) - VIR_WARN("Failed to get host CPU"); + VIR_WARN("Failed to get host CPU: %s", virGetLastErrorMessage()); return caps; -- 2.5.0
Cole Robinson wrote:
virBhyveCapsInitCPU will raise a libvirt error; even though we treat it as non-fatal we should log the actual message. --- src/bhyve/bhyve_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index d2970a2..93faaed 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -97,7 +97,7 @@ virBhyveCapsBuild(void) goto error;
if (virBhyveCapsInitCPU(caps, virArchFromHost()) < 0) - VIR_WARN("Failed to get host CPU"); + VIR_WARN("Failed to get host CPU: %s", virGetLastErrorMessage());
return caps;
ACK Roman Bogorodskiy
On 03/19/2016 02:48 PM, Roman Bogorodskiy wrote:
Cole Robinson wrote:
virBhyveCapsInitCPU will raise a libvirt error; even though we treat it as non-fatal we should log the actual message. --- src/bhyve/bhyve_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index d2970a2..93faaed 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -97,7 +97,7 @@ virBhyveCapsBuild(void) goto error;
if (virBhyveCapsInitCPU(caps, virArchFromHost()) < 0) - VIR_WARN("Failed to get host CPU"); + VIR_WARN("Failed to get host CPU: %s", virGetLastErrorMessage());
return caps;
ACK
Roman Bogorodskiy
Thanks, pushed now - Cole
participants (2)
-
Cole Robinson -
Roman Bogorodskiy