[libvirt] Re: BUG REPORT: -net tap, fd=X does not work correctly in kvm-86

Josh Wilsdon wrote:
We are doing work with libvirt 0.6.3 through which we have started virtual machines. Using the same "create" command with the same storage, the same everything else this configuration works with both kvm-84 and kvm-85. When I built a fresh version of kvm-86 this stopped working with an error:
qemu: invalid parameter '15' in 'fd=15,script=,vlan=0,ifname=vnet0'
It's a libvirt bug. script and ifname have never been valid parameters for -net tap. Historically, -net has ignored unknown options but recently, it now throws an error when encountering an unsupported option. Regards, Anthony Liguori

Hi, are You sure about that? at least ifname seems to be valid parameter, I'm using it for naming host interfaces for tens of my kvms... and both are stated in kvm-85 help: -net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile] in general the error message Josh is posting seems to be talking about something else anyways: invalid parameter 15... On Fri, May 22, 2009 at 09:12:55PM -0500, Anthony Liguori wrote:
Josh Wilsdon wrote:
We are doing work with libvirt 0.6.3 through which we have started virtual machines. Using the same "create" command with the same storage, the same everything else this configuration works with both kvm-84 and kvm-85. When I built a fresh version of kvm-86 this stopped working with an error:
qemu: invalid parameter '15' in 'fd=15,script=,vlan=0,ifname=vnet0'
It's a libvirt bug. script and ifname have never been valid parameters for -net tap. Historically, -net has ignored unknown options but recently, it now throws an error when encountering an unsupported option.
Regards,
Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

When I built a fresh version of kvm-86 this stopped working with an error:
qemu: invalid parameter '15' in 'fd=15,script=,vlan=0,ifname=vnet0'
It's a libvirt bug. script and ifname have never been valid parameters for -net tap. Historically, -net has ignored unknown options but recently, it now throws an error when encountering an unsupported option.
Anthony, Thanks for your reply! I made some modifications to libvirt last night, to have it not send in the two parameters you mentioned (script= and ifname=) and indeed, I was able to create the VM without any modifications to kvm. I am still having some other issues with migration, but I believe these to also be related to the way libvirt is accessing kvm and will try to look into these separately. I see that there are some changes with regard to the qemu parameters since the last libvirt release, so I'll see if the development version fixes these issues. - Josh -- Josh Wilsdon LayerBoom Systems joshw@layerboom.com http://layerboom.com

On Fri, May 22, 2009 at 09:12:55PM -0500, Anthony Liguori wrote:
Josh Wilsdon wrote:
We are doing work with libvirt 0.6.3 through which we have started virtual machines. Using the same "create" command with the same storage, the same everything else this configuration works with both kvm-84 and kvm-85. When I built a fresh version of kvm-86 this stopped working with an error:
qemu: invalid parameter '15' in 'fd=15,script=,vlan=0,ifname=vnet0'
It's a libvirt bug. script and ifname have never been valid parameters for -net tap. Historically, -net has ignored unknown options but recently, it now throws an error when encountering an unsupported option.
IIRC, the reason libvirt had been passing the ifname=XXX arg, is because Xenner wanted it know the name associated with the TAP device, and would then open it, rather than taking the FD passed in. Xenner long ago gained code todo the reverse fd -> name lookup though, so we should just kill this bogus code in libvirt now and drop ifname & script= args when passing an FD. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (4)
-
Anthony Liguori
-
Daniel P. Berrange
-
Josh Wilsdon
-
Nikola Ciprich