[libvirt] [PATCH] storage_backend_rbd: Correct argument order to rbd_create3
The stripe_unit and stripe_count arguments are passed to rbd_create3 in the wrong order, resulting in a stripe size of 1 byte with 4194304 stripes on newly created RBD volumes. https://bugzilla.redhat.com/show_bug.cgi?id=1092208 Signed-off-by: Steven McDonald <steven.mcdonald@anchor.net.au> --- src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 029d2f0..5d4ef79 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -492,7 +492,7 @@ static int virStorageBackendRBDCreateImage(rados_ioctx_t io, uint64_t stripe_unit = 4194304; if (rbd_create3(io, name, capacity, features, &order, - stripe_count, stripe_unit) < 0) { + stripe_unit, stripe_count) < 0) { #else if (rbd_create(io, name, capacity, &order) < 0) { #endif -- 2.0.0.rc0
On 04/28/2014 08:19 PM, Steven McDonald wrote:
The stripe_unit and stripe_count arguments are passed to rbd_create3 in the wrong order, resulting in a stripe size of 1 byte with 4194304 stripes on newly created RBD volumes.
https://bugzilla.redhat.com/show_bug.cgi?id=1092208 Signed-off-by: Steven McDonald <steven.mcdonald@anchor.net.au> --- src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 029d2f0..5d4ef79 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -492,7 +492,7 @@ static int virStorageBackendRBDCreateImage(rados_ioctx_t io, uint64_t stripe_unit = 4194304;
if (rbd_create3(io, name, capacity, features, &order, - stripe_count, stripe_unit) < 0) { + stripe_unit, stripe_count) < 0) {
Thanks. ACK and pushed, and congrats on your first libvirt patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Steven McDonald