[libvirt] [libvirt-glib] Add missing symbols to .sym files

These symbols are in public headers, but were not listed in the corresponding .sym file, causing them to be unavailable from the resulting shared library. I would have preferred not to export gvir_config_object_new_from_xml() at all, but since the similar gvir_config_object_new() is already exported, I've chosen to export it as well. --- libvirt-gconfig/libvirt-gconfig.sym | 11 +++++++++++ libvirt-gobject/libvirt-gobject.sym | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index be05ce4..72eafc1 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -599,4 +599,15 @@ LIBVIRT_GCONFIG_0.1.7 { gvir_config_domain_device_get_alias; } LIBVIRT_GCONFIG_0.1.6; +LIBVIRT_GCONFIG_0.1.8 { +global: + gvir_config_domain_get_uuid; + gvir_config_domain_set_uuid; + + gvir_config_domain_graphics_rdp_set_multi_user; + gvir_config_domain_graphics_rdp_set_replace_user; + + gvir_config_object_new_from_xml; +} LIBVIRT_GCONFIG_0.1.7; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index 9522167..edc876d 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -232,4 +232,8 @@ LIBVIRT_GOBJECT_0.1.5 { gvir_connection_open_read_only_finish; } LIBVIRT_GOBJECT_0.1.4; +LIBVIRT_GOBJECT_0.1.8 { + gvir_connection_restore_domain_from_file_finish; +} LIBVIRT_GOBJECT_0.1.5; + # .... define new API here using predicted next version number .... -- 1.8.3.1

On 28.08.2013 14:31, Christophe Fergeau wrote:
These symbols are in public headers, but were not listed in the corresponding .sym file, causing them to be unavailable from the resulting shared library. I would have preferred not to export gvir_config_object_new_from_xml() at all, but since the similar gvir_config_object_new() is already exported, I've chosen to export it as well. --- libvirt-gconfig/libvirt-gconfig.sym | 11 +++++++++++ libvirt-gobject/libvirt-gobject.sym | 4 ++++ 2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index be05ce4..72eafc1 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -599,4 +599,15 @@ LIBVIRT_GCONFIG_0.1.7 { gvir_config_domain_device_get_alias; } LIBVIRT_GCONFIG_0.1.6;
+LIBVIRT_GCONFIG_0.1.8 { +global: + gvir_config_domain_get_uuid; + gvir_config_domain_set_uuid; + + gvir_config_domain_graphics_rdp_set_multi_user; + gvir_config_domain_graphics_rdp_set_replace_user; + + gvir_config_object_new_from_xml; +} LIBVIRT_GCONFIG_0.1.7; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index 9522167..edc876d 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -232,4 +232,8 @@ LIBVIRT_GOBJECT_0.1.5 { gvir_connection_open_read_only_finish; } LIBVIRT_GOBJECT_0.1.4;
+LIBVIRT_GOBJECT_0.1.8 { + gvir_connection_restore_domain_from_file_finish; +} LIBVIRT_GOBJECT_0.1.5; + # .... define new API here using predicted next version number ....
ACK Michal

On Wed, Aug 28, 2013 at 02:31:22PM +0200, Christophe Fergeau wrote:
These symbols are in public headers, but were not listed in the corresponding .sym file, causing them to be unavailable from the resulting shared library. I would have preferred not to export gvir_config_object_new_from_xml() at all, but since the similar gvir_config_object_new() is already exported, I've chosen to export it as well. --- libvirt-gconfig/libvirt-gconfig.sym | 11 +++++++++++ libvirt-gobject/libvirt-gobject.sym | 4 ++++ 2 files changed, 15 insertions(+)
Hmm, we really could do with a perl script that runs as part of 'make syntax-check' to validate that every function in a .h file is in the .sym file (skipping -private.h) Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (3)
-
Christophe Fergeau
-
Daniel P. Berrange
-
Michal Privoznik