[PATCH] CIM: Include <stdlib.h> in libxkutil for malloc functions

This avoids implicit function declarations and build failures with future compilers. Not sure where to submit this. Our Fedora package references <http://libvirt.org/CIM/>, but it's 404, and I can't find a CIM component in the Gitlab organization. Thanks, Florian diff --git a/libxkutil/infostore.c b/libxkutil/infostore.c index d2b2f719dc1d3616..060a83b26e170df7 100644 --- a/libxkutil/infostore.c +++ b/libxkutil/infostore.c @@ -26,6 +26,7 @@ #include <sys/stat.h> #include <sys/file.h> #include <string.h> +#include <stdlib.h> #include <libvirt/libvirt.h> #include <libxml/parser.h> diff --git a/libxkutil/xml_parse_test.c b/libxkutil/xml_parse_test.c index 384593d056d07fb2..9af570efc75f7681 100644 --- a/libxkutil/xml_parse_test.c +++ b/libxkutil/xml_parse_test.c @@ -1,5 +1,6 @@ #include <stdio.h> #include <inttypes.h> +#include <stdlib.h> #include <getopt.h>

On Fri, Dec 15, 2023 at 11:04:51 +0100, Florian Weimer wrote:
This avoids implicit function declarations and build failures with future compilers.
Not sure where to submit this. Our Fedora package references <http://libvirt.org/CIM/>, but it's 404, and I can't find a CIM component in the Gitlab organization.
The libvirt-cim project on gitlab was archived: https://gitlab.com/libvirt/libvirt-cim We can un-archive it if needed so that you can open a merge request.

* Peter Krempa:
On Fri, Dec 15, 2023 at 11:04:51 +0100, Florian Weimer wrote:
This avoids implicit function declarations and build failures with future compilers.
Not sure where to submit this. Our Fedora package references <http://libvirt.org/CIM/>, but it's 404, and I can't find a CIM component in the Gitlab organization.
The libvirt-cim project on gitlab was archived:
https://gitlab.com/libvirt/libvirt-cim
We can un-archive it if needed so that you can open a merge request.
If the component is unmaintained upstream, maybe the Fedora package should be retired? I don't really care about the package, I just fixed the build failure … Thanks, Florian

On 12/15/23 11:16, Florian Weimer wrote:
* Peter Krempa:
On Fri, Dec 15, 2023 at 11:04:51 +0100, Florian Weimer wrote:
This avoids implicit function declarations and build failures with future compilers.
Not sure where to submit this. Our Fedora package references <http://libvirt.org/CIM/>, but it's 404, and I can't find a CIM component in the Gitlab organization.
The libvirt-cim project on gitlab was archived:
https://gitlab.com/libvirt/libvirt-cim
We can un-archive it if needed so that you can open a merge request.
If the component is unmaintained upstream, maybe the Fedora package should be retired? I don't really care about the package, I just fixed the build failure …
Yep, it's time to retire it in Fedora. Michal
participants (3)
-
Florian Weimer
-
Michal Prívozník
-
Peter Krempa