[libvirt] [PATCH v2 00/16] Fix styles of curly braces around function bodies
Basically a v2 of: https://www.redhat.com/archives/libvir-list/2014-March/msg00987.html with way more tuned regexp, wrapped lines, syntax-check and so on. Martin Kletzander (16): Use K&R style for curly braces in tests/ Use K&R style for curly braces in src/xen*/ Use K&R style for curly braces in src/util/ Use K&R style for curly braces in src/rpc/ Use K&R style for curly braces in src/conf/ Use K&R style for curly braces in src/qemu/ Use K&R style for curly braces in src/storage/ Use K&R style for curly braces in src/openvz/ Use K&R style for curly braces in src/nwfilter/ Use K&R style for curly braces in src/test/test_driver.c Use K&R style for curly braces in src/uml/ Use K&R style for curly braces in src/lxc/lxc_driver.c Use K&R style for curly braces in src/network/bridge_driver.c Use K&R style for curly braces in src/vbox/ Use K&R style for curly braces in remaining files Require K&R styled curly braces around function bodies cfg.mk | 7 ++ daemon/libvirtd-config.c | 9 +- docs/internals/command.html.in | 3 +- examples/dominfo/info1.c | 7 +- src/conf/domain_conf.c | 9 +- src/conf/domain_nwfilter.c | 13 ++- src/conf/interface_conf.c | 54 ++++++--- src/conf/nwfilter_conf.c | 30 +++-- src/conf/nwfilter_params.c | 3 +- src/interface/interface_backend_netcf.c | 8 +- src/interface/interface_backend_udev.c | 4 +- src/interface/interface_driver.c | 4 +- src/libxl/libxl_driver.c | 3 +- src/lxc/lxc_driver.c | 30 +++-- src/network/bridge_driver.c | 54 ++++++--- src/node_device/node_device_driver.c | 5 +- src/nwfilter/nwfilter_driver.c | 32 +++-- src/nwfilter/nwfilter_ebiptables_driver.c | 3 +- src/nwfilter/nwfilter_learnipaddr.c | 41 ++++--- src/openvz/openvz_conf.c | 15 ++- src/openvz/openvz_driver.c | 45 ++++--- src/qemu/qemu_agent.c | 5 +- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_driver.c | 94 ++++++++++----- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_monitor_json.c | 3 +- src/qemu/qemu_monitor_text.c | 20 +++- src/rpc/virnetserver.c | 8 +- src/rpc/virnetserverclient.c | 5 +- src/rpc/virnettlscontext.c | 5 +- src/secret/secret_driver.c | 8 +- src/security/security_stack.c | 8 +- src/storage/storage_backend_fs.c | 12 +- src/storage/storage_driver.c | 78 ++++++++----- src/test/test_driver.c | 135 ++++++++++++++------- src/uml/uml_conf.c | 5 +- src/uml/uml_driver.c | 78 ++++++++----- src/util/vircgroup.c | 9 +- src/util/virconf.c | 5 +- src/util/virdbus.c | 8 +- src/util/virerror.c | 3 +- src/util/vireventpoll.c | 29 +++-- src/util/virhook.c | 11 +- src/util/virnetdevvportprofile.c | 5 +- src/util/virrandom.c | 5 +- src/util/virsocketaddr.c | 26 +++-- src/util/virsysinfo.c | 15 ++- src/util/virthread.c | 5 +- src/util/virutil.c | 20 ++-- src/util/virutil.h | 12 +- src/util/viruuid.c | 5 +- src/vbox/vbox_driver.c | 5 +- src/vbox/vbox_tmpl.c | 188 ++++++++++++++++++++---------- src/xen/xen_driver.c | 6 +- src/xen/xen_hypervisor.c | 5 +- src/xen/xm_internal.c | 10 +- src/xenapi/xenapi_utils.c | 5 +- src/xenxs/xen_xm.c | 35 ++++-- tests/commandhelper.c | 5 +- tests/qemuargv2xmltest.c | 3 +- tests/shunloadhelper.c | 5 +- tests/testutils.c | 15 ++- tests/testutilslxc.c | 3 +- tests/testutilsqemu.c | 3 +- tests/testutilsxen.c | 3 +- tests/virshtest.c | 54 ++++++--- tests/virusbtest.c | 3 +- tests/xencapstest.c | 33 ++++-- 69 files changed, 929 insertions(+), 465 deletions(-) -- 1.9.0
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- tests/commandhelper.c | 5 +++-- tests/qemuargv2xmltest.c | 3 ++- tests/shunloadhelper.c | 5 +++-- tests/testutils.c | 15 +++++++++----- tests/testutilslxc.c | 3 ++- tests/testutilsqemu.c | 3 ++- tests/testutilsxen.c | 3 ++- tests/virshtest.c | 54 ++++++++++++++++++++++++++++++++---------------- tests/virusbtest.c | 3 ++- tests/xencapstest.c | 33 +++++++++++++++++++---------- 10 files changed, 84 insertions(+), 43 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 296fbbb..32b8512 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -1,7 +1,7 @@ /* * commandhelper.c: Auxiliary program for commandtest * - * Copyright (C) 2010-2013 Red Hat, Inc. + * Copyright (C) 2010-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -37,7 +37,8 @@ # define VIR_FROM_THIS VIR_FROM_NONE -static int envsort(const void *a, const void *b) { +static int envsort(const void *a, const void *b) +{ const char *const*astrptr = a; const char *const*bstrptr = b; const char *astr = *astrptr; diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index 4923c2b..9eb3c49 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -36,7 +36,8 @@ static int blankProblemElements(char *data) static int testCompareXMLToArgvFiles(const char *xml, const char *cmdfile, - bool expect_warning) { + bool expect_warning) +{ char *expectxml = NULL; char *actualxml = NULL; char *cmd = NULL; diff --git a/tests/shunloadhelper.c b/tests/shunloadhelper.c index f2afbe8..128adce 100644 --- a/tests/shunloadhelper.c +++ b/tests/shunloadhelper.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2011 Red Hat, Inc. + * Copyright (C) 2011, 2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -38,7 +38,8 @@ static void shunloadError(void *userData ATTRIBUTE_UNUSED, int shunloadStart(void); -int shunloadStart(void) { +int shunloadStart(void) +{ virConnectPtr conn; virSetErrorFunc(NULL, shunloadError); diff --git a/tests/testutils.c b/tests/testutils.c index e21e2f4..179c72a 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -362,7 +362,8 @@ virtTestLoadFile(const char *file, char **buf) #ifndef WIN32 static void virtTestCaptureProgramExecChild(const char *const argv[], - int pipefd) { + int pipefd) +{ size_t i; int open_max; int stdinfd = -1; @@ -629,7 +630,8 @@ virtTestLogContentAndReset(void) static unsigned int -virTestGetFlag(const char *name) { +virTestGetFlag(const char *name) +{ char *flagStr; unsigned int flag; @@ -643,21 +645,24 @@ virTestGetFlag(const char *name) { } unsigned int -virTestGetDebug(void) { +virTestGetDebug(void) +{ if (testDebug == -1) testDebug = virTestGetFlag("VIR_TEST_DEBUG"); return testDebug; } unsigned int -virTestGetVerbose(void) { +virTestGetVerbose(void) +{ if (testVerbose == -1) testVerbose = virTestGetFlag("VIR_TEST_VERBOSE"); return testVerbose || virTestGetDebug(); } unsigned int -virTestGetExpensive(void) { +virTestGetExpensive(void) +{ if (testExpensive == -1) testExpensive = virTestGetFlag("VIR_TEST_EXPENSIVE"); return testExpensive; diff --git a/tests/testutilslxc.c b/tests/testutilslxc.c index 1bc6feb..a1574d3 100644 --- a/tests/testutilslxc.c +++ b/tests/testutilslxc.c @@ -8,7 +8,8 @@ # include "domain_conf.h" -virCapsPtr testLXCCapsInit(void) { +virCapsPtr testLXCCapsInit(void) +{ virCapsPtr caps; virCapsGuestPtr guest; diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 726501c..f7810f6 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -203,7 +203,8 @@ error: return -1; } -virCapsPtr testQemuCapsInit(void) { +virCapsPtr testQemuCapsInit(void) +{ virCapsPtr caps; virCapsGuestPtr guest; virCapsGuestMachinePtr *machines = NULL; diff --git a/tests/testutilsxen.c b/tests/testutilsxen.c index 1b5ee79..f3216e9 100644 --- a/tests/testutilsxen.c +++ b/tests/testutilsxen.c @@ -7,7 +7,8 @@ #include "domain_conf.h" -virCapsPtr testXenCapsInit(void) { +virCapsPtr testXenCapsInit(void) +{ struct utsname utsname; virCapsPtr caps; virCapsGuestPtr guest; diff --git a/tests/virshtest.c b/tests/virshtest.c index 3da5fa4..f7edc02 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -42,7 +42,8 @@ static const char *domname_fc4 = "fc4\n\n"; static const char *domstate_fc4 = "running\n\n"; static int testFilterLine(char *buffer, - const char *toRemove) { + const char *toRemove) +{ char *start; char *end; @@ -93,7 +94,8 @@ static char *custom_uri; "--connect", \ custom_uri -static int testCompareListDefault(const void *data ATTRIBUTE_UNUSED) { +static int testCompareListDefault(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_DEFAULT, "list", NULL }; const char *exp = "\ Id Name State\n\ @@ -103,7 +105,8 @@ static int testCompareListDefault(const void *data ATTRIBUTE_UNUSED) { return testCompareOutputLit(exp, NULL, argv); } -static int testCompareListCustom(const void *data ATTRIBUTE_UNUSED) { +static int testCompareListCustom(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "list", NULL }; const char *exp = "\ Id Name State\n\ @@ -114,7 +117,8 @@ static int testCompareListCustom(const void *data ATTRIBUTE_UNUSED) { return testCompareOutputLit(exp, NULL, argv); } -static int testCompareNodeinfoDefault(const void *data ATTRIBUTE_UNUSED) { +static int testCompareNodeinfoDefault(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_DEFAULT, "nodeinfo", NULL }; const char *exp = "\ CPU model: i686\n\ @@ -129,7 +133,8 @@ Memory size: 3145728 KiB\n\ return testCompareOutputLit(exp, NULL, argv); } -static int testCompareNodeinfoCustom(const void *data ATTRIBUTE_UNUSED) { +static int testCompareNodeinfoCustom(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "nodeinfo", @@ -148,73 +153,85 @@ Memory size: 8192000 KiB\n\ return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDominfoByID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDominfoByID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "dominfo", "2", NULL }; const char *exp = dominfo_fc4; return testCompareOutputLit(exp, "\nCPU time:", argv); } -static int testCompareDominfoByUUID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDominfoByUUID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "dominfo", DOM_UUID, NULL }; const char *exp = dominfo_fc4; return testCompareOutputLit(exp, "\nCPU time:", argv); } -static int testCompareDominfoByName(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDominfoByName(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "dominfo", "fc4", NULL }; const char *exp = dominfo_fc4; return testCompareOutputLit(exp, "\nCPU time:", argv); } -static int testCompareDomuuidByID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomuuidByID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domuuid", "2", NULL }; const char *exp = domuuid_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomuuidByName(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomuuidByName(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domuuid", "fc4", NULL }; const char *exp = domuuid_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomidByName(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomidByName(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domid", "fc4", NULL }; const char *exp = domid_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomidByUUID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomidByUUID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domid", DOM_UUID, NULL }; const char *exp = domid_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomnameByID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomnameByID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domname", "2", NULL }; const char *exp = domname_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomnameByUUID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomnameByUUID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domname", DOM_UUID, NULL }; const char *exp = domname_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomstateByID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomstateByID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domstate", "2", NULL }; const char *exp = domstate_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomstateByUUID(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomstateByUUID(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domstate", DOM_UUID, NULL }; const char *exp = domstate_fc4; return testCompareOutputLit(exp, NULL, argv); } -static int testCompareDomstateByName(const void *data ATTRIBUTE_UNUSED) { +static int testCompareDomstateByName(const void *data ATTRIBUTE_UNUSED) +{ const char *const argv[] = { VIRSH_CUSTOM, "domstate", "fc4", NULL }; const char *exp = domstate_fc4; return testCompareOutputLit(exp, NULL, argv); @@ -225,7 +242,8 @@ struct testInfo { const char *result; }; -static int testCompareEcho(const void *data) { +static int testCompareEcho(const void *data) +{ const struct testInfo *info = data; return testCompareOutputLit(info->result, NULL, info->argv); } diff --git a/tests/virusbtest.c b/tests/virusbtest.c index bb849b5..b66c7d0 100644 --- a/tests/virusbtest.c +++ b/tests/virusbtest.c @@ -137,7 +137,8 @@ cleanup: static int testCheckNdevs(const char* occasion, size_t got, - size_t expected) { + size_t expected) +{ if (got != expected) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s: got %zu devices, expected %zu", diff --git a/tests/xencapstest.c b/tests/xencapstest.c index 74423a1..176850b 100644 --- a/tests/xencapstest.c +++ b/tests/xencapstest.c @@ -69,21 +69,24 @@ testCompareFiles(virArch hostmachine, const char *xml_rel, return ret; } -static int testXeni686(const void *data ATTRIBUTE_UNUSED) { +static int testXeni686(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_I686, "xencapsdata/xen-i686.xml", "xencapsdata/xen-i686.cpuinfo", "xencapsdata/xen-i686.caps"); } -static int testXeni686PAE(const void *data ATTRIBUTE_UNUSED) { +static int testXeni686PAE(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_I686, "xencapsdata/xen-i686-pae.xml", "xencapsdata/xen-i686-pae.cpuinfo", "xencapsdata/xen-i686-pae.caps"); } -static int testXeni686PAEHVM(const void *data ATTRIBUTE_UNUSED) { +static int testXeni686PAEHVM(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_I686, "xencapsdata/xen-i686-pae-hvm.xml", "xencapsdata/xen-i686-pae-hvm.cpuinfo", @@ -93,7 +96,8 @@ static int testXeni686PAEHVM(const void *data ATTRIBUTE_UNUSED) { /* No PAE + HVM is non-sensical - all VMX capable CPUs have PAE */ /* -static int testXeni686HVM(const void *data ATTRIBUTE_UNUSED) { +static int testXeni686HVM(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_I686, "xencapsdata/xen-i686-hvm.xml", "xencapsdata/xen-i686.cpuinfo", @@ -101,46 +105,53 @@ static int testXeni686HVM(const void *data ATTRIBUTE_UNUSED) { } */ -static int testXenx86_64(const void *data ATTRIBUTE_UNUSED) { +static int testXenx86_64(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_X86_64, "xencapsdata/xen-x86_64.xml", "xencapsdata/xen-x86_64.cpuinfo", "xencapsdata/xen-x86_64.caps"); } -static int testXenx86_64HVM(const void *data ATTRIBUTE_UNUSED) { +static int testXenx86_64HVM(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_X86_64, "xencapsdata/xen-x86_64-hvm.xml", "xencapsdata/xen-x86_64-hvm.cpuinfo", "xencapsdata/xen-x86_64-hvm.caps"); } -static int testXenia64(const void *data ATTRIBUTE_UNUSED) { +static int testXenia64(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_ITANIUM, "xencapsdata/xen-ia64.xml", "xencapsdata/xen-ia64.cpuinfo", "xencapsdata/xen-ia64.caps"); } -static int testXenia64BE(const void *data ATTRIBUTE_UNUSED) { +static int testXenia64BE(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_ITANIUM, "xencapsdata/xen-ia64-be.xml", "xencapsdata/xen-ia64-be.cpuinfo", "xencapsdata/xen-ia64-be.caps"); } -static int testXenia64HVM(const void *data ATTRIBUTE_UNUSED) { +static int testXenia64HVM(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_ITANIUM, "xencapsdata/xen-ia64-hvm.xml", "xencapsdata/xen-ia64-hvm.cpuinfo", "xencapsdata/xen-ia64-hvm.caps"); } -static int testXenia64BEHVM(const void *data ATTRIBUTE_UNUSED) { +static int testXenia64BEHVM(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_ITANIUM, "xencapsdata/xen-ia64-be-hvm.xml", "xencapsdata/xen-ia64-be-hvm.cpuinfo", "xencapsdata/xen-ia64-be-hvm.caps"); } -static int testXenppc64(const void *data ATTRIBUTE_UNUSED) { +static int testXenppc64(const void *data ATTRIBUTE_UNUSED) +{ return testCompareFiles(VIR_ARCH_PPC64, "xencapsdata/xen-ppc64.xml", "xencapsdata/xen-ppc64.cpuinfo", -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:41PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- tests/commandhelper.c | 5 +++-- tests/qemuargv2xmltest.c | 3 ++- tests/shunloadhelper.c | 5 +++-- tests/testutils.c | 15 +++++++++----- tests/testutilslxc.c | 3 ++- tests/testutilsqemu.c | 3 ++- tests/testutilsxen.c | 3 ++- tests/virshtest.c | 54 ++++++++++++++++++++++++++++++++---------------- tests/virusbtest.c | 3 ++- tests/xencapstest.c | 33 +++++++++++++++++++---------- 10 files changed, 84 insertions(+), 43 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/xen/xen_driver.c | 6 ++++-- src/xen/xen_hypervisor.c | 5 +++-- src/xen/xm_internal.c | 10 +++++++--- src/xenapi/xenapi_utils.c | 5 +++-- src/xenxs/xen_xm.c | 35 +++++++++++++++++++++++------------ 5 files changed, 40 insertions(+), 21 deletions(-) diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 8ceb8b6..2199cb0 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -164,7 +164,8 @@ static virDomainDefPtr xenGetDomainDefForDom(virDomainPtr dom) * until reboot which might be false in future Xen implementations. */ static void -xenNumaInit(virConnectPtr conn) { +xenNumaInit(virConnectPtr conn) +{ virNodeInfo nodeInfo; xenUnifiedPrivatePtr priv; int ret; @@ -1916,7 +1917,8 @@ cleanup: } static int -xenUnifiedDomainUndefine(virDomainPtr dom) { +xenUnifiedDomainUndefine(virDomainPtr dom) +{ return xenUnifiedDomainUndefineFlags(dom, 0); } diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c index 5ccd5fa..e8eaeeb 100644 --- a/src/xen/xen_hypervisor.c +++ b/src/xen/xen_hypervisor.c @@ -1,7 +1,7 @@ /* * xen_hypervisor.c: direct access to Xen hypervisor level * - * Copyright (C) 2005-2013 Red Hat, Inc. + * Copyright (C) 2005-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -2006,7 +2006,8 @@ xenHypervisorInit(struct xenHypervisorVersions *override_versions) } -static int xenHypervisorOnceInit(void) { +static int xenHypervisorOnceInit(void) +{ return xenHypervisorInit(NULL); } diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index fbdd89e..846b79c 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -1,7 +1,7 @@ /* * xm_internal.c: helper routines for dealing with inactive domains * - * Copyright (C) 2006-2007, 2009-2013 Red Hat, Inc. + * Copyright (C) 2006-2007, 2009-2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -94,7 +94,8 @@ static int xenInotifyActive(virConnectPtr conn) /* Release memory associated with a cached config object */ -static void xenXMConfigFree(void *payload, const void *key ATTRIBUTE_UNUSED) { +static void xenXMConfigFree(void *payload, const void *key ATTRIBUTE_UNUSED) +{ xenXMConfCachePtr entry = (xenXMConfCachePtr)payload; virDomainDefFree(entry->def); VIR_FREE(entry->filename); @@ -1117,7 +1118,10 @@ struct xenXMListIteratorContext { }; static void -xenXMListIterator(void *payload ATTRIBUTE_UNUSED, const void *name, void *data) { +xenXMListIterator(void *payload ATTRIBUTE_UNUSED, + const void *name, + void *data) +{ struct xenXMListIteratorContext *ctx = data; virDomainDefPtr def = NULL; diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c index 610e0f0..5a5025a 100644 --- a/src/xenapi/xenapi_utils.c +++ b/src/xenapi/xenapi_utils.c @@ -1,6 +1,6 @@ /* * xenapi_utils.c: Xen API driver -- utils parts. - * Copyright (C) 2011-2013 Red Hat, Inc. + * Copyright (C) 2011-2014 Red Hat, Inc. * Copyright (C) 2009, 2010 Citrix Ltd. * * This library is free software; you can redistribute it and/or @@ -181,7 +181,8 @@ createXenAPIBootOrderString(int nboot, int *bootDevs) /* convert boot order string to libvirt boot order enum */ enum virDomainBootOrder -map2LibvirtBootOrder(char c) { +map2LibvirtBootOrder(char c) +{ switch (c) { case 'a': return VIR_DOMAIN_BOOT_FLOPPY; diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c index a70c5e3..fce074a 100644 --- a/src/xenxs/xen_xm.c +++ b/src/xenxs/xen_xm.c @@ -1,7 +1,7 @@ /* * xen_xm.c: Xen XM parsing functions * - * Copyright (C) 2006-2007, 2009-2010, 2012-2013 Red Hat, Inc. + * Copyright (C) 2006-2007, 2009-2010, 2012-2014 Red Hat, Inc. * Copyright (C) 2011 Univention GmbH * Copyright (C) 2006 Daniel P. Berrange * @@ -44,7 +44,8 @@ static int xenXMConfigGetBool(virConfPtr conf, const char *name, int *value, - int def) { + int def) +{ virConfValuePtr val; *value = 0; @@ -70,7 +71,8 @@ static int xenXMConfigGetBool(virConfPtr conf, static int xenXMConfigGetULong(virConfPtr conf, const char *name, unsigned long *value, - unsigned long def) { + unsigned long def) +{ virConfValuePtr val; *value = 0; @@ -102,7 +104,8 @@ static int xenXMConfigGetULong(virConfPtr conf, static int xenXMConfigGetULongLong(virConfPtr conf, const char *name, unsigned long long *value, - unsigned long long def) { + unsigned long long def) +{ virConfValuePtr val; *value = 0; @@ -134,7 +137,8 @@ static int xenXMConfigGetULongLong(virConfPtr conf, static int xenXMConfigGetString(virConfPtr conf, const char *name, const char **value, - const char *def) { + const char *def) +{ virConfValuePtr val; *value = NULL; @@ -158,7 +162,8 @@ static int xenXMConfigGetString(virConfPtr conf, static int xenXMConfigCopyStringInternal(virConfPtr conf, const char *name, char **value, - int allowMissing) { + int allowMissing) +{ virConfValuePtr val; *value = NULL; @@ -201,7 +206,9 @@ static int xenXMConfigCopyStringOpt(virConfPtr conf, /* Convenience method to grab a string UUID from the config file object */ -static int xenXMConfigGetUUID(virConfPtr conf, const char *name, unsigned char *uuid) { +static int +xenXMConfigGetUUID(virConfPtr conf, const char *name, unsigned char *uuid) +{ virConfValuePtr val; if (!uuid || !name || !conf) { @@ -248,7 +255,8 @@ static int xenXMConfigGetUUID(virConfPtr conf, const char *name, unsigned char * */ virDomainDefPtr xenParseXM(virConfPtr conf, int xendConfigVersion, - virCapsPtr caps) { + virCapsPtr caps) +{ const char *str; int hvm = 0; int val; @@ -1139,7 +1147,8 @@ cleanup: static -int xenXMConfigSetInt(virConfPtr conf, const char *setting, long long l) { +int xenXMConfigSetInt(virConfPtr conf, const char *setting, long long l) +{ virConfValuePtr value = NULL; if ((long) l != l) { @@ -1158,8 +1167,9 @@ int xenXMConfigSetInt(virConfPtr conf, const char *setting, long long l) { } -static -int xenXMConfigSetString(virConfPtr conf, const char *setting, const char *str) { +static int +xenXMConfigSetString(virConfPtr conf, const char *setting, const char *str) +{ virConfValuePtr value = NULL; if (VIR_ALLOC(value) < 0) @@ -1478,7 +1488,8 @@ verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT); virConfPtr xenFormatXM(virConnectPtr conn, virDomainDefPtr def, - int xendConfigVersion) { + int xendConfigVersion) +{ virConfPtr conf = NULL; int hvm = 0, vmlocaltime = 0; size_t i; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:42PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/xen/xen_driver.c | 6 ++++-- src/xen/xen_hypervisor.c | 5 +++-- src/xen/xm_internal.c | 10 +++++++--- src/xenapi/xenapi_utils.c | 5 +++-- src/xenxs/xen_xm.c | 35 +++++++++++++++++++++++------------ 5 files changed, 40 insertions(+), 21 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/util/vircgroup.c | 9 ++++++--- src/util/virconf.c | 5 +++-- src/util/virdbus.c | 8 +++++--- src/util/virerror.c | 3 ++- src/util/vireventpoll.c | 29 +++++++++++++++++++---------- src/util/virhook.c | 11 +++++++---- src/util/virnetdevvportprofile.c | 5 +++-- src/util/virrandom.c | 5 +++-- src/util/virsocketaddr.c | 26 +++++++++++++++++--------- src/util/virsysinfo.c | 15 ++++++++++----- src/util/virthread.c | 5 +++-- src/util/virutil.c | 20 +++++++++++++------- src/util/virutil.h | 12 ++++++++---- src/util/viruuid.c | 5 +++-- 14 files changed, 102 insertions(+), 56 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index c5925b1..84847b2 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -419,7 +419,8 @@ virCgroupCopyPlacement(virCgroupPtr group, /* * parent == "/" + path="" => "/" * parent == "/libvirt.service" + path == "" => "/libvirt.service" - * parent == "/libvirt.service" + path == "foo" => "/libvirt.service/foo" + * parent == "/libvirt.service" + + * path == "foo" => "/libvirt.service/foo" */ if (virAsprintf(&group->controllers[i].placement, "%s%s%s", @@ -519,8 +520,10 @@ virCgroupDetectPlacement(virCgroupPtr group, /* * selfpath == "/" + path="" -> "/" - * selfpath == "/libvirt.service" + path == "" -> "/libvirt.service" - * selfpath == "/libvirt.service" + path == "foo" -> "/libvirt.service/foo" + * selfpath == "/libvirt.service" + + * path == "" -> "/libvirt.service" + * selfpath == "/libvirt.service" + + * path == "foo" -> "/libvirt.service/foo" */ if (typelen == len && STREQLEN(typestr, tmp, len) && group->controllers[i].mountPoint != NULL && diff --git a/src/util/virconf.c b/src/util/virconf.c index b965df7..233ad40 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -1,7 +1,7 @@ /* * virconf.c: parser for a subset of the Python encoded Xen configuration files * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -708,7 +708,8 @@ virConfParseStatement(virConfParserCtxtPtr ctxt) */ static virConfPtr virConfParse(const char *filename, const char *content, int len, - unsigned int flags) { + unsigned int flags) +{ virConfParserCtxt ctxt; ctxt.filename = filename; diff --git a/src/util/virdbus.c b/src/util/virdbus.c index e3236d8..9e29ca9 100644 --- a/src/util/virdbus.c +++ b/src/util/virdbus.c @@ -1,7 +1,7 @@ /* * virdbus.c: helper for using DBus * - * Copyright (C) 2012-2013 Red Hat, Inc. + * Copyright (C) 2012-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -217,7 +217,8 @@ static int virDBusTranslateWatchFlags(int dbus_flags) } -static void virDBusWatchFree(void *data) { +static void virDBusWatchFree(void *data) +{ struct virDBusWatch *info = data; VIR_FREE(info); } @@ -296,7 +297,8 @@ static const char virDBusBasicTypes[] = { DBUS_TYPE_SIGNATURE, }; -static bool virDBusIsBasicType(char c) { +static bool virDBusIsBasicType(char c) +{ return !!memchr(virDBusBasicTypes, c, ARRAY_CARDINALITY(virDBusBasicTypes)); } diff --git a/src/util/virerror.c b/src/util/virerror.c index 1d7fa77..9db2452 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -43,7 +43,8 @@ virErrorFunc virErrorHandler = NULL; /* global error handler */ void *virUserData = NULL; /* associated data */ virErrorLogPriorityFunc virErrorLogPriorityFilter = NULL; -static virLogPriority virErrorLevelPriority(virErrorLevel level) { +static virLogPriority virErrorLevelPriority(virErrorLevel level) +{ switch (level) { case VIR_ERR_NONE: return VIR_LOG_INFO; diff --git a/src/util/vireventpoll.c b/src/util/vireventpoll.c index ea890de..d8a36e9 100644 --- a/src/util/vireventpoll.c +++ b/src/util/vireventpoll.c @@ -1,7 +1,7 @@ /* * vireventpoll.c: Poll based event loop for monitoring file handles * - * Copyright (C) 2007, 2010-2013 Red Hat, Inc. + * Copyright (C) 2007, 2010-2014 Red Hat, Inc. * Copyright (C) 2007 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -106,7 +106,8 @@ static int nextTimer = 1; int virEventPollAddHandle(int fd, int events, virEventHandleCallback cb, void *opaque, - virFreeCallback ff) { + virFreeCallback ff) +{ int watch; virMutexLock(&eventLoop.lock); if (eventLoop.handlesCount == eventLoop.handlesAlloc) { @@ -142,7 +143,8 @@ int virEventPollAddHandle(int fd, int events, return watch; } -void virEventPollUpdateHandle(int watch, int events) { +void virEventPollUpdateHandle(int watch, int events) +{ size_t i; bool found = false; PROBE(EVENT_POLL_UPDATE_HANDLE, @@ -176,7 +178,8 @@ void virEventPollUpdateHandle(int watch, int events) { * For this reason we only ever set a flag in the existing list. * Actual deletion will be done out-of-band */ -int virEventPollRemoveHandle(int watch) { +int virEventPollRemoveHandle(int watch) +{ size_t i; PROBE(EVENT_POLL_REMOVE_HANDLE, "watch=%d", @@ -296,7 +299,8 @@ void virEventPollUpdateTimeout(int timer, int frequency) * For this reason we only ever set a flag in the existing list. * Actual deletion will be done out-of-band */ -int virEventPollRemoveTimeout(int timer) { +int virEventPollRemoveTimeout(int timer) +{ size_t i; PROBE(EVENT_POLL_REMOVE_TIMEOUT, "timer=%d", @@ -329,7 +333,8 @@ int virEventPollRemoveTimeout(int timer) { * no timeout is pending * returns: 0 on success, -1 on error */ -static int virEventPollCalculateTimeout(int *timeout) { +static int virEventPollCalculateTimeout(int *timeout) +{ unsigned long long then = 0; size_t i; EVENT_DEBUG("Calculate expiry of %zu timers", eventLoop.timeoutsCount); @@ -469,7 +474,8 @@ static int virEventPollDispatchTimeouts(void) * * Returns 0 upon success, -1 if an error occurred */ -static int virEventPollDispatchHandles(int nfds, struct pollfd *fds) { +static int virEventPollDispatchHandles(int nfds, struct pollfd *fds) +{ size_t i, n; VIR_DEBUG("Dispatch %d", nfds); @@ -514,7 +520,8 @@ static int virEventPollDispatchHandles(int nfds, struct pollfd *fds) { * were previously marked as deleted. This asynchronous * cleanup is needed to make dispatch re-entrant safe. */ -static void virEventPollCleanupTimeouts(void) { +static void virEventPollCleanupTimeouts(void) +{ size_t i; size_t gap; VIR_DEBUG("Cleanup %zu", eventLoop.timeoutsCount); @@ -562,7 +569,8 @@ static void virEventPollCleanupTimeouts(void) { * were previously marked as deleted. This asynchronous * cleanup is needed to make dispatch re-entrant safe. */ -static void virEventPollCleanupHandles(void) { +static void virEventPollCleanupHandles(void) +{ size_t i; size_t gap; VIR_DEBUG("Cleanup %zu", eventLoop.handlesCount); @@ -610,7 +618,8 @@ static void virEventPollCleanupHandles(void) { * Run a single iteration of the event loop, blocking until * at least one file handle has an event, or a timer expires */ -int virEventPollRunOnce(void) { +int virEventPollRunOnce(void) +{ struct pollfd *fds = NULL; int ret, timeout, nfds; diff --git a/src/util/virhook.c b/src/util/virhook.c index e3ac4d2..ac7b40f 100644 --- a/src/util/virhook.c +++ b/src/util/virhook.c @@ -1,7 +1,7 @@ /* * virhook.c: implementation of the synchronous hooks support * - * Copyright (C) 2010-2013 Red Hat, Inc. + * Copyright (C) 2010-2014 Red Hat, Inc. * Copyright (C) 2010 Daniel Veillard * * This library is free software; you can redistribute it and/or @@ -107,7 +107,8 @@ static int virHooksFound = -1; * Returns 1 if found, 0 if not found, and -1 in case of error */ static int -virHookCheck(int no, const char *driver) { +virHookCheck(int no, const char *driver) +{ char *path; int ret; @@ -149,7 +150,8 @@ virHookCheck(int no, const char *driver) { * Returns the number of hooks found or -1 in case of failure */ int -virHookInitialize(void) { +virHookInitialize(void) +{ size_t i; int res, ret = 0; @@ -177,7 +179,8 @@ virHookInitialize(void) { * Returns 1 if present, 0 otherwise */ int -virHookPresent(int driver) { +virHookPresent(int driver) +{ if ((driver < VIR_HOOK_DRIVER_DAEMON) || (driver >= VIR_HOOK_DRIVER_LAST)) return 0; diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index 9a294d9..d77c31f 100644 --- a/src/util/virnetdevvportprofile.c +++ b/src/util/virnetdevvportprofile.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2009-2013 Red Hat, Inc. + * Copyright (C) 2009-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -449,7 +449,8 @@ static struct nla_policy ifla_port_policy[IFLA_PORT_MAX + 1] = }; static uint32_t -virNetDevVPortProfileGetLldpadPid(void) { +virNetDevVPortProfileGetLldpadPid(void) +{ int fd; uint32_t pid = 0; diff --git a/src/util/virrandom.c b/src/util/virrandom.c index 49181ad..3f17f5e 100644 --- a/src/util/virrandom.c +++ b/src/util/virrandom.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2012-2013 Red Hat, Inc. + * Copyright (C) 2012-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -165,7 +165,8 @@ uint32_t virRandomInt(uint32_t max) int virRandomGenerateWWN(char **wwn, - const char *virt_type) { + const char *virt_type) +{ const char *oui = NULL; if (!virt_type) { diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 3f270e2..8ffdf14 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2009-2013 Red Hat, Inc. + * Copyright (C) 2009-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -116,7 +116,8 @@ virSocketAddrParseInternal(struct addrinfo **res, * * Returns the length of the network address or -1 in case of error. */ -int virSocketAddrParse(virSocketAddrPtr addr, const char *val, int family) { +int virSocketAddrParse(virSocketAddrPtr addr, const char *val, int family) +{ int len; struct addrinfo *res; @@ -150,7 +151,8 @@ int virSocketAddrParse(virSocketAddrPtr addr, const char *val, int family) { * Returns the length of the network address or -1 in case of error. */ int -virSocketAddrParseIPv4(virSocketAddrPtr addr, const char *val) { +virSocketAddrParseIPv4(virSocketAddrPtr addr, const char *val) +{ return virSocketAddrParse(addr, val, AF_INET); } @@ -164,7 +166,8 @@ virSocketAddrParseIPv4(virSocketAddrPtr addr, const char *val) { * Returns the length of the network address or -1 in case of error. */ int -virSocketAddrParseIPv6(virSocketAddrPtr addr, const char *val) { +virSocketAddrParseIPv6(virSocketAddrPtr addr, const char *val) +{ return virSocketAddrParse(addr, val, AF_INET6); } @@ -355,7 +358,8 @@ error: * Returns 0 on success, -1 on failure */ int -virSocketAddrSetPort(virSocketAddrPtr addr, int port) { +virSocketAddrSetPort(virSocketAddrPtr addr, int port) +{ if (addr == NULL) return -1; @@ -380,7 +384,8 @@ virSocketAddrSetPort(virSocketAddrPtr addr, int port) { * Returns -1 if @addr is invalid */ int -virSocketAddrGetPort(virSocketAddrPtr addr) { +virSocketAddrGetPort(virSocketAddrPtr addr) +{ if (addr == NULL) return -1; @@ -401,7 +406,8 @@ virSocketAddrGetPort(virSocketAddrPtr addr) { * * Returns 0 in case of success and -1 in case of error */ -int virSocketAddrIsNetmask(virSocketAddrPtr netmask) { +int virSocketAddrIsNetmask(virSocketAddrPtr netmask) +{ int n = virSocketAddrGetNumNetmaskBits(netmask); if (n < 0) return -1; @@ -549,7 +555,8 @@ virSocketAddrBroadcastByPrefix(const virSocketAddr *addr, * -1 in case of error */ int virSocketAddrCheckNetmask(virSocketAddrPtr addr1, virSocketAddrPtr addr2, - virSocketAddrPtr netmask) { + virSocketAddrPtr netmask) +{ size_t i; if ((addr1 == NULL) || (addr2 == NULL) || (netmask == NULL)) @@ -605,7 +612,8 @@ int virSocketAddrCheckNetmask(virSocketAddrPtr addr1, virSocketAddrPtr addr2, * * Returns the size of the range or -1 in case of failure */ -int virSocketAddrGetRange(virSocketAddrPtr start, virSocketAddrPtr end) { +int virSocketAddrGetRange(virSocketAddrPtr start, virSocketAddrPtr end) +{ int ret = 0; size_t i; diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 609d815..512310f 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -215,7 +215,8 @@ virSysinfoParseProcessor(const char *base, virSysinfoDefPtr ret) /* virSysinfoRead for PowerPC * Gathers sysinfo data from /proc/cpuinfo */ virSysinfoDefPtr -virSysinfoRead(void) { +virSysinfoRead(void) +{ virSysinfoDefPtr ret = NULL; char *outbuf = NULL; @@ -332,7 +333,8 @@ error: /* virSysinfoRead for ARMv7 * Gathers sysinfo data from /proc/cpuinfo */ virSysinfoDefPtr -virSysinfoRead(void) { +virSysinfoRead(void) +{ virSysinfoDefPtr ret = NULL; char *outbuf = NULL; @@ -459,7 +461,8 @@ cleanup: /* virSysinfoRead for s390x * Gathers sysinfo data from /proc/sysinfo and /proc/cpuinfo */ virSysinfoDefPtr -virSysinfoRead(void) { +virSysinfoRead(void) +{ virSysinfoDefPtr ret = NULL; char *outbuf = NULL; @@ -507,7 +510,8 @@ no_memory: defined(__aarch64__) || \ defined(__powerpc__)) virSysinfoDefPtr -virSysinfoRead(void) { +virSysinfoRead(void) +{ /* * this can probably be extracted from Windows using API or registry * http://www.microsoft.com/whdc/system/platform/firmware/SMBIOS.mspx @@ -818,7 +822,8 @@ virSysinfoParseMemory(const char *base, virSysinfoDefPtr ret) } virSysinfoDefPtr -virSysinfoRead(void) { +virSysinfoRead(void) +{ char *path; virSysinfoDefPtr ret = NULL; char *outbuf = NULL; diff --git a/src/util/virthread.c b/src/util/virthread.c index d3dfd16..f0e14fc 100644 --- a/src/util/virthread.c +++ b/src/util/virthread.c @@ -1,7 +1,7 @@ /* * virthread.c: basic thread synchronization primitives * - * Copyright (C) 2009-2010 Red Hat, Inc. + * Copyright (C) 2009-2010, 2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -83,7 +83,8 @@ void virMutexDestroy(virMutexPtr m) pthread_mutex_destroy(&m->lock); } -void virMutexLock(virMutexPtr m){ +void virMutexLock(virMutexPtr m) +{ pthread_mutex_lock(&m->lock); } diff --git a/src/util/virutil.c b/src/util/virutil.c index 121722d..733cdff 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1,7 +1,7 @@ /* * virutil.c: common, generic utility functions * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * Copyright (C) 2006, 2007 Binary Karma * Copyright (C) 2006 Shuveb Hussain @@ -94,7 +94,8 @@ VIR_LOG_INIT("util.util"); #ifndef WIN32 -int virSetInherit(int fd, bool inherit) { +int virSetInherit(int fd, bool inherit) +{ int fflags; if ((fflags = fcntl(fd, F_GETFD)) < 0) return -1; @@ -120,11 +121,13 @@ int virSetInherit(int fd ATTRIBUTE_UNUSED, bool inherit ATTRIBUTE_UNUSED) #endif /* WIN32 */ -int virSetBlocking(int fd, bool blocking) { +int virSetBlocking(int fd, bool blocking) +{ return set_nonblocking_flag(fd, !blocking); } -int virSetNonBlock(int fd) { +int virSetNonBlock(int fd) +{ return virSetBlocking(fd, false); } @@ -502,7 +505,8 @@ const char *virEnumToString(const char *const*types, * @param name The name of the device * @return name's index, or -1 on failure */ -int virDiskNameToIndex(const char *name) { +int virDiskNameToIndex(const char *name) +{ const char *ptr = NULL; int idx = 0; static char const* const drive_prefix[] = {"fd", "hd", "vd", "sd", "xvd", "ubd"}; @@ -1465,7 +1469,8 @@ void virFileWaitForDevices(void) {} } #else -void virFileWaitForDevices(void) {} +void virFileWaitForDevices(void) +{} #endif #if HAVE_LIBDEVMAPPER_H @@ -1489,7 +1494,8 @@ bool virIsDevMapperDevice(const char *dev_name ATTRIBUTE_UNUSED) #endif bool -virValidateWWN(const char *wwn) { +virValidateWWN(const char *wwn) +{ size_t i; const char *p = wwn; diff --git a/src/util/virutil.h b/src/util/virutil.h index cffe1ed..1f2efd5 100644 --- a/src/util/virutil.h +++ b/src/util/virutil.h @@ -98,19 +98,23 @@ const char *virEnumToString(const char *const*types, /* No-op workarounds for functionality missing in mingw. */ # ifndef HAVE_GETUID -static inline int getuid(void) { return 0; } +static inline int getuid(void) +{ return 0; } # endif # ifndef HAVE_GETEUID -static inline int geteuid(void) { return 0; } +static inline int geteuid(void) +{ return 0; } # endif # ifndef HAVE_GETGID -static inline int getgid(void) { return 0; } +static inline int getgid(void) +{ return 0; } # endif # ifndef HAVE_GETEGID -static inline int getegid(void) { return 0; } +static inline int getegid(void) +{ return 0; } # endif # ifdef FUNC_PTHREAD_SIGMASK_BROKEN diff --git a/src/util/viruuid.c b/src/util/viruuid.c index eacac44..615d419 100644 --- a/src/util/viruuid.c +++ b/src/util/viruuid.c @@ -1,7 +1,7 @@ /* * viruuid.c: helper APIs for dealing with UUIDs * - * Copyright (C) 2007-2013 Red Hat, Inc. + * Copyright (C) 2007-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -149,7 +149,8 @@ virUUIDGenerate(unsigned char *uuid) * Returns 0 in case of success and -1 in case of error. */ int -virUUIDParse(const char *uuidstr, unsigned char *uuid) { +virUUIDParse(const char *uuidstr, unsigned char *uuid) +{ const char *cur; size_t i; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:43PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/util/vircgroup.c | 9 ++++++--- src/util/virconf.c | 5 +++-- src/util/virdbus.c | 8 +++++--- src/util/virerror.c | 3 ++- src/util/vireventpoll.c | 29 +++++++++++++++++++---------- src/util/virhook.c | 11 +++++++---- src/util/virnetdevvportprofile.c | 5 +++-- src/util/virrandom.c | 5 +++-- src/util/virsocketaddr.c | 26 +++++++++++++++++--------- src/util/virsysinfo.c | 15 ++++++++++----- src/util/virthread.c | 5 +++-- src/util/virutil.c | 20 +++++++++++++------- src/util/virutil.h | 12 ++++++++---- src/util/viruuid.c | 5 +++-- 14 files changed, 102 insertions(+), 56 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index c5925b1..84847b2 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -419,7 +419,8 @@ virCgroupCopyPlacement(virCgroupPtr group, /* * parent == "/" + path="" => "/" * parent == "/libvirt.service" + path == "" => "/libvirt.service" - * parent == "/libvirt.service" + path == "foo" => "/libvirt.service/foo" + * parent == "/libvirt.service" + + * path == "foo" => "/libvirt.service/foo" */ if (virAsprintf(&group->controllers[i].placement, "%s%s%s", @@ -519,8 +520,10 @@ virCgroupDetectPlacement(virCgroupPtr group,
/* * selfpath == "/" + path="" -> "/" - * selfpath == "/libvirt.service" + path == "" -> "/libvirt.service" - * selfpath == "/libvirt.service" + path == "foo" -> "/libvirt.service/foo" + * selfpath == "/libvirt.service" + + * path == "" -> "/libvirt.service" + * selfpath == "/libvirt.service" + + * path == "foo" -> "/libvirt.service/foo" */ if (typelen == len && STREQLEN(typestr, tmp, len) && group->controllers[i].mountPoint != NULL &&
These two chunks aren't related to curly brace changes. This kind of thing is an example where I think long lines are better than forced line breaks which harm readability. ACK to everything else in the patch except this. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Thu, Mar 20, 2014 at 03:20:52PM +0000, Daniel P. Berrange wrote:
On Wed, Mar 19, 2014 at 12:18:43PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/util/vircgroup.c | 9 ++++++--- src/util/virconf.c | 5 +++-- src/util/virdbus.c | 8 +++++--- src/util/virerror.c | 3 ++- src/util/vireventpoll.c | 29 +++++++++++++++++++---------- src/util/virhook.c | 11 +++++++---- src/util/virnetdevvportprofile.c | 5 +++-- src/util/virrandom.c | 5 +++-- src/util/virsocketaddr.c | 26 +++++++++++++++++--------- src/util/virsysinfo.c | 15 ++++++++++----- src/util/virthread.c | 5 +++-- src/util/virutil.c | 20 +++++++++++++------- src/util/virutil.h | 12 ++++++++---- src/util/viruuid.c | 5 +++-- 14 files changed, 102 insertions(+), 56 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index c5925b1..84847b2 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -419,7 +419,8 @@ virCgroupCopyPlacement(virCgroupPtr group, /* * parent == "/" + path="" => "/" * parent == "/libvirt.service" + path == "" => "/libvirt.service" - * parent == "/libvirt.service" + path == "foo" => "/libvirt.service/foo" + * parent == "/libvirt.service" + + * path == "foo" => "/libvirt.service/foo" */ if (virAsprintf(&group->controllers[i].placement, "%s%s%s", @@ -519,8 +520,10 @@ virCgroupDetectPlacement(virCgroupPtr group,
/* * selfpath == "/" + path="" -> "/" - * selfpath == "/libvirt.service" + path == "" -> "/libvirt.service" - * selfpath == "/libvirt.service" + path == "foo" -> "/libvirt.service/foo" + * selfpath == "/libvirt.service" + + * path == "" -> "/libvirt.service" + * selfpath == "/libvirt.service" + + * path == "foo" -> "/libvirt.service/foo" */ if (typelen == len && STREQLEN(typestr, tmp, len) && group->controllers[i].mountPoint != NULL &&
These two chunks aren't related to curly brace changes. This kind of thing is an example where I think long lines are better than forced line breaks which harm readability.
I went through all the lines longer than 80 lines somewhere and this is a leftover of non-applied fixup for commit cc9c62fe (Require spaces around equality comparisons). I'll definitely drop this hunk as it doesn't even belong here.
ACK to everything else in the patch except this.
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/rpc/virnetserver.c | 8 +++++--- src/rpc/virnetserverclient.c | 5 +++-- src/rpc/virnettlscontext.c | 5 +++-- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index cea2b23..14fd102 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -1,7 +1,7 @@ /* * virnetserver.c: generic network RPC server * - * Copyright (C) 2006-2012 Red Hat, Inc. + * Copyright (C) 2006-2012, 2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -850,7 +850,8 @@ static void virNetServerSignalEvent(int watch, int fd ATTRIBUTE_UNUSED, int events ATTRIBUTE_UNUSED, - void *opaque) { + void *opaque) +{ virNetServerPtr srv = opaque; siginfo_t siginfo; size_t i; @@ -1021,7 +1022,8 @@ int virNetServerSetTLSContext(virNetServerPtr srv, static void virNetServerAutoShutdownTimer(int timerid ATTRIBUTE_UNUSED, - void *opaque) { + void *opaque) +{ virNetServerPtr srv = opaque; virObjectLock(srv); diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 495b0b3..1251b2d 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -1,7 +1,7 @@ /* * virnetserverclient.c: generic network RPC server client * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -141,7 +141,8 @@ static int virNetServerClientSendMessageLocked(virNetServerClientPtr client, * @client: a locked client object */ static int -virNetServerClientCalculateHandleMode(virNetServerClientPtr client) { +virNetServerClientCalculateHandleMode(virNetServerClientPtr client) +{ int mode = 0; diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 7bf2a2e..4eaf469 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -1,7 +1,7 @@ /* * virnettlscontext.c: TLS encryption/x509 handling * - * Copyright (C) 2010-2013 Red Hat, Inc. + * Copyright (C) 2010-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -125,7 +125,8 @@ virNetTLSContextCheckCertFile(const char *type, const char *file, bool allowMiss static void virNetTLSLog(int level ATTRIBUTE_UNUSED, - const char *str ATTRIBUTE_UNUSED) { + const char *str ATTRIBUTE_UNUSED) +{ VIR_DEBUG("%d %s", level, str); } -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:44PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/rpc/virnetserver.c | 8 +++++--- src/rpc/virnetserverclient.c | 5 +++-- src/rpc/virnettlscontext.c | 5 +++-- 3 files changed, 11 insertions(+), 7 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/conf/domain_conf.c | 9 +++++--- src/conf/domain_nwfilter.c | 13 +++++++---- src/conf/interface_conf.c | 54 ++++++++++++++++++++++++++++++---------------- src/conf/nwfilter_conf.c | 30 +++++++++++++++++--------- src/conf/nwfilter_params.c | 3 ++- 5 files changed, 73 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 89aa52c..081ec8d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6193,7 +6193,8 @@ virDomainNetGenerateMAC(virDomainXMLOptionPtr xmlopt, static virDomainFSDefPtr virDomainFSDefParseXML(xmlNodePtr node, xmlXPathContextPtr ctxt, - unsigned int flags) { + unsigned int flags) +{ virDomainFSDefPtr def; xmlNodePtr cur, save_node = ctxt->node; char *type = NULL; @@ -7013,7 +7014,8 @@ error: } static int -virDomainChrDefaultTargetType(int devtype) { +virDomainChrDefaultTargetType(int devtype) +{ switch ((enum virDomainChrDeviceType) devtype) { case VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL: virReportError(VIR_ERR_XML_ERROR, @@ -7419,7 +7421,8 @@ error: * default port. */ virDomainChrDefPtr -virDomainChrDefNew(void) { +virDomainChrDefNew(void) +{ virDomainChrDefPtr def = NULL; if (VIR_ALLOC(def) < 0) diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c index 688a200..6330f67 100644 --- a/src/conf/domain_nwfilter.c +++ b/src/conf/domain_nwfilter.c @@ -1,6 +1,7 @@ /* * domain_nwfilter.c: * + * Copyright (C) 2014 Red Hat, Inc. * Copyright (C) 2010 IBM Corporation * * This library is free software; you can redistribute it and/or @@ -31,14 +32,16 @@ static virDomainConfNWFilterDriverPtr nwfilterDriver; void -virDomainConfNWFilterRegister(virDomainConfNWFilterDriverPtr driver) { +virDomainConfNWFilterRegister(virDomainConfNWFilterDriverPtr driver) +{ nwfilterDriver = driver; } int virDomainConfNWFilterInstantiate(virConnectPtr conn, const unsigned char *vmuuid, - virDomainNetDefPtr net) { + virDomainNetDefPtr net) +{ if (nwfilterDriver != NULL) return nwfilterDriver->instantiateFilter(conn, vmuuid, net); /* driver module not available -- don't indicate failure */ @@ -46,13 +49,15 @@ virDomainConfNWFilterInstantiate(virConnectPtr conn, } void -virDomainConfNWFilterTeardown(virDomainNetDefPtr net) { +virDomainConfNWFilterTeardown(virDomainNetDefPtr net) +{ if (nwfilterDriver != NULL) nwfilterDriver->teardownFilter(net); } void -virDomainConfVMNWFilterTeardown(virDomainObjPtr vm) { +virDomainConfVMNWFilterTeardown(virDomainObjPtr vm) +{ size_t i; if (nwfilterDriver != NULL) { diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 9f065bf..83cc0a9 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -44,7 +44,8 @@ static int virInterfaceDefDevFormat(virBufferPtr buf, const virInterfaceDef *def); static -void virInterfaceIpDefFree(virInterfaceIpDefPtr def) { +void virInterfaceIpDefFree(virInterfaceIpDefPtr def) +{ if (def == NULL) return; VIR_FREE(def->address); @@ -52,7 +53,8 @@ void virInterfaceIpDefFree(virInterfaceIpDefPtr def) { } static -void virInterfaceProtocolDefFree(virInterfaceProtocolDefPtr def) { +void virInterfaceProtocolDefFree(virInterfaceProtocolDefPtr def) +{ size_t i; if (def == NULL) @@ -112,7 +114,8 @@ void virInterfaceDefFree(virInterfaceDefPtr def) static int virInterfaceDefParseName(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ char *tmp; tmp = virXPathString("string(./@name)", ctxt); @@ -127,7 +130,8 @@ virInterfaceDefParseName(virInterfaceDefPtr def, static int virInterfaceDefParseMtu(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ unsigned long mtu; int ret; @@ -144,7 +148,8 @@ virInterfaceDefParseMtu(virInterfaceDefPtr def, static int virInterfaceDefParseStartMode(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ char *tmp; tmp = virXPathString("string(./start/@mode)", ctxt); @@ -167,7 +172,8 @@ virInterfaceDefParseStartMode(virInterfaceDefPtr def, } static int -virInterfaceDefParseBondMode(xmlXPathContextPtr ctxt) { +virInterfaceDefParseBondMode(xmlXPathContextPtr ctxt) +{ char *tmp; int ret = 0; @@ -198,7 +204,8 @@ virInterfaceDefParseBondMode(xmlXPathContextPtr ctxt) { } static int -virInterfaceDefParseBondMiiCarrier(xmlXPathContextPtr ctxt) { +virInterfaceDefParseBondMiiCarrier(xmlXPathContextPtr ctxt) +{ char *tmp; int ret = 0; @@ -219,7 +226,8 @@ virInterfaceDefParseBondMiiCarrier(xmlXPathContextPtr ctxt) { } static int -virInterfaceDefParseBondArpValid(xmlXPathContextPtr ctxt) { +virInterfaceDefParseBondArpValid(xmlXPathContextPtr ctxt) +{ char *tmp; int ret = 0; @@ -243,7 +251,8 @@ virInterfaceDefParseBondArpValid(xmlXPathContextPtr ctxt) { static int virInterfaceDefParseDhcp(virInterfaceProtocolDefPtr def, - xmlNodePtr dhcp, xmlXPathContextPtr ctxt) { + xmlNodePtr dhcp, xmlXPathContextPtr ctxt) +{ xmlNodePtr save; char *tmp; int ret = 0; @@ -273,7 +282,8 @@ virInterfaceDefParseDhcp(virInterfaceProtocolDefPtr def, static int virInterfaceDefParseIp(virInterfaceIpDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ int ret = 0; char *tmp; long l; @@ -296,7 +306,8 @@ virInterfaceDefParseIp(virInterfaceIpDefPtr def, static int virInterfaceDefParseProtoIPv4(virInterfaceProtocolDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ xmlNodePtr dhcp; xmlNodePtr *ipNodes = NULL; int nIpNodes, ret = -1; @@ -346,7 +357,8 @@ error: static int virInterfaceDefParseProtoIPv6(virInterfaceProtocolDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ xmlNodePtr dhcp, autoconf; xmlNodePtr *ipNodes = NULL; int nIpNodes, ret = -1; @@ -400,7 +412,8 @@ error: static int virInterfaceDefParseIfAdressing(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ xmlNodePtr save; xmlNodePtr *protoNodes = NULL; int nProtoNodes, pp, ret = -1; @@ -469,7 +482,8 @@ error: static int virInterfaceDefParseBridge(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ xmlNodePtr *interfaces = NULL; xmlNodePtr bridge; virInterfaceDefPtr itf; @@ -510,7 +524,8 @@ error: static int virInterfaceDefParseBondItfs(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ xmlNodePtr *interfaces = NULL; xmlNodePtr bond = ctxt->node; virInterfaceDefPtr itf; @@ -556,7 +571,8 @@ error: static int virInterfaceDefParseBond(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ int res; def->data.bond.mode = virInterfaceDefParseBondMode(ctxt); @@ -627,7 +643,8 @@ virInterfaceDefParseBond(virInterfaceDefPtr def, static int virInterfaceDefParseVlan(virInterfaceDefPtr def, - xmlXPathContextPtr ctxt) { + xmlXPathContextPtr ctxt) +{ def->data.vlan.tag = virXPathString("string(./@tag)", ctxt); if (def->data.vlan.tag == NULL) { virReportError(VIR_ERR_XML_ERROR, @@ -646,7 +663,8 @@ virInterfaceDefParseVlan(virInterfaceDefPtr def, } static virInterfaceDefPtr -virInterfaceDefParseXML(xmlXPathContextPtr ctxt, int parentIfType) { +virInterfaceDefParseXML(xmlXPathContextPtr ctxt, int parentIfType) +{ virInterfaceDefPtr def; int type; char *tmp; diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 2ea4d2e..fc800e3 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -147,17 +147,20 @@ static virRWLock updateLock; static bool initialized = false; void -virNWFilterReadLockFilterUpdates(void) { +virNWFilterReadLockFilterUpdates(void) +{ virRWLockRead(&updateLock); } void -virNWFilterWriteLockFilterUpdates(void) { +virNWFilterWriteLockFilterUpdates(void) +{ virRWLockWrite(&updateLock); } void -virNWFilterUnlockFilterUpdates(void) { +virNWFilterUnlockFilterUpdates(void) +{ virRWLockUnlock(&updateLock); } @@ -280,7 +283,8 @@ intMapGetByString(const struct int_map *intmap, const char *str, int casecmp, void -virNWFilterRuleDefFree(virNWFilterRuleDefPtr def) { +virNWFilterRuleDefFree(virNWFilterRuleDefPtr def) +{ size_t i; if (!def) return; @@ -299,7 +303,8 @@ virNWFilterRuleDefFree(virNWFilterRuleDefPtr def) { static void -virNWFilterIncludeDefFree(virNWFilterIncludeDefPtr inc) { +virNWFilterIncludeDefFree(virNWFilterIncludeDefPtr inc) +{ if (!inc) return; virNWFilterHashTableFree(inc->params); @@ -309,7 +314,8 @@ virNWFilterIncludeDefFree(virNWFilterIncludeDefPtr inc) { static void -virNWFilterEntryFree(virNWFilterEntryPtr entry) { +virNWFilterEntryFree(virNWFilterEntryPtr entry) +{ if (!entry) return; @@ -320,7 +326,8 @@ virNWFilterEntryFree(virNWFilterEntryPtr entry) { void -virNWFilterDefFree(virNWFilterDefPtr def) { +virNWFilterDefFree(virNWFilterDefPtr def) +{ size_t i; if (!def) return; @@ -2493,7 +2500,8 @@ err_exit: } static virNWFilterDefPtr -virNWFilterDefParseXML(xmlXPathContextPtr ctxt) { +virNWFilterDefParseXML(xmlXPathContextPtr ctxt) +{ virNWFilterDefPtr ret; xmlNodePtr curr = ctxt->node; char *uuid = NULL; @@ -2622,7 +2630,8 @@ virNWFilterDefParseXML(xmlXPathContextPtr ctxt) { virNWFilterDefPtr virNWFilterDefParseNode(xmlDocPtr xml, - xmlNodePtr root) { + xmlNodePtr root) +{ xmlXPathContextPtr ctxt = NULL; virNWFilterDefPtr def = NULL; @@ -2650,7 +2659,8 @@ cleanup: static virNWFilterDefPtr virNWFilterDefParse(const char *xmlStr, - const char *filename) { + const char *filename) +{ virNWFilterDefPtr def = NULL; xmlDocPtr xml; diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index fef8b61..97fc0a6 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -684,7 +684,8 @@ virNWFilterHashTableFree(virNWFilterHashTablePtr table) virNWFilterHashTablePtr -virNWFilterHashTableCreate(int n) { +virNWFilterHashTableCreate(int n) +{ virNWFilterHashTablePtr ret; if (VIR_ALLOC(ret) < 0) -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:45PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/conf/domain_conf.c | 9 +++++--- src/conf/domain_nwfilter.c | 13 +++++++---- src/conf/interface_conf.c | 54 ++++++++++++++++++++++++++++++---------------- src/conf/nwfilter_conf.c | 30 +++++++++++++++++--------- src/conf/nwfilter_params.c | 3 ++- 5 files changed, 73 insertions(+), 36 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/qemu/qemu_agent.c | 5 ++- src/qemu/qemu_command.c | 6 ++- src/qemu/qemu_driver.c | 94 +++++++++++++++++++++++++++++--------------- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_monitor_json.c | 3 +- src/qemu/qemu_monitor_text.c | 20 +++++++--- 7 files changed, 90 insertions(+), 44 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 83f077f..9f02e52 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1,7 +1,7 @@ /* * qemu_agent.c: interaction with QEMU guest agent * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -574,7 +574,8 @@ static void qemuAgentUpdateWatch(qemuAgentPtr mon) static void -qemuAgentIO(int watch, int fd, int events, void *opaque) { +qemuAgentIO(int watch, int fd, int events, void *opaque) +{ qemuAgentPtr mon = opaque; bool error = false; bool eof = false; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 5ca3f74..2311d89 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1871,7 +1871,8 @@ cleanup: } static bool -qemuDomainSupportsPCI(virDomainDefPtr def) { +qemuDomainSupportsPCI(virDomainDefPtr def) +{ if ((def->os.arch != VIR_ARCH_ARMV7L) && (def->os.arch != VIR_ARCH_AARCH64)) return true; @@ -11197,7 +11198,8 @@ error: static void -qemuParseCommandLineBootDevs(virDomainDefPtr def, const char *str) { +qemuParseCommandLineBootDevs(virDomainDefPtr def, const char *str) +{ int n, b = 0; for (n = 0; str[n] && b < VIR_DOMAIN_BOOT_LAST; n++) { diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2707bec..20239f1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -172,9 +172,11 @@ virQEMUDriverPtr qemu_driver = NULL; static void -qemuVMDriverLock(void) {} +qemuVMDriverLock(void) +{} static void -qemuVMDriverUnlock(void) {} +qemuVMDriverUnlock(void) +{} static int qemuVMFilterRebuild(virDomainObjListIterator iter, void *data) @@ -879,7 +881,8 @@ static void qemuNotifyLoadDomain(virDomainObjPtr vm, int newVM, void *opaque) * files and update its state and the networking */ static int -qemuStateReload(void) { +qemuStateReload(void) +{ virQEMUDriverConfigPtr cfg = NULL; virCapsPtr caps = NULL; @@ -910,7 +913,8 @@ cleanup: * */ static int -qemuStateStop(void) { +qemuStateStop(void) +{ int ret = -1; virConnectPtr conn; int numDomains = 0; @@ -967,7 +971,8 @@ qemuStateStop(void) { * Shutdown the QEmu daemon, it will stop all active domains and networks */ static int -qemuStateCleanup(void) { +qemuStateCleanup(void) +{ if (!qemu_driver) return -1; @@ -1145,7 +1150,8 @@ static int qemuConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED) static int -kvmGetMaxVCPUs(void) { +kvmGetMaxVCPUs(void) +{ int fd; int ret; @@ -1201,7 +1207,9 @@ qemuConnectGetSysinfo(virConnectPtr conn, unsigned int flags) return virBufferContentAndReset(&buf); } -static int qemuConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED, const char *type) { +static int +qemuConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED, const char *type) +{ if (virConnectGetMaxVcpusEnsureACL(conn) < 0) return -1; @@ -1321,7 +1329,8 @@ qemuGetProcessInfo(unsigned long long *cpuTime, int *lastCpu, long *vm_rss, static virDomainPtr qemuDomainLookupByID(virConnectPtr conn, - int id) { + int id) +{ virQEMUDriverPtr driver = conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -1347,7 +1356,8 @@ cleanup: } static virDomainPtr qemuDomainLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ virQEMUDriverPtr driver = conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -1375,7 +1385,8 @@ cleanup: } static virDomainPtr qemuDomainLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ virQEMUDriverPtr driver = conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -1458,7 +1469,8 @@ cleanup: return ret; } -static int qemuConnectGetVersion(virConnectPtr conn, unsigned long *version) { +static int qemuConnectGetVersion(virConnectPtr conn, unsigned long *version) +{ virQEMUDriverPtr driver = conn->privateData; int ret = -1; unsigned int qemuVersion = 0; @@ -1493,7 +1505,8 @@ static char *qemuConnectGetHostname(virConnectPtr conn) } -static int qemuConnectListDomains(virConnectPtr conn, int *ids, int nids) { +static int qemuConnectListDomains(virConnectPtr conn, int *ids, int nids) +{ virQEMUDriverPtr driver = conn->privateData; int n; @@ -1506,7 +1519,8 @@ static int qemuConnectListDomains(virConnectPtr conn, int *ids, int nids) { return n; } -static int qemuConnectNumOfDomains(virConnectPtr conn) { +static int qemuConnectNumOfDomains(virConnectPtr conn) +{ virQEMUDriverPtr driver = conn->privateData; int n; @@ -1542,7 +1556,8 @@ qemuCanonicalizeMachine(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) static virDomainPtr qemuDomainCreateXML(virConnectPtr conn, const char *xml, - unsigned int flags) { + unsigned int flags) +{ virQEMUDriverPtr driver = conn->privateData; virDomainDefPtr def = NULL; virDomainObjPtr vm = NULL; @@ -1648,7 +1663,8 @@ cleanup: } -static int qemuDomainSuspend(virDomainPtr dom) { +static int qemuDomainSuspend(virDomainPtr dom) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -1729,7 +1745,8 @@ cleanup: } -static int qemuDomainResume(virDomainPtr dom) { +static int qemuDomainResume(virDomainPtr dom) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -1793,7 +1810,8 @@ cleanup: return ret; } -static int qemuDomainShutdownFlags(virDomainPtr dom, unsigned int flags) { +static int qemuDomainShutdownFlags(virDomainPtr dom, unsigned int flags) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -2155,7 +2173,8 @@ cleanup: } static int qemuDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem, - unsigned int flags) { + unsigned int flags) +{ virQEMUDriverPtr driver = dom->conn->privateData; qemuDomainObjPrivatePtr priv; virDomainObjPtr vm; @@ -2652,7 +2671,8 @@ struct _virQEMUSaveHeader { }; static inline void -bswap_header(virQEMUSaveHeaderPtr hdr) { +bswap_header(virQEMUSaveHeaderPtr hdr) +{ hdr->version = bswap_32(hdr->version); hdr->xml_len = bswap_32(hdr->xml_len); hdr->was_running = bswap_32(hdr->was_running); @@ -4248,7 +4268,8 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu, unsigned char *cpumap, int maplen, - unsigned int flags) { + unsigned int flags) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm; @@ -4424,7 +4445,8 @@ static int qemuDomainPinVcpu(virDomainPtr dom, unsigned int vcpu, unsigned char *cpumap, - int maplen) { + int maplen) +{ return qemuDomainPinVcpuFlags(dom, vcpu, cpumap, maplen, VIR_DOMAIN_AFFECT_LIVE); } @@ -4434,7 +4456,8 @@ qemuDomainGetVcpuPinInfo(virDomainPtr dom, int ncpumaps, unsigned char *cpumaps, int maplen, - unsigned int flags) { + unsigned int flags) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm = NULL; @@ -4758,7 +4781,8 @@ qemuDomainGetVcpus(virDomainPtr dom, virVcpuInfoPtr info, int maxinfo, unsigned char *cpumaps, - int maplen) { + int maplen) +{ virDomainObjPtr vm; size_t i; int v, maxcpu, hostcpus; @@ -5951,7 +5975,8 @@ cleanup: return ret; } -static int qemuConnectNumOfDefinedDomains(virConnectPtr conn) { +static int qemuConnectNumOfDefinedDomains(virConnectPtr conn) +{ virQEMUDriverPtr driver = conn->privateData; int ret = -1; @@ -6099,7 +6124,8 @@ qemuDomainCreate(virDomainPtr dom) return qemuDomainCreateWithFlags(dom, 0); } -static virDomainPtr qemuDomainDefineXML(virConnectPtr conn, const char *xml) { +static virDomainPtr qemuDomainDefineXML(virConnectPtr conn, const char *xml) +{ virQEMUDriverPtr driver = conn->privateData; virDomainDefPtr def = NULL; virDomainDefPtr oldDef = NULL; @@ -7289,7 +7315,8 @@ static int qemuDomainDetachDevice(virDomainPtr dom, const char *xml) } static int qemuDomainGetAutostart(virDomainPtr dom, - int *autostart) { + int *autostart) +{ virDomainObjPtr vm; int ret = -1; @@ -7309,7 +7336,8 @@ cleanup: } static int qemuDomainSetAutostart(virDomainPtr dom, - int autostart) { + int autostart) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm; char *configFile = NULL, *autostartLink = NULL; @@ -11447,7 +11475,8 @@ cleanup: static int qemuDomainGetJobInfo(virDomainPtr dom, - virDomainJobInfoPtr info) { + virDomainJobInfoPtr info) +{ virDomainObjPtr vm; int ret = -1; qemuDomainObjPrivatePtr priv; @@ -11634,7 +11663,8 @@ cleanup: } -static int qemuDomainAbortJob(virDomainPtr dom) { +static int qemuDomainAbortJob(virDomainPtr dom) +{ virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -12006,7 +12036,8 @@ cleanup: static int -qemuDomainSnapshotFSFreeze(virDomainObjPtr vm) { +qemuDomainSnapshotFSFreeze(virDomainObjPtr vm) +{ qemuDomainObjPrivatePtr priv = vm->privateData; int freezed; @@ -16711,7 +16742,8 @@ static virStateDriver qemuStateDriver = { .stateStop = qemuStateStop, }; -int qemuRegister(void) { +int qemuRegister(void) +{ if (virRegisterDriver(&qemuDriver) < 0) return -1; if (virRegisterStateDriver(&qemuStateDriver) < 0) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 26ac99b..ab6f287 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4340,7 +4340,8 @@ qemuMigrationPerform(virQEMUDriverPtr driver, } static int -qemuMigrationVPAssociatePortProfiles(virDomainDefPtr def) { +qemuMigrationVPAssociatePortProfiles(virDomainDefPtr def) +{ size_t i; int last_good_net = -1; virDomainNetDefPtr net; diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 56e82fd..1783201 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -597,7 +597,8 @@ static void qemuMonitorUpdateWatch(qemuMonitorPtr mon) static void -qemuMonitorIO(int watch, int fd, int events, void *opaque) { +qemuMonitorIO(int watch, int fd, int events, void *opaque) +{ qemuMonitorPtr mon = opaque; bool error = false; bool eof = false; diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index bd26eb1..f387933 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -294,7 +294,8 @@ cleanup: static int qemuMonitorJSONCommand(qemuMonitorPtr mon, virJSONValuePtr cmd, - virJSONValuePtr *reply) { + virJSONValuePtr *reply) +{ return qemuMonitorJSONCommandWithFd(mon, cmd, -1, reply); } diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index efb3654..558f93c 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -1,7 +1,7 @@ /* * qemu_monitor_text.c: interaction with QEMU monitor console * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -364,7 +364,8 @@ qemuMonitorSendDiskPassphrase(qemuMonitorPtr mon, int qemuMonitorTextStartCPUs(qemuMonitorPtr mon, - virConnectPtr conn) { + virConnectPtr conn) +{ char *reply; if (qemuMonitorTextCommandWithHandler(mon, "cont", @@ -379,7 +380,8 @@ qemuMonitorTextStartCPUs(qemuMonitorPtr mon, int -qemuMonitorTextStopCPUs(qemuMonitorPtr mon) { +qemuMonitorTextStopCPUs(qemuMonitorPtr mon) +{ char *info; int ret; @@ -434,7 +436,8 @@ cleanup: } -int qemuMonitorTextSystemPowerdown(qemuMonitorPtr mon) { +int qemuMonitorTextSystemPowerdown(qemuMonitorPtr mon) +{ char *info; int ret; @@ -444,7 +447,11 @@ int qemuMonitorTextSystemPowerdown(qemuMonitorPtr mon) { return ret; } -int qemuMonitorTextSetLink(qemuMonitorPtr mon, const char *name, enum virDomainNetInterfaceLinkState state) { +int +qemuMonitorTextSetLink(qemuMonitorPtr mon, + const char *name, + enum virDomainNetInterfaceLinkState state) +{ char *info = NULL; char *cmd = NULL; const char *st_str = NULL; @@ -486,7 +493,8 @@ error: return -1; } -int qemuMonitorTextSystemReset(qemuMonitorPtr mon) { +int qemuMonitorTextSystemReset(qemuMonitorPtr mon) +{ char *info; int ret; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:46PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/qemu/qemu_agent.c | 5 ++- src/qemu/qemu_command.c | 6 ++- src/qemu/qemu_driver.c | 94 +++++++++++++++++++++++++++++--------------- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_monitor_json.c | 3 +- src/qemu/qemu_monitor_text.c | 20 +++++++--- 7 files changed, 90 insertions(+), 44 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/storage/storage_backend_fs.c | 12 ++++--- src/storage/storage_driver.c | 78 ++++++++++++++++++++++++++-------------- 2 files changed, 60 insertions(+), 30 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index edb7cd0..722193b 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -330,7 +330,8 @@ virStorageBackendFileSystemNetFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSE * Return 0 if not mounted, 1 if mounted, -1 on error */ static int -virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) { +virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) +{ FILE *mtab; struct mntent ent; char buf[1024]; @@ -363,7 +364,8 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) { * Returns 0 if successfully mounted, -1 on error */ static int -virStorageBackendFileSystemMount(virStoragePoolObjPtr pool) { +virStorageBackendFileSystemMount(virStoragePoolObjPtr pool) +{ char *src = NULL; /* 'mount -t auto' doesn't seem to auto determine nfs (or cifs), * while plain 'mount' does. We have to craft separate argvs to @@ -467,7 +469,8 @@ cleanup: * Returns 0 if successfully unmounted, -1 on error */ static int -virStorageBackendFileSystemUnmount(virStoragePoolObjPtr pool) { +virStorageBackendFileSystemUnmount(virStoragePoolObjPtr pool) +{ virCommandPtr cmd = NULL; int ret = -1; int rc; @@ -562,7 +565,8 @@ virStorageBackendFileSystemStart(virConnectPtr conn ATTRIBUTE_UNUSED, #if WITH_BLKID static virStoragePoolProbeResult virStorageBackendFileSystemProbe(const char *device, - const char *format) { + const char *format) +{ virStoragePoolProbeResult ret = FILESYSTEM_PROBE_ERROR; blkid_probe probe = NULL; diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6a2840c..3637aa5 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -68,7 +68,8 @@ static void storageDriverUnlock(virStorageDriverStatePtr driver) } static void -storageDriverAutostart(virStorageDriverStatePtr driver) { +storageDriverAutostart(virStorageDriverStatePtr driver) +{ size_t i; virConnectPtr conn = NULL; @@ -217,7 +218,8 @@ storageStateAutoStart(void) * files and update its state */ static int -storageStateReload(void) { +storageStateReload(void) +{ if (!driverState) return -1; @@ -238,7 +240,8 @@ storageStateReload(void) { * Shutdown the storage driver, it will stop all active storage pools */ static int -storageStateCleanup(void) { +storageStateCleanup(void) +{ if (!driverState) return -1; @@ -260,7 +263,8 @@ storageStateCleanup(void) { static virStoragePoolPtr storagePoolLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; virStoragePoolObjPtr pool; virStoragePoolPtr ret = NULL; @@ -289,7 +293,8 @@ cleanup: static virStoragePoolPtr storagePoolLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; virStoragePoolObjPtr pool; virStoragePoolPtr ret = NULL; @@ -317,7 +322,8 @@ cleanup: } static virStoragePoolPtr -storagePoolLookupByVolume(virStorageVolPtr vol) { +storagePoolLookupByVolume(virStorageVolPtr vol) +{ virStorageDriverStatePtr driver = vol->conn->storagePrivateData; virStoragePoolObjPtr pool; virStoragePoolPtr ret = NULL; @@ -359,13 +365,15 @@ storageOpen(virConnectPtr conn, } static int -storageClose(virConnectPtr conn) { +storageClose(virConnectPtr conn) +{ conn->storagePrivateData = NULL; return 0; } static int -storageConnectNumOfStoragePools(virConnectPtr conn) { +storageConnectNumOfStoragePools(virConnectPtr conn) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; size_t i; int nactive = 0; @@ -390,7 +398,8 @@ storageConnectNumOfStoragePools(virConnectPtr conn) { static int storageConnectListStoragePools(virConnectPtr conn, char **const names, - int nnames) { + int nnames) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; int got = 0; size_t i; @@ -424,7 +433,8 @@ storageConnectListStoragePools(virConnectPtr conn, } static int -storageConnectNumOfDefinedStoragePools(virConnectPtr conn) { +storageConnectNumOfDefinedStoragePools(virConnectPtr conn) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; size_t i; int nactive = 0; @@ -449,7 +459,8 @@ storageConnectNumOfDefinedStoragePools(virConnectPtr conn) { static int storageConnectListDefinedStoragePools(virConnectPtr conn, char **const names, - int nnames) { + int nnames) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; int got = 0; size_t i; @@ -686,7 +697,8 @@ cleanup: } static int -storagePoolUndefine(virStoragePoolPtr obj) { +storagePoolUndefine(virStoragePoolPtr obj) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; int ret = -1; @@ -795,7 +807,8 @@ cleanup: static int storagePoolBuild(virStoragePoolPtr obj, - unsigned int flags) { + unsigned int flags) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; virStorageBackendPtr backend; @@ -837,7 +850,8 @@ cleanup: static int -storagePoolDestroy(virStoragePoolPtr obj) { +storagePoolDestroy(virStoragePoolPtr obj) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; virStorageBackendPtr backend; @@ -899,7 +913,8 @@ cleanup: static int storagePoolDelete(virStoragePoolPtr obj, - unsigned int flags) { + unsigned int flags) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; virStorageBackendPtr backend; @@ -1016,7 +1031,8 @@ cleanup: static int storagePoolGetInfo(virStoragePoolPtr obj, - virStoragePoolInfoPtr info) { + virStoragePoolInfoPtr info) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; int ret = -1; @@ -1092,7 +1108,8 @@ cleanup: static int storagePoolGetAutostart(virStoragePoolPtr obj, - int *autostart) { + int *autostart) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; int ret = -1; @@ -1125,7 +1142,8 @@ cleanup: static int storagePoolSetAutostart(virStoragePoolPtr obj, - int autostart) { + int autostart) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; int ret = -1; @@ -1187,7 +1205,8 @@ cleanup: static int -storagePoolNumOfVolumes(virStoragePoolPtr obj) { +storagePoolNumOfVolumes(virStoragePoolPtr obj) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; int ret = -1; @@ -1227,7 +1246,8 @@ cleanup: static int storagePoolListVolumes(virStoragePoolPtr obj, char **const names, - int maxnames) { + int maxnames) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; size_t i; @@ -1278,7 +1298,8 @@ storagePoolListVolumes(virStoragePoolPtr obj, static int storagePoolListAllVolumes(virStoragePoolPtr pool, virStorageVolPtr **vols, - unsigned int flags) { + unsigned int flags) +{ virStorageDriverStatePtr driver = pool->conn->storagePrivateData; virStoragePoolObjPtr obj; size_t i; @@ -1351,7 +1372,8 @@ storagePoolListAllVolumes(virStoragePoolPtr pool, static virStorageVolPtr storageVolLookupByName(virStoragePoolPtr obj, - const char *name) { + const char *name) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; virStorageVolDefPtr vol; @@ -1397,7 +1419,8 @@ cleanup: static virStorageVolPtr storageVolLookupByKey(virConnectPtr conn, - const char *key) { + const char *key) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; size_t i; virStorageVolPtr ret = NULL; @@ -1436,7 +1459,8 @@ cleanup: static virStorageVolPtr storageVolLookupByPath(virConnectPtr conn, - const char *path) { + const char *path) +{ virStorageDriverStatePtr driver = conn->storagePrivateData; size_t i; virStorageVolPtr ret = NULL; @@ -2459,7 +2483,8 @@ storageVolWipe(virStorageVolPtr obj, static int storageVolGetInfo(virStorageVolPtr obj, - virStorageVolInfoPtr info) { + virStorageVolInfoPtr info) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; virStorageBackendPtr backend; @@ -2572,7 +2597,8 @@ cleanup: } static char * -storageVolGetPath(virStorageVolPtr obj) { +storageVolGetPath(virStorageVolPtr obj) +{ virStorageDriverStatePtr driver = obj->conn->storagePrivateData; virStoragePoolObjPtr pool; virStorageVolDefPtr vol; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:47PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/storage/storage_backend_fs.c | 12 ++++--- src/storage/storage_driver.c | 78 ++++++++++++++++++++++++++-------------- 2 files changed, 60 insertions(+), 30 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/openvz/openvz_conf.c | 15 ++++++++++----- src/openvz/openvz_driver.c | 45 ++++++++++++++++++++++++++++++--------------- 2 files changed, 40 insertions(+), 20 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 11f048b..20c9a6f 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -205,7 +205,8 @@ no_memory: int openvzReadNetworkConf(virDomainDefPtr def, - int veid) { + int veid) +{ int ret; virDomainNetDefPtr net = NULL; char *temp = NULL; @@ -378,7 +379,8 @@ openvz_replace(const char* str, static int openvzReadFSConf(virDomainDefPtr def, - int veid) { + int veid) +{ int ret; virDomainFSDefPtr fs = NULL; char *veid_str = NULL; @@ -545,7 +547,8 @@ openvzFreeDriver(struct openvz_driver *driver) -int openvzLoadDomains(struct openvz_driver *driver) { +int openvzLoadDomains(struct openvz_driver *driver) +{ int veid, ret; char *status; char uuidstr[VIR_UUID_STRING_BUFLEN]; @@ -1063,7 +1066,8 @@ cleanup: } static int -openvzSetUUID(int vpsid){ +openvzSetUUID(int vpsid) +{ unsigned char uuid[VIR_UUID_BUFLEN]; if (virUUIDGenerate(uuid)) { @@ -1128,7 +1132,8 @@ static int openvzAssignUUIDs(void) * */ -int openvzGetVEID(const char *name) { +int openvzGetVEID(const char *name) +{ virCommandPtr cmd; char *outbuf; char *temp; diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 2a28ed2..526ddbd 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -299,7 +299,8 @@ error: static virDomainPtr openvzDomainLookupByID(virConnectPtr conn, - int id) { + int id) +{ struct openvz_driver *driver = conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -323,7 +324,8 @@ cleanup: return dom; } -static int openvzConnectGetVersion(virConnectPtr conn, unsigned long *version) { +static int openvzConnectGetVersion(virConnectPtr conn, unsigned long *version) +{ struct openvz_driver *driver = conn->privateData; openvzDriverLock(driver); *version = driver->version; @@ -363,7 +365,8 @@ cleanup: static virDomainPtr openvzDomainLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ struct openvz_driver *driver = conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -388,7 +391,8 @@ cleanup: } static virDomainPtr openvzDomainLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ struct openvz_driver *driver = conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -413,7 +417,8 @@ cleanup: } static int openvzDomainGetInfo(virDomainPtr dom, - virDomainInfoPtr info) { + virDomainInfoPtr info) +{ struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; int state; @@ -579,7 +584,8 @@ static void openvzSetProgramSentinal(const char **prog, const char *key) } } -static int openvzDomainSuspend(virDomainPtr dom) { +static int openvzDomainSuspend(virDomainPtr dom) +{ struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; const char *prog[] = {VZCTL, "--quiet", "chkpnt", PROGRAM_SENTINEL, "--suspend", NULL}; @@ -617,7 +623,8 @@ cleanup: return ret; } -static int openvzDomainResume(virDomainPtr dom) { +static int openvzDomainResume(virDomainPtr dom) +{ struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; const char *prog[] = {VZCTL, "--quiet", "chkpnt", PROGRAM_SENTINEL, "--resume", NULL}; @@ -657,7 +664,8 @@ cleanup: static int openvzDomainShutdownFlags(virDomainPtr dom, - unsigned int flags) { + unsigned int flags) +{ struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; const char *prog[] = {VZCTL, "--quiet", "stop", PROGRAM_SENTINEL, NULL}; @@ -1476,7 +1484,8 @@ cleanup: return VIR_DRV_OPEN_ERROR; }; -static int openvzConnectClose(virConnectPtr conn) { +static int openvzConnectClose(virConnectPtr conn) +{ struct openvz_driver *driver = conn->privateData; openvzFreeDriver(driver); @@ -1489,12 +1498,14 @@ static const char *openvzConnectGetType(virConnectPtr conn ATTRIBUTE_UNUSED) { return "OpenVZ"; } -static int openvzConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) { +static int openvzConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) +{ /* Encryption is not relevant / applicable to way we talk to openvz */ return 0; } -static int openvzConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) { +static int openvzConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) +{ /* We run CLI tools directly so this is secure */ return 1; } @@ -1517,7 +1528,8 @@ static char *openvzConnectGetCapabilities(virConnectPtr conn) { } static int openvzConnectListDomains(virConnectPtr conn ATTRIBUTE_UNUSED, - int *ids, int nids) { + int *ids, int nids) +{ int got = 0; int veid; int outfd = -1; @@ -1559,7 +1571,8 @@ cleanup: return rc; } -static int openvzConnectNumOfDomains(virConnectPtr conn) { +static int openvzConnectNumOfDomains(virConnectPtr conn) +{ struct openvz_driver *driver = conn->privateData; int n; @@ -1671,7 +1684,8 @@ Version: 2.2 return 0; } -static int openvzConnectNumOfDefinedDomains(virConnectPtr conn) { +static int openvzConnectNumOfDefinedDomains(virConnectPtr conn) +{ struct openvz_driver *driver = conn->privateData; int n; @@ -2240,7 +2254,8 @@ static virDriver openvzDriver = { .domainGetHostname = openvzDomainGetHostname, /* 0.10.0 */ }; -int openvzRegister(void) { +int openvzRegister(void) +{ if (virRegisterDriver(&openvzDriver) < 0) return -1; return 0; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:48PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/openvz/openvz_conf.c | 15 ++++++++++----- src/openvz/openvz_driver.c | 45 ++++++++++++++++++++++++++++++--------------- 2 files changed, 40 insertions(+), 20 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/nwfilter/nwfilter_driver.c | 32 +++++++++++++++--------- src/nwfilter/nwfilter_ebiptables_driver.c | 3 ++- src/nwfilter/nwfilter_learnipaddr.c | 41 ++++++++++++++++++++----------- 3 files changed, 50 insertions(+), 26 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index 0876901..4fab1f2 100644 --- a/src/nwfilter/nwfilter_driver.c +++ b/src/nwfilter/nwfilter_driver.c @@ -2,7 +2,7 @@ * nwfilter_driver.c: core driver for network filter APIs * (based on storage_driver.c) * - * Copyright (C) 2006-2011 Red Hat, Inc. + * Copyright (C) 2006-2011, 2014 Red Hat, Inc. * Copyright (C) 2006-2008 Daniel P. Berrange * Copyright (C) 2010 IBM Corporation * Copyright (C) 2010 Stefan Berger @@ -325,7 +325,8 @@ virNWFilterDriverIsWatchingFirewallD(void) * Shutdown the nwfilter driver, it will stop all active nwfilters */ static int -nwfilterStateCleanup(void) { +nwfilterStateCleanup(void) +{ if (!driverState) return -1; @@ -356,7 +357,8 @@ nwfilterStateCleanup(void) { static virNWFilterPtr nwfilterLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; virNWFilterObjPtr nwfilter; virNWFilterPtr ret = NULL; @@ -385,7 +387,8 @@ cleanup: static virNWFilterPtr nwfilterLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; virNWFilterObjPtr nwfilter; virNWFilterPtr ret = NULL; @@ -428,14 +431,16 @@ nwfilterOpen(virConnectPtr conn, static int -nwfilterClose(virConnectPtr conn) { +nwfilterClose(virConnectPtr conn) +{ conn->nwfilterPrivateData = NULL; return 0; } static int -nwfilterConnectNumOfNWFilters(virConnectPtr conn) { +nwfilterConnectNumOfNWFilters(virConnectPtr conn) +{ virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; size_t i; int n; @@ -459,7 +464,8 @@ nwfilterConnectNumOfNWFilters(virConnectPtr conn) { static int nwfilterConnectListNWFilters(virConnectPtr conn, char **const names, - int nnames) { + int nnames) +{ virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; int got = 0; size_t i; @@ -495,7 +501,8 @@ nwfilterConnectListNWFilters(virConnectPtr conn, static int nwfilterConnectListAllNWFilters(virConnectPtr conn, virNWFilterPtr **filters, - unsigned int flags) { + unsigned int flags) +{ virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; virNWFilterPtr *tmp_filters = NULL; int nfilters = 0; @@ -594,7 +601,8 @@ cleanup: static int -nwfilterUndefine(virNWFilterPtr obj) { +nwfilterUndefine(virNWFilterPtr obj) +{ virNWFilterDriverStatePtr driver = obj->conn->nwfilterPrivateData; virNWFilterObjPtr nwfilter; int ret = -1; @@ -682,7 +690,8 @@ nwfilterInstantiateFilter(virConnectPtr conn, static void -nwfilterTeardownFilter(virDomainNetDefPtr net) { +nwfilterTeardownFilter(virDomainNetDefPtr net) +{ if ((net->ifname) && (net->filter)) virNWFilterTeardownFilter(net); } @@ -717,7 +726,8 @@ static virDomainConfNWFilterDriver domainNWFilterDriver = { }; -int nwfilterRegister(void) { +int nwfilterRegister(void) +{ if (virRegisterNWFilterDriver(&nwfilterDriver) < 0) return -1; if (virRegisterStateDriver(&stateDriver) < 0) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 6909a9a..e535356 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -3198,7 +3198,8 @@ ebiptablesInstCommand(virBufferPtr buf, * In case of this driver we need the ebtables tool available. */ static int -ebiptablesCanApplyBasicRules(void) { +ebiptablesCanApplyBasicRules(void) +{ return ebtables_cmd_path != NULL; } diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c index e156a93..e01d4df 100644 --- a/src/nwfilter/nwfilter_learnipaddr.c +++ b/src/nwfilter/nwfilter_learnipaddr.c @@ -2,7 +2,7 @@ * nwfilter_learnipaddr.c: support for learning IP address used by a VM * on an interface * - * Copyright (C) 2011, 2013 Red Hat, Inc. + * Copyright (C) 2011, 2013, 2014 Red Hat, Inc. * Copyright (C) 2010 IBM Corp. * Copyright (C) 2010 Stefan Berger * @@ -138,7 +138,8 @@ static bool threadsTerminate = false; int -virNWFilterLockIface(const char *ifname) { +virNWFilterLockIface(const char *ifname) +{ virNWFilterIfaceLockPtr ifaceLock; virMutexLock(&ifaceMapLock); @@ -188,13 +189,15 @@ virNWFilterLockIface(const char *ifname) { static void -freeIfaceLock(void *payload, const void *name ATTRIBUTE_UNUSED) { +freeIfaceLock(void *payload, const void *name ATTRIBUTE_UNUSED) +{ VIR_FREE(payload); } void -virNWFilterUnlockIface(const char *ifname) { +virNWFilterUnlockIface(const char *ifname) +{ virNWFilterIfaceLockPtr ifaceLock; virMutexLock(&ifaceMapLock); @@ -214,7 +217,8 @@ virNWFilterUnlockIface(const char *ifname) { static void -virNWFilterIPAddrLearnReqFree(virNWFilterIPAddrLearnReqPtr req) { +virNWFilterIPAddrLearnReqFree(virNWFilterIPAddrLearnReqPtr req) +{ if (!req) return; @@ -228,7 +232,8 @@ virNWFilterIPAddrLearnReqFree(virNWFilterIPAddrLearnReqPtr req) { #if HAVE_LIBPCAP static int -virNWFilterRegisterLearnReq(virNWFilterIPAddrLearnReqPtr req) { +virNWFilterRegisterLearnReq(virNWFilterIPAddrLearnReqPtr req) +{ int res = -1; IFINDEX2STR(ifindex_str, req->ifindex); @@ -246,7 +251,8 @@ virNWFilterRegisterLearnReq(virNWFilterIPAddrLearnReqPtr req) { #endif int -virNWFilterTerminateLearnReq(const char *ifname) { +virNWFilterTerminateLearnReq(const char *ifname) +{ int rc = -1; int ifindex; virNWFilterIPAddrLearnReqPtr req; @@ -281,7 +287,8 @@ virNWFilterTerminateLearnReq(const char *ifname) { virNWFilterIPAddrLearnReqPtr -virNWFilterLookupLearnReq(int ifindex) { +virNWFilterLookupLearnReq(int ifindex) +{ void *res; IFINDEX2STR(ifindex_str, ifindex); @@ -296,7 +303,8 @@ virNWFilterLookupLearnReq(int ifindex) { static void -freeLearnReqEntry(void *payload, const void *name ATTRIBUTE_UNUSED) { +freeLearnReqEntry(void *payload, const void *name ATTRIBUTE_UNUSED) +{ virNWFilterIPAddrLearnReqFree(payload); } @@ -304,7 +312,8 @@ freeLearnReqEntry(void *payload, const void *name ATTRIBUTE_UNUSED) { #ifdef HAVE_LIBPCAP static virNWFilterIPAddrLearnReqPtr -virNWFilterDeregisterLearnReq(int ifindex) { +virNWFilterDeregisterLearnReq(int ifindex) +{ virNWFilterIPAddrLearnReqPtr res; IFINDEX2STR(ifindex_str, ifindex); @@ -324,7 +333,8 @@ virNWFilterDeregisterLearnReq(int ifindex) { static void procDHCPOpts(struct dhcp *dhcp, int dhcp_opts_len, uint32_t *vmaddr, uint32_t *bcastaddr, - enum howDetect *howDetected) { + enum howDetect *howDetected) +{ struct dhcp_option *dhcpopt = &dhcp->options[0]; while (dhcp_opts_len >= 2) { @@ -683,7 +693,8 @@ virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver, const char *filtername, virNWFilterHashTablePtr filterparams, virNWFilterDriverStatePtr driver, - enum howDetect howDetect) { + enum howDetect howDetect) +{ int rc; virNWFilterIPAddrLearnReqPtr req = NULL; virNWFilterHashTablePtr ht = NULL; @@ -788,7 +799,8 @@ virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver ATTRIBUTE_UNUSED, * Initialization of this layer */ int -virNWFilterLearnInit(void) { +virNWFilterLearnInit(void) +{ if (pendingLearnReq) return 0; @@ -822,7 +834,8 @@ virNWFilterLearnInit(void) { void -virNWFilterLearnThreadsTerminate(bool allowNewThreads) { +virNWFilterLearnThreadsTerminate(bool allowNewThreads) +{ threadsTerminate = true; while (virHashSize(pendingLearnReq) != 0) -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:49PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/nwfilter/nwfilter_driver.c | 32 +++++++++++++++--------- src/nwfilter/nwfilter_ebiptables_driver.c | 3 ++- src/nwfilter/nwfilter_learnipaddr.c | 41 ++++++++++++++++++++----------- 3 files changed, 50 insertions(+), 26 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/test/test_driver.c | 135 ++++++++++++++++++++++++++++++++----------------- 1 file changed, 90 insertions(+), 45 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5716449..d88d3fc 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -319,7 +319,8 @@ testBuildXMLConfig(void) static virCapsPtr -testBuildCapabilities(virConnectPtr conn) { +testBuildCapabilities(virConnectPtr conn) +{ testConnPtr privconn = conn->privateData; virCapsPtr caps; virCapsGuestPtr guest; @@ -504,7 +505,8 @@ testDomObjFromDomain(virDomainPtr domain) } static char * -testDomainGenerateIfname(virDomainDefPtr domdef) { +testDomainGenerateIfname(virDomainDefPtr domdef) +{ int maxif = 1024; int ifctr; size_t i; @@ -851,7 +853,8 @@ error: static char *testBuildFilename(const char *relativeTo, - const char *filename) { + const char *filename) +{ char *offset; int baseLen; char *ret; @@ -2495,7 +2498,8 @@ static char *testDomainGetOSType(virDomainPtr dom ATTRIBUTE_UNUSED) { return ret; } -static unsigned long long testDomainGetMaxMemory(virDomainPtr domain) { +static unsigned long long testDomainGetMaxMemory(virDomainPtr domain) +{ testConnPtr privconn = domain->conn->privateData; virDomainObjPtr privdom; unsigned long long ret = 0; @@ -2898,7 +2902,8 @@ cleanup: return ret; } -static int testConnectNumOfDefinedDomains(virConnectPtr conn) { +static int testConnectNumOfDefinedDomains(virConnectPtr conn) +{ testConnPtr privconn = conn->privateData; int count; @@ -2911,7 +2916,8 @@ static int testConnectNumOfDefinedDomains(virConnectPtr conn) { static int testConnectListDefinedDomains(virConnectPtr conn, char **const names, - int maxnames) { + int maxnames) +{ testConnPtr privconn = conn->privateData; int n; @@ -2926,7 +2932,8 @@ static int testConnectListDefinedDomains(virConnectPtr conn, } static virDomainPtr testDomainDefineXML(virConnectPtr conn, - const char *xml) { + const char *xml) +{ testConnPtr privconn = conn->privateData; virDomainPtr ret = NULL; virDomainDefPtr def; @@ -3040,7 +3047,8 @@ cleanup: static int testNodeGetCellsFreeMemory(virConnectPtr conn, unsigned long long *freemems, - int startCell, int maxCells) { + int startCell, int maxCells) +{ testConnPtr privconn = conn->privateData; int cell; size_t i; @@ -3066,7 +3074,8 @@ cleanup: } -static int testDomainCreateWithFlags(virDomainPtr domain, unsigned int flags) { +static int testDomainCreateWithFlags(virDomainPtr domain, unsigned int flags) +{ testConnPtr privconn = domain->conn->privateData; virDomainObjPtr privdom; virObjectEventPtr event = NULL; @@ -3108,7 +3117,8 @@ cleanup: return ret; } -static int testDomainCreate(virDomainPtr domain) { +static int testDomainCreate(virDomainPtr domain) +{ return testDomainCreateWithFlags(domain, 0); } @@ -3475,7 +3485,8 @@ static virDrvOpenStatus testNetworkOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int testNetworkClose(virConnectPtr conn) { +static int testNetworkClose(virConnectPtr conn) +{ conn->networkPrivateData = NULL; return 0; } @@ -3530,7 +3541,8 @@ cleanup: } -static int testConnectNumOfNetworks(virConnectPtr conn) { +static int testConnectNumOfNetworks(virConnectPtr conn) +{ testConnPtr privconn = conn->privateData; int numActive = 0; size_t i; @@ -3574,7 +3586,8 @@ error: return -1; } -static int testConnectNumOfDefinedNetworks(virConnectPtr conn) { +static int testConnectNumOfDefinedNetworks(virConnectPtr conn) +{ testConnPtr privconn = conn->privateData; int numInactive = 0; size_t i; @@ -3678,7 +3691,8 @@ cleanup: } -static virNetworkPtr testNetworkCreateXML(virConnectPtr conn, const char *xml) { +static virNetworkPtr testNetworkCreateXML(virConnectPtr conn, const char *xml) +{ testConnPtr privconn = conn->privateData; virNetworkDefPtr def; virNetworkObjPtr net = NULL; @@ -3744,7 +3758,8 @@ cleanup: return ret; } -static int testNetworkUndefine(virNetworkPtr network) { +static int testNetworkUndefine(virNetworkPtr network) +{ testConnPtr privconn = network->conn->privateData; virNetworkObjPtr privnet; int ret = -1; @@ -3831,7 +3846,8 @@ cleanup: return ret; } -static int testNetworkCreate(virNetworkPtr network) { +static int testNetworkCreate(virNetworkPtr network) +{ testConnPtr privconn = network->conn->privateData; virNetworkObjPtr privnet; int ret = -1; @@ -3867,7 +3883,8 @@ cleanup: return ret; } -static int testNetworkDestroy(virNetworkPtr network) { +static int testNetworkDestroy(virNetworkPtr network) +{ testConnPtr privconn = network->conn->privateData; virNetworkObjPtr privnet; int ret = -1; @@ -3960,7 +3977,8 @@ cleanup: } static int testNetworkGetAutostart(virNetworkPtr network, - int *autostart) { + int *autostart) +{ testConnPtr privconn = network->conn->privateData; virNetworkObjPtr privnet; int ret = -1; @@ -3985,7 +4003,8 @@ cleanup: } static int testNetworkSetAutostart(virNetworkPtr network, - int autostart) { + int autostart) +{ testConnPtr privconn = network->conn->privateData; virNetworkObjPtr privnet; int ret = -1; @@ -4443,7 +4462,8 @@ cleanup: */ -static int testStoragePoolObjSetDefaults(virStoragePoolObjPtr pool) { +static int testStoragePoolObjSetDefaults(virStoragePoolObjPtr pool) +{ pool->def->capacity = defaultPoolCap; pool->def->allocation = defaultPoolAlloc; @@ -4465,7 +4485,8 @@ static virDrvOpenStatus testStorageOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int testStorageClose(virConnectPtr conn) { +static int testStorageClose(virConnectPtr conn) +{ conn->storagePrivateData = NULL; return 0; } @@ -4473,7 +4494,8 @@ static int testStorageClose(virConnectPtr conn) { static virStoragePoolPtr testStoragePoolLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ testConnPtr privconn = conn->privateData; virStoragePoolObjPtr pool; virStoragePoolPtr ret = NULL; @@ -4498,7 +4520,8 @@ cleanup: static virStoragePoolPtr testStoragePoolLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ testConnPtr privconn = conn->privateData; virStoragePoolObjPtr pool; virStoragePoolPtr ret = NULL; @@ -4522,12 +4545,14 @@ cleanup: } static virStoragePoolPtr -testStoragePoolLookupByVolume(virStorageVolPtr vol) { +testStoragePoolLookupByVolume(virStorageVolPtr vol) +{ return testStoragePoolLookupByName(vol->conn, vol->pool); } static int -testConnectNumOfStoragePools(virConnectPtr conn) { +testConnectNumOfStoragePools(virConnectPtr conn) +{ testConnPtr privconn = conn->privateData; int numActive = 0; size_t i; @@ -4544,7 +4569,8 @@ testConnectNumOfStoragePools(virConnectPtr conn) { static int testConnectListStoragePools(virConnectPtr conn, char **const names, - int nnames) { + int nnames) +{ testConnPtr privconn = conn->privateData; int n = 0; size_t i; @@ -4572,7 +4598,8 @@ error: } static int -testConnectNumOfDefinedStoragePools(virConnectPtr conn) { +testConnectNumOfDefinedStoragePools(virConnectPtr conn) +{ testConnPtr privconn = conn->privateData; int numInactive = 0; size_t i; @@ -4592,7 +4619,8 @@ testConnectNumOfDefinedStoragePools(virConnectPtr conn) { static int testConnectListDefinedStoragePools(virConnectPtr conn, char **const names, - int nnames) { + int nnames) +{ testConnPtr privconn = conn->privateData; int n = 0; size_t i; @@ -4858,7 +4886,8 @@ cleanup: } static int -testStoragePoolUndefine(virStoragePoolPtr pool) { +testStoragePoolUndefine(virStoragePoolPtr pool) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; int ret = -1; @@ -4923,7 +4952,8 @@ cleanup: static int -testStoragePoolDestroy(virStoragePoolPtr pool) { +testStoragePoolDestroy(virStoragePoolPtr pool) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; int ret = -1; @@ -5030,7 +5060,8 @@ cleanup: static int testStoragePoolGetInfo(virStoragePoolPtr pool, - virStoragePoolInfoPtr info) { + virStoragePoolInfoPtr info) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; int ret = -1; @@ -5091,7 +5122,8 @@ cleanup: static int testStoragePoolGetAutostart(virStoragePoolPtr pool, - int *autostart) { + int *autostart) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; int ret = -1; @@ -5121,7 +5153,8 @@ cleanup: static int testStoragePoolSetAutostart(virStoragePoolPtr pool, - int autostart) { + int autostart) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; int ret = -1; @@ -5154,7 +5187,8 @@ cleanup: static int -testStoragePoolNumOfVolumes(virStoragePoolPtr pool) { +testStoragePoolNumOfVolumes(virStoragePoolPtr pool) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; int ret = -1; @@ -5186,7 +5220,8 @@ cleanup: static int testStoragePoolListVolumes(virStoragePoolPtr pool, char **const names, - int maxnames) { + int maxnames) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; size_t i = 0; @@ -5232,7 +5267,8 @@ testStoragePoolListVolumes(virStoragePoolPtr pool, static int testStoragePoolListAllVolumes(virStoragePoolPtr obj, virStorageVolPtr **vols, - unsigned int flags) { + unsigned int flags) +{ testConnPtr privconn = obj->conn->privateData; virStoragePoolObjPtr pool; size_t i; @@ -5298,7 +5334,8 @@ testStoragePoolListAllVolumes(virStoragePoolPtr obj, static virStorageVolPtr testStorageVolLookupByName(virStoragePoolPtr pool, - const char *name ATTRIBUTE_UNUSED) { + const char *name ATTRIBUTE_UNUSED) +{ testConnPtr privconn = pool->conn->privateData; virStoragePoolObjPtr privpool; virStorageVolDefPtr privvol; @@ -5342,7 +5379,8 @@ cleanup: static virStorageVolPtr testStorageVolLookupByKey(virConnectPtr conn, - const char *key) { + const char *key) +{ testConnPtr privconn = conn->privateData; size_t i; virStorageVolPtr ret = NULL; @@ -5377,7 +5415,8 @@ testStorageVolLookupByKey(virConnectPtr conn, static virStorageVolPtr testStorageVolLookupByPath(virConnectPtr conn, - const char *path) { + const char *path) +{ testConnPtr privconn = conn->privateData; size_t i; virStorageVolPtr ret = NULL; @@ -5627,7 +5666,8 @@ cleanup: } -static int testStorageVolumeTypeForPool(int pooltype) { +static int testStorageVolumeTypeForPool(int pooltype) +{ switch (pooltype) { case VIR_STORAGE_POOL_DIR: @@ -5641,7 +5681,8 @@ static int testStorageVolumeTypeForPool(int pooltype) { static int testStorageVolGetInfo(virStorageVolPtr vol, - virStorageVolInfoPtr info) { + virStorageVolInfoPtr info) +{ testConnPtr privconn = vol->conn->privateData; virStoragePoolObjPtr privpool; virStorageVolDefPtr privvol; @@ -5729,7 +5770,8 @@ cleanup: } static char * -testStorageVolGetPath(virStorageVolPtr vol) { +testStorageVolGetPath(virStorageVolPtr vol) +{ testConnPtr privconn = vol->conn->privateData; virStoragePoolObjPtr privpool; virStorageVolDefPtr privvol; @@ -5783,7 +5825,8 @@ static virDrvOpenStatus testNodeDeviceOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int testNodeDeviceClose(virConnectPtr conn) { +static int testNodeDeviceClose(virConnectPtr conn) +{ conn->nodeDevicePrivateData = NULL; return 0; } @@ -6252,7 +6295,8 @@ static virDrvOpenStatus testSecretOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int testSecretClose(virConnectPtr conn) { +static int testSecretClose(virConnectPtr conn) +{ conn->secretPrivateData = NULL; return 0; } @@ -6271,7 +6315,8 @@ static virDrvOpenStatus testNWFilterOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int testNWFilterClose(virConnectPtr conn) { +static int testNWFilterClose(virConnectPtr conn) +{ conn->nwfilterPrivateData = NULL; return 0; } -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:50PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/test/test_driver.c | 135 ++++++++++++++++++++++++++++++++----------------- 1 file changed, 90 insertions(+), 45 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/uml/uml_conf.c | 5 ++-- src/uml/uml_driver.c | 78 ++++++++++++++++++++++++++++++++++------------------ 2 files changed, 55 insertions(+), 28 deletions(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index 3567b03..53a880f 100644 --- a/src/uml/uml_conf.c +++ b/src/uml/uml_conf.c @@ -1,7 +1,7 @@ /* * uml_conf.c: UML driver configuration * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -52,7 +52,8 @@ VIR_LOG_INIT("uml.uml_conf"); -virCapsPtr umlCapsInit(void) { +virCapsPtr umlCapsInit(void) +{ virCapsPtr caps; virCapsGuestPtr guest; diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 28e65f4..f5eb05f 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -209,7 +209,8 @@ umlAutostartDomain(virDomainObjPtr vm, } static void -umlAutostartConfigs(struct uml_driver *driver) { +umlAutostartConfigs(struct uml_driver *driver) +{ /* XXX: Figure out a better way todo this. The domain * startup code needs a connection handle in order * to lookup the bridge associated with a virtual @@ -622,7 +623,8 @@ static void umlNotifyLoadDomain(virDomainObjPtr vm, int newVM, void *opaque) * files and update its state and the networking */ static int -umlStateReload(void) { +umlStateReload(void) +{ if (!uml_driver) return 0; @@ -660,7 +662,8 @@ umlShutdownOneVM(virDomainObjPtr dom, void *opaque) * Shutdown the Uml daemon, it will stop all active domains and networks */ static int -umlStateCleanup(void) { +umlStateCleanup(void) +{ if (!uml_driver) return -1; @@ -859,7 +862,8 @@ static int umlMonitorAddress(const struct uml_driver *driver, } static int umlOpenMonitor(struct uml_driver *driver, - virDomainObjPtr vm) { + virDomainObjPtr vm) +{ struct sockaddr_un addr; struct stat sb; int retries = 0; @@ -1007,7 +1011,8 @@ error: } -static void umlCleanupTapDevices(virDomainObjPtr vm) { +static void umlCleanupTapDevices(virDomainObjPtr vm) +{ size_t i; for (i = 0; i < vm->def->nnets; i++) { @@ -1024,7 +1029,8 @@ static void umlCleanupTapDevices(virDomainObjPtr vm) { static int umlStartVMDaemon(virConnectPtr conn, struct uml_driver *driver, virDomainObjPtr vm, - bool autoDestroy) { + bool autoDestroy) +{ int ret = -1; char *logfile; int logfd = -1; @@ -1245,7 +1251,8 @@ static virDrvOpenStatus umlConnectOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int umlConnectClose(virConnectPtr conn) { +static int umlConnectClose(virConnectPtr conn) +{ struct uml_driver *driver = conn->privateData; umlDriverLock(driver); @@ -1343,7 +1350,8 @@ static int umlGetProcessInfo(unsigned long long *cpuTime, pid_t pid) static virDomainPtr umlDomainLookupByID(virConnectPtr conn, - int id) { + int id) +{ struct uml_driver *driver = (struct uml_driver *)conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -1370,7 +1378,8 @@ cleanup: } static virDomainPtr umlDomainLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ struct uml_driver *driver = (struct uml_driver *)conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -1397,7 +1406,8 @@ cleanup: } static virDomainPtr umlDomainLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ struct uml_driver *driver = (struct uml_driver *)conn->privateData; virDomainObjPtr vm; virDomainPtr dom = NULL; @@ -1500,7 +1510,8 @@ cleanup: return ret; } -static int umlConnectGetVersion(virConnectPtr conn, unsigned long *version) { +static int umlConnectGetVersion(virConnectPtr conn, unsigned long *version) +{ struct uml_driver *driver = conn->privateData; struct utsname ut; int ret = -1; @@ -1538,7 +1549,8 @@ static char *umlConnectGetHostname(virConnectPtr conn) } -static int umlConnectListDomains(virConnectPtr conn, int *ids, int nids) { +static int umlConnectListDomains(virConnectPtr conn, int *ids, int nids) +{ struct uml_driver *driver = conn->privateData; int n; @@ -1552,7 +1564,8 @@ static int umlConnectListDomains(virConnectPtr conn, int *ids, int nids) { return n; } -static int umlConnectNumOfDomains(virConnectPtr conn) { +static int umlConnectNumOfDomains(virConnectPtr conn) +{ struct uml_driver *driver = conn->privateData; int n; @@ -1567,7 +1580,8 @@ static int umlConnectNumOfDomains(virConnectPtr conn) { return n; } static virDomainPtr umlDomainCreateXML(virConnectPtr conn, const char *xml, - unsigned int flags) { + unsigned int flags) +{ struct uml_driver *driver = conn->privateData; virDomainDefPtr def; virDomainObjPtr vm = NULL; @@ -1622,7 +1636,8 @@ cleanup: static int umlDomainShutdownFlags(virDomainPtr dom, - unsigned int flags) { + unsigned int flags) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; char *info = NULL; @@ -1772,7 +1787,8 @@ cleanup: return ret; } -static int umlDomainSetMaxMemory(virDomainPtr dom, unsigned long newmax) { +static int umlDomainSetMaxMemory(virDomainPtr dom, unsigned long newmax) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -1808,7 +1824,8 @@ cleanup: return ret; } -static int umlDomainSetMemory(virDomainPtr dom, unsigned long newmem) { +static int umlDomainSetMemory(virDomainPtr dom, unsigned long newmem) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -1851,7 +1868,8 @@ cleanup: } static int umlDomainGetInfo(virDomainPtr dom, - virDomainInfoPtr info) { + virDomainInfoPtr info) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -1977,7 +1995,8 @@ static int umlConnectListDefinedDomains(virConnectPtr conn, return n; } -static int umlConnectNumOfDefinedDomains(virConnectPtr conn) { +static int umlConnectNumOfDefinedDomains(virConnectPtr conn) +{ struct uml_driver *driver = conn->privateData; int n; @@ -1993,7 +2012,8 @@ static int umlConnectNumOfDefinedDomains(virConnectPtr conn) { } -static int umlDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) { +static int umlDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; virObjectEventPtr event = NULL; @@ -2032,11 +2052,13 @@ cleanup: return ret; } -static int umlDomainCreate(virDomainPtr dom) { +static int umlDomainCreate(virDomainPtr dom) +{ return umlDomainCreateWithFlags(dom, 0); } -static virDomainPtr umlDomainDefineXML(virConnectPtr conn, const char *xml) { +static virDomainPtr umlDomainDefineXML(virConnectPtr conn, const char *xml) +{ struct uml_driver *driver = conn->privateData; virDomainDefPtr def; virDomainObjPtr vm = NULL; @@ -2297,7 +2319,8 @@ cleanup: } -static int umlDomainDetachDevice(virDomainPtr dom, const char *xml) { +static int umlDomainDetachDevice(virDomainPtr dom, const char *xml) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; virDomainDeviceDefPtr dev = NULL; @@ -2367,7 +2390,8 @@ umlDomainDetachDeviceFlags(virDomainPtr dom, static int umlDomainGetAutostart(virDomainPtr dom, - int *autostart) { + int *autostart) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; @@ -2395,7 +2419,8 @@ cleanup: } static int umlDomainSetAutostart(virDomainPtr dom, - int autostart) { + int autostart) +{ struct uml_driver *driver = dom->conn->privateData; virDomainObjPtr vm; char *configFile = NULL, *autostartLink = NULL; @@ -2910,7 +2935,8 @@ static virStateDriver umlStateDriver = { .stateReload = umlStateReload, }; -int umlRegister(void) { +int umlRegister(void) +{ if (virRegisterDriver(¨Driver) < 0) return -1; if (virRegisterStateDriver(¨StateDriver) < 0) -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:51PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/uml/uml_conf.c | 5 ++-- src/uml/uml_driver.c | 78 ++++++++++++++++++++++++++++++++++------------------ 2 files changed, 55 insertions(+), 28 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/lxc/lxc_driver.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 1ae04c5..3104bf9 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -384,7 +384,8 @@ cleanup: return ret; } -static int lxcConnectListDomains(virConnectPtr conn, int *ids, int nids) { +static int lxcConnectListDomains(virConnectPtr conn, int *ids, int nids) +{ virLXCDriverPtr driver = conn->privateData; int n; @@ -397,7 +398,8 @@ static int lxcConnectListDomains(virConnectPtr conn, int *ids, int nids) { return n; } -static int lxcConnectNumOfDomains(virConnectPtr conn) { +static int lxcConnectNumOfDomains(virConnectPtr conn) +{ virLXCDriverPtr driver = conn->privateData; int n; @@ -411,7 +413,8 @@ static int lxcConnectNumOfDomains(virConnectPtr conn) { } static int lxcConnectListDefinedDomains(virConnectPtr conn, - char **const names, int nnames) { + char **const names, int nnames) +{ virLXCDriverPtr driver = conn->privateData; int n; @@ -425,7 +428,8 @@ static int lxcConnectListDefinedDomains(virConnectPtr conn, } -static int lxcConnectNumOfDefinedDomains(virConnectPtr conn) { +static int lxcConnectNumOfDefinedDomains(virConnectPtr conn) +{ virLXCDriverPtr driver = conn->privateData; int n; @@ -677,7 +681,8 @@ cleanup: return ret; } -static int lxcDomainSetMaxMemory(virDomainPtr dom, unsigned long newmax) { +static int lxcDomainSetMaxMemory(virDomainPtr dom, unsigned long newmax) +{ virDomainObjPtr vm; int ret = -1; @@ -702,7 +707,8 @@ cleanup: return ret; } -static int lxcDomainSetMemory(virDomainPtr dom, unsigned long newmem) { +static int lxcDomainSetMemory(virDomainPtr dom, unsigned long newmem) +{ virDomainObjPtr vm; int ret = -1; virLXCDomainObjPrivatePtr priv; @@ -1130,7 +1136,8 @@ lxcDomainCreateXMLWithFiles(virConnectPtr conn, const char *xml, unsigned int nfiles, int *files, - unsigned int flags) { + unsigned int flags) +{ virLXCDriverPtr driver = conn->privateData; virDomainObjPtr vm = NULL; virDomainDefPtr def = NULL; @@ -1206,7 +1213,8 @@ cleanup: static virDomainPtr lxcDomainCreateXML(virConnectPtr conn, const char *xml, - unsigned int flags) { + unsigned int flags) +{ return lxcDomainCreateXMLWithFiles(conn, xml, 0, NULL, flags); } @@ -1639,7 +1647,8 @@ static void lxcNotifyLoadDomain(virDomainObjPtr vm, int newVM, void *opaque) * files and perform autostart */ static int -lxcStateReload(void) { +lxcStateReload(void) +{ virLXCDriverConfigPtr cfg = NULL; virCapsPtr caps = NULL; @@ -3102,7 +3111,8 @@ lxcDomainInterfaceStats(virDomainPtr dom, #endif static int lxcDomainGetAutostart(virDomainPtr dom, - int *autostart) { + int *autostart) +{ virDomainObjPtr vm; int ret = -1; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:52PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/lxc/lxc_driver.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/network/bridge_driver.c | 54 ++++++++++++++++++++++++++++++--------------- 1 file changed, 36 insertions(+), 18 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 59b6c09..20930f3 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -380,7 +380,8 @@ networkFindActiveConfigs(virNetworkDriverStatePtr driver) static void -networkAutostartConfigs(virNetworkDriverStatePtr driver) { +networkAutostartConfigs(virNetworkDriverStatePtr driver) +{ size_t i; for (i = 0; i < driver->networks.count; i++) { @@ -398,7 +399,8 @@ networkAutostartConfigs(virNetworkDriverStatePtr driver) { #if HAVE_FIREWALLD static DBusHandlerResult firewalld_dbus_filter_bridge(DBusConnection *connection ATTRIBUTE_UNUSED, - DBusMessage *message, void *user_data) { + DBusMessage *message, void *user_data) +{ virNetworkDriverStatePtr _driverState = user_data; if (dbus_message_is_signal(message, DBUS_INTERFACE_DBUS, @@ -567,7 +569,8 @@ networkStateAutoStart(void) * files and update its state and the networking */ static int -networkStateReload(void) { +networkStateReload(void) +{ if (!driverState) return 0; @@ -591,7 +594,8 @@ networkStateReload(void) { * Shutdown the QEmu daemon, it will stop all active domains and networks */ static int -networkStateCleanup(void) { +networkStateCleanup(void) +{ if (!driverState) return -1; @@ -2173,7 +2177,8 @@ static int networkShutdownNetwork(virNetworkDriverStatePtr driver, static virNetworkPtr networkLookupByUUID(virConnectPtr conn, - const unsigned char *uuid) { + const unsigned char *uuid) +{ virNetworkDriverStatePtr driver = conn->networkPrivateData; virNetworkObjPtr network; virNetworkPtr ret = NULL; @@ -2199,7 +2204,8 @@ cleanup: } static virNetworkPtr networkLookupByName(virConnectPtr conn, - const char *name) { + const char *name) +{ virNetworkDriverStatePtr driver = conn->networkPrivateData; virNetworkObjPtr network; virNetworkPtr ret = NULL; @@ -2237,12 +2243,14 @@ static virDrvOpenStatus networkOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int networkClose(virConnectPtr conn) { +static int networkClose(virConnectPtr conn) +{ conn->networkPrivateData = NULL; return 0; } -static int networkConnectNumOfNetworks(virConnectPtr conn) { +static int networkConnectNumOfNetworks(virConnectPtr conn) +{ int nactive = 0; size_t i; virNetworkDriverStatePtr driver = conn->networkPrivateData; @@ -2297,7 +2305,8 @@ static int networkConnectListNetworks(virConnectPtr conn, char **const names, in return -1; } -static int networkConnectNumOfDefinedNetworks(virConnectPtr conn) { +static int networkConnectNumOfDefinedNetworks(virConnectPtr conn) +{ int ninactive = 0; size_t i; virNetworkDriverStatePtr driver = conn->networkPrivateData; @@ -2623,7 +2632,8 @@ networkValidate(virNetworkDriverStatePtr driver, return 0; } -static virNetworkPtr networkCreateXML(virConnectPtr conn, const char *xml) { +static virNetworkPtr networkCreateXML(virConnectPtr conn, const char *xml) +{ virNetworkDriverStatePtr driver = conn->networkPrivateData; virNetworkDefPtr def; virNetworkObjPtr network = NULL; @@ -2673,7 +2683,8 @@ cleanup: return ret; } -static virNetworkPtr networkDefineXML(virConnectPtr conn, const char *xml) { +static virNetworkPtr networkDefineXML(virConnectPtr conn, const char *xml) +{ virNetworkDriverStatePtr driver = conn->networkPrivateData; virNetworkDefPtr def = NULL; bool freeDef = true; @@ -2738,7 +2749,8 @@ cleanup: } static int -networkUndefine(virNetworkPtr net) { +networkUndefine(virNetworkPtr net) +{ virNetworkDriverStatePtr driver = net->conn->networkPrivateData; virNetworkObjPtr network; int ret = -1; @@ -2969,7 +2981,8 @@ cleanup: return ret; } -static int networkCreate(virNetworkPtr net) { +static int networkCreate(virNetworkPtr net) +{ virNetworkDriverStatePtr driver = net->conn->networkPrivateData; virNetworkObjPtr network; int ret = -1; @@ -3003,7 +3016,8 @@ cleanup: return ret; } -static int networkDestroy(virNetworkPtr net) { +static int networkDestroy(virNetworkPtr net) +{ virNetworkDriverStatePtr driver = net->conn->networkPrivateData; virNetworkObjPtr network; int ret = -1; @@ -3107,7 +3121,8 @@ cleanup: } static int networkGetAutostart(virNetworkPtr net, - int *autostart) { + int *autostart) +{ virNetworkObjPtr network; int ret = -1; @@ -3127,7 +3142,8 @@ cleanup: } static int networkSetAutostart(virNetworkPtr net, - int autostart) { + int autostart) +{ virNetworkDriverStatePtr driver = net->conn->networkPrivateData; virNetworkObjPtr network; char *configFile = NULL, *autostartLink = NULL; @@ -3231,7 +3247,8 @@ static virStateDriver networkStateDriver = { .stateReload = networkStateReload, }; -int networkRegister(void) { +int networkRegister(void) +{ if (virRegisterNetworkDriver(&networkDriver) < 0) return -1; if (virRegisterStateDriver(&networkStateDriver) < 0) @@ -3255,7 +3272,8 @@ int networkRegister(void) { * Creates an implicit interface pool of VF's when a PF dev is given */ static int -networkCreateInterfacePool(virNetworkDefPtr netdef) { +networkCreateInterfacePool(virNetworkDefPtr netdef) +{ size_t num_virt_fns = 0; char **vfname = NULL; virPCIDeviceAddressPtr *virt_fns; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:53PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/network/bridge_driver.c | 54 ++++++++++++++++++++++++++++++--------------- 1 file changed, 36 insertions(+), 18 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/vbox/vbox_driver.c | 5 +- src/vbox/vbox_tmpl.c | 188 +++++++++++++++++++++++++++++++++---------------- 2 files changed, 132 insertions(+), 61 deletions(-) diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c index e26b10a..7d004b2 100644 --- a/src/vbox/vbox_driver.c +++ b/src/vbox/vbox_driver.c @@ -3,7 +3,7 @@ */ /* - * Copyright (C) 2010-2013 Red Hat, Inc. + * Copyright (C) 2010-2014 Red Hat, Inc. * Copyright (C) 2008-2009 Sun Microsystems, Inc. * * This file is part of a free software library; you can redistribute @@ -79,7 +79,8 @@ static virDriver vboxDriverDummy; #define VIR_FROM_THIS VIR_FROM_VBOX -int vboxRegister(void) { +int vboxRegister(void) +{ virDriverPtr driver; virNetworkDriverPtr networkDriver; virStorageDriverPtr storageDriver; diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 2aeddd0..56b3ac6 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -284,17 +284,20 @@ static virDomainPtr vboxDomainDefineXML(virConnectPtr conn, const char *xml); static int vboxDomainCreate(virDomainPtr dom); static int vboxDomainUndefineFlags(virDomainPtr dom, unsigned int flags); -static void vboxDriverLock(vboxGlobalData *data) { +static void vboxDriverLock(vboxGlobalData *data) +{ virMutexLock(&data->lock); } -static void vboxDriverUnlock(vboxGlobalData *data) { +static void vboxDriverUnlock(vboxGlobalData *data) +{ virMutexUnlock(&data->lock); } #if VBOX_API_VERSION == 2002000 -static void nsIDtoChar(unsigned char *uuid, const nsID *iid) { +static void nsIDtoChar(unsigned char *uuid, const nsID *iid) +{ char uuidstrsrc[VIR_UUID_STRING_BUFLEN]; char uuidstrdst[VIR_UUID_STRING_BUFLEN]; unsigned char uuidinterim[VIR_UUID_BUFLEN]; @@ -334,7 +337,8 @@ static void nsIDtoChar(unsigned char *uuid, const nsID *iid) { ignore_value(virUUIDParse(uuidstrdst, uuid)); } -static void nsIDFromChar(nsID *iid, const unsigned char *uuid) { +static void nsIDFromChar(nsID *iid, const unsigned char *uuid) +{ char uuidstrsrc[VIR_UUID_STRING_BUFLEN]; char uuidstrdst[VIR_UUID_STRING_BUFLEN]; unsigned char uuidinterim[VIR_UUID_BUFLEN]; @@ -621,7 +625,8 @@ static char *vboxGenerateMediumName(PRUint32 storageBus, PRInt32 devicePort, PRInt32 deviceSlot, PRUint32 *aMaxPortPerInst, - PRUint32 *aMaxSlotPerPort) { + PRUint32 *aMaxSlotPerPort) +{ const char *prefix = NULL; char *name = NULL; int total = 0; @@ -734,7 +739,8 @@ static bool vboxGetDeviceDetails(const char *deviceName, static bool vboxGetMaxPortSlotValues(IVirtualBox *vbox, PRUint32 *maxPortPerInst, - PRUint32 *maxSlotPerPort) { + PRUint32 *maxSlotPerPort) +{ ISystemProperties *sysProps = NULL; if (!vbox) @@ -779,7 +785,8 @@ static bool vboxGetMaxPortSlotValues(IVirtualBox *vbox, /** * Converts Utf-16 string to int */ -static int PRUnicharToInt(PRUnichar *strUtf16) { +static int PRUnicharToInt(PRUnichar *strUtf16) +{ char *strUtf8 = NULL; int ret = 0; @@ -957,7 +964,8 @@ cleanup: return -1; } -static int vboxExtractVersion(vboxGlobalData *data) { +static int vboxExtractVersion(vboxGlobalData *data) +{ int ret = -1; PRUnichar *versionUtf16 = NULL; nsresult rc; @@ -985,7 +993,8 @@ static int vboxExtractVersion(vboxGlobalData *data) { return ret; } -static void vboxUninitialize(vboxGlobalData *data) { +static void vboxUninitialize(vboxGlobalData *data) +{ if (!data) return; @@ -1078,7 +1087,8 @@ static virDrvOpenStatus vboxConnectOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int vboxConnectClose(virConnectPtr conn) { +static int vboxConnectClose(virConnectPtr conn) +{ vboxGlobalData *data = conn->privateData; VIR_DEBUG("%s: in vboxClose", conn->driver->name); @@ -1088,7 +1098,8 @@ static int vboxConnectClose(virConnectPtr conn) { return 0; } -static int vboxConnectGetVersion(virConnectPtr conn, unsigned long *version) { +static int vboxConnectGetVersion(virConnectPtr conn, unsigned long *version) +{ vboxGlobalData *data = conn->privateData; VIR_DEBUG("%s: in vboxGetVersion", conn->driver->name); @@ -1106,12 +1117,14 @@ static char *vboxConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) } -static int vboxConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) { +static int vboxConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) +{ /* Driver is using local, non-network based transport */ return 1; } -static int vboxConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) { +static int vboxConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) +{ /* No encryption is needed, or used on the local transport*/ return 0; } @@ -1121,7 +1134,9 @@ static int vboxConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED) return 1; } -static int vboxConnectGetMaxVcpus(virConnectPtr conn, const char *type ATTRIBUTE_UNUSED) { +static int +vboxConnectGetMaxVcpus(virConnectPtr conn, const char *type ATTRIBUTE_UNUSED) +{ VBOX_OBJECT_CHECK(conn, int, -1); PRUint32 maxCPUCount = 0; @@ -1153,7 +1168,8 @@ static char *vboxConnectGetCapabilities(virConnectPtr conn) { return ret; } -static int vboxConnectListDomains(virConnectPtr conn, int *ids, int nids) { +static int vboxConnectListDomains(virConnectPtr conn, int *ids, int nids) +{ VBOX_OBJECT_CHECK(conn, int, -1); vboxArray machines = VBOX_ARRAY_INITIALIZER; PRUint32 state; @@ -1191,7 +1207,8 @@ cleanup: return ret; } -static int vboxConnectNumOfDomains(virConnectPtr conn) { +static int vboxConnectNumOfDomains(virConnectPtr conn) +{ VBOX_OBJECT_CHECK(conn, int, -1); vboxArray machines = VBOX_ARRAY_INITIALIZER; PRUint32 state; @@ -1227,7 +1244,8 @@ cleanup: } static virDomainPtr vboxDomainCreateXML(virConnectPtr conn, const char *xml, - unsigned int flags) { + unsigned int flags) +{ /* VirtualBox currently doesn't have support for running * virtual machines without actually defining them and thus * for time being just define new machine and start it. @@ -1253,7 +1271,8 @@ static virDomainPtr vboxDomainCreateXML(virConnectPtr conn, const char *xml, return dom; } -static virDomainPtr vboxDomainLookupByID(virConnectPtr conn, int id) { +static virDomainPtr vboxDomainLookupByID(virConnectPtr conn, int id) +{ VBOX_OBJECT_CHECK(conn, virDomainPtr, NULL); vboxArray machines = VBOX_ARRAY_INITIALIZER; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1320,7 +1339,9 @@ static virDomainPtr vboxDomainLookupByID(virConnectPtr conn, int id) { return ret; } -static virDomainPtr vboxDomainLookupByUUID(virConnectPtr conn, const unsigned char *uuid) { +static virDomainPtr +vboxDomainLookupByUUID(virConnectPtr conn, const unsigned char *uuid) +{ VBOX_OBJECT_CHECK(conn, virDomainPtr, NULL); vboxArray machines = VBOX_ARRAY_INITIALIZER; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1391,7 +1412,9 @@ static virDomainPtr vboxDomainLookupByUUID(virConnectPtr conn, const unsigned ch return ret; } -static virDomainPtr vboxDomainLookupByName(virConnectPtr conn, const char *name) { +static virDomainPtr +vboxDomainLookupByName(virConnectPtr conn, const char *name) +{ VBOX_OBJECT_CHECK(conn, virDomainPtr, NULL); vboxArray machines = VBOX_ARRAY_INITIALIZER; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1460,7 +1483,8 @@ static virDomainPtr vboxDomainLookupByName(virConnectPtr conn, const char *name) } -static int vboxDomainIsActive(virDomainPtr dom) { +static int vboxDomainIsActive(virDomainPtr dom) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); vboxArray machines = VBOX_ARRAY_INITIALIZER; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1552,7 +1576,8 @@ cleanup: } -static int vboxDomainIsUpdated(virDomainPtr dom ATTRIBUTE_UNUSED) { +static int vboxDomainIsUpdated(virDomainPtr dom ATTRIBUTE_UNUSED) +{ /* VBox domains never have a persistent state that differs from * current state. However, we do want to check for existence. */ VBOX_OBJECT_CHECK(dom->conn, int, -1); @@ -1576,7 +1601,8 @@ cleanup: return ret; } -static int vboxDomainSuspend(virDomainPtr dom) { +static int vboxDomainSuspend(virDomainPtr dom) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IMachine *machine = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1627,7 +1653,8 @@ cleanup: return ret; } -static int vboxDomainResume(virDomainPtr dom) { +static int vboxDomainResume(virDomainPtr dom) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IMachine *machine = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1680,7 +1707,8 @@ cleanup: } static int vboxDomainShutdownFlags(virDomainPtr dom, - unsigned int flags) { + unsigned int flags) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IMachine *machine = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1732,7 +1760,8 @@ cleanup: return ret; } -static int vboxDomainShutdown(virDomainPtr dom) { +static int vboxDomainShutdown(virDomainPtr dom) +{ return vboxDomainShutdownFlags(dom, 0); } @@ -1866,7 +1895,8 @@ static char *vboxDomainGetOSType(virDomainPtr dom ATTRIBUTE_UNUSED) { return osType; } -static int vboxDomainSetMemory(virDomainPtr dom, unsigned long memory) { +static int vboxDomainSetMemory(virDomainPtr dom, unsigned long memory) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IMachine *machine = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -1922,7 +1952,8 @@ cleanup: return ret; } -static virDomainState vboxConvertState(enum MachineState state) { +static virDomainState vboxConvertState(enum MachineState state) +{ switch (state) { case MachineState_Running: return VIR_DOMAIN_RUNNING; @@ -1943,7 +1974,8 @@ static virDomainState vboxConvertState(enum MachineState state) { } } -static int vboxDomainGetInfo(virDomainPtr dom, virDomainInfoPtr info) { +static int vboxDomainGetInfo(virDomainPtr dom, virDomainInfoPtr info) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); vboxArray machines = VBOX_ARRAY_INITIALIZER; char *machineName = NULL; @@ -2058,7 +2090,8 @@ cleanup: return ret; } -static int vboxDomainSave(virDomainPtr dom, const char *path ATTRIBUTE_UNUSED) { +static int vboxDomainSave(virDomainPtr dom, const char *path ATTRIBUTE_UNUSED) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IConsole *console = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -3510,7 +3543,8 @@ cleanup: return ret; } -static int vboxConnectNumOfDefinedDomains(virConnectPtr conn) { +static int vboxConnectNumOfDefinedDomains(virConnectPtr conn) +{ VBOX_OBJECT_CHECK(conn, int, -1); vboxArray machines = VBOX_ARRAY_INITIALIZER; PRUint32 state = MachineState_Null; @@ -3711,7 +3745,8 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine, return ret; } -static int vboxDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) { +static int vboxDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); vboxArray machines = VBOX_ARRAY_INITIALIZER; unsigned char uuid[VIR_UUID_BUFLEN] = {0}; @@ -3778,7 +3813,8 @@ cleanup: return ret; } -static int vboxDomainCreate(virDomainPtr dom) { +static int vboxDomainCreate(virDomainPtr dom) +{ return vboxDomainCreateWithFlags(dom, 0); } @@ -5064,7 +5100,8 @@ vboxAttachSharedFolder(virDomainDefPtr def, vboxGlobalData *data, IMachine *mach } } -static virDomainPtr vboxDomainDefineXML(virConnectPtr conn, const char *xml) { +static virDomainPtr vboxDomainDefineXML(virConnectPtr conn, const char *xml) +{ VBOX_OBJECT_CHECK(conn, virDomainPtr, NULL); IMachine *machine = NULL; IBIOSSettings *bios = NULL; @@ -5438,7 +5475,8 @@ vboxDomainUndefine(virDomainPtr dom) static int vboxDomainAttachDeviceImpl(virDomainPtr dom, const char *xml, - int mediaChangeOnly ATTRIBUTE_UNUSED) { + int mediaChangeOnly ATTRIBUTE_UNUSED) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IMachine *machine = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -5633,7 +5671,8 @@ cleanup: return ret; } -static int vboxDomainAttachDevice(virDomainPtr dom, const char *xml) { +static int vboxDomainAttachDevice(virDomainPtr dom, const char *xml) +{ return vboxDomainAttachDeviceImpl(dom, xml, 0); } @@ -5653,7 +5692,8 @@ vboxDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, } static int vboxDomainUpdateDeviceFlags(virDomainPtr dom, const char *xml, - unsigned int flags) { + unsigned int flags) +{ virCheckFlags(VIR_DOMAIN_AFFECT_CURRENT | VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG, -1); @@ -5667,7 +5707,8 @@ static int vboxDomainUpdateDeviceFlags(virDomainPtr dom, const char *xml, return vboxDomainAttachDeviceImpl(dom, xml, 1); } -static int vboxDomainDetachDevice(virDomainPtr dom, const char *xml) { +static int vboxDomainDetachDevice(virDomainPtr dom, const char *xml) +{ VBOX_OBJECT_CHECK(dom->conn, int, -1); IMachine *machine = NULL; vboxIID iid = VBOX_IID_INITIALIZER; @@ -7284,7 +7325,8 @@ static IVirtualBoxCallback *vboxAllocCallbackObj(void) { static void vboxReadCallback(int watch ATTRIBUTE_UNUSED, int fd, int events ATTRIBUTE_UNUSED, - void *opaque ATTRIBUTE_UNUSED) { + void *opaque ATTRIBUTE_UNUSED) +{ if (fd >= 0) { g_pVBoxGlobalData->vboxQueue->vtbl->ProcessPendingEvents(g_pVBoxGlobalData->vboxQueue); } else { @@ -7399,7 +7441,8 @@ static int vboxConnectDomainEventRegisterAny(virConnectPtr conn, int eventID, virConnectDomainEventGenericCallback callback, void *opaque, - virFreeCallback freecb) { + virFreeCallback freecb) +{ VBOX_OBJECT_CHECK(conn, int, -1); int vboxRet = -1; nsresult rc; @@ -7522,13 +7565,15 @@ cleanup: return VIR_DRV_OPEN_DECLINED; } -static int vboxNetworkClose(virConnectPtr conn) { +static int vboxNetworkClose(virConnectPtr conn) +{ VIR_DEBUG("network uninitialized"); conn->networkPrivateData = NULL; return 0; } -static int vboxConnectNumOfNetworks(virConnectPtr conn) { +static int vboxConnectNumOfNetworks(virConnectPtr conn) +{ VBOX_OBJECT_HOST_CHECK(conn, int, 0); vboxArray networkInterfaces = VBOX_ARRAY_INITIALIZER; size_t i = 0; @@ -7606,7 +7651,8 @@ static int vboxConnectListNetworks(virConnectPtr conn, char **const names, int n return ret; } -static int vboxConnectNumOfDefinedNetworks(virConnectPtr conn) { +static int vboxConnectNumOfDefinedNetworks(virConnectPtr conn) +{ VBOX_OBJECT_HOST_CHECK(conn, int, 0); vboxArray networkInterfaces = VBOX_ARRAY_INITIALIZER; size_t i = 0; @@ -7728,7 +7774,9 @@ vboxNetworkLookupByUUID(virConnectPtr conn, const unsigned char *uuid) return ret; } -static virNetworkPtr vboxNetworkLookupByName(virConnectPtr conn, const char *name) { +static virNetworkPtr +vboxNetworkLookupByName(virConnectPtr conn, const char *name) +{ VBOX_OBJECT_HOST_CHECK(conn, virNetworkPtr, NULL); PRUnichar *nameUtf16 = NULL; IHostNetworkInterface *networkInterface = NULL; @@ -7764,7 +7812,9 @@ static virNetworkPtr vboxNetworkLookupByName(virConnectPtr conn, const char *nam return ret; } -static virNetworkPtr vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start) { +static virNetworkPtr +vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start) +{ VBOX_OBJECT_HOST_CHECK(conn, virNetworkPtr, NULL); PRUnichar *networkInterfaceNameUtf16 = NULL; char *networkInterfaceNameUtf8 = NULL; @@ -7970,15 +8020,19 @@ cleanup: return ret; } -static virNetworkPtr vboxNetworkCreateXML(virConnectPtr conn, const char *xml) { +static virNetworkPtr vboxNetworkCreateXML(virConnectPtr conn, const char *xml) +{ return vboxNetworkDefineCreateXML(conn, xml, true); } -static virNetworkPtr vboxNetworkDefineXML(virConnectPtr conn, const char *xml) { +static virNetworkPtr vboxNetworkDefineXML(virConnectPtr conn, const char *xml) +{ return vboxNetworkDefineCreateXML(conn, xml, false); } -static int vboxNetworkUndefineDestroy(virNetworkPtr network, bool removeinterface) { +static int +vboxNetworkUndefineDestroy(virNetworkPtr network, bool removeinterface) +{ VBOX_OBJECT_HOST_CHECK(network->conn, int, -1); char *networkNameUtf8 = NULL; PRUnichar *networkInterfaceNameUtf16 = NULL; @@ -8062,11 +8116,13 @@ cleanup: return ret; } -static int vboxNetworkUndefine(virNetworkPtr network) { +static int vboxNetworkUndefine(virNetworkPtr network) +{ return vboxNetworkUndefineDestroy(network, true); } -static int vboxNetworkCreate(virNetworkPtr network) { +static int vboxNetworkCreate(virNetworkPtr network) +{ VBOX_OBJECT_HOST_CHECK(network->conn, int, -1); char *networkNameUtf8 = NULL; PRUnichar *networkInterfaceNameUtf16 = NULL; @@ -8133,7 +8189,8 @@ cleanup: return ret; } -static int vboxNetworkDestroy(virNetworkPtr network) { +static int vboxNetworkDestroy(virNetworkPtr network) +{ return vboxNetworkUndefineDestroy(network, false); } @@ -8323,13 +8380,15 @@ static virDrvOpenStatus vboxStorageOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } -static int vboxStorageClose(virConnectPtr conn) { +static int vboxStorageClose(virConnectPtr conn) +{ VIR_DEBUG("vbox storage uninitialized"); conn->storagePrivateData = NULL; return 0; } -static int vboxConnectNumOfStoragePools(virConnectPtr conn ATTRIBUTE_UNUSED) { +static int vboxConnectNumOfStoragePools(virConnectPtr conn ATTRIBUTE_UNUSED) +{ /** Currently only one pool supported, the default one * given by ISystemProperties::defaultHardDiskFolder() @@ -8348,7 +8407,9 @@ static int vboxConnectListStoragePools(virConnectPtr conn ATTRIBUTE_UNUSED, return numActive; } -static virStoragePoolPtr vboxStoragePoolLookupByName(virConnectPtr conn, const char *name) { +static virStoragePoolPtr +vboxStoragePoolLookupByName(virConnectPtr conn, const char *name) +{ virStoragePoolPtr ret = NULL; /** Current limitation of the function: since @@ -8367,7 +8428,8 @@ static virStoragePoolPtr vboxStoragePoolLookupByName(virConnectPtr conn, const c return ret; } -static int vboxStoragePoolNumOfVolumes(virStoragePoolPtr pool) { +static int vboxStoragePoolNumOfVolumes(virStoragePoolPtr pool) +{ VBOX_OBJECT_CHECK(pool->conn, int, -1); vboxArray hardDisks = VBOX_ARRAY_INITIALIZER; PRUint32 hardDiskAccessible = 0; @@ -8448,7 +8510,9 @@ static int vboxStoragePoolListVolumes(virStoragePoolPtr pool, char **const names return ret; } -static virStorageVolPtr vboxStorageVolLookupByName(virStoragePoolPtr pool, const char *name) { +static virStorageVolPtr +vboxStorageVolLookupByName(virStoragePoolPtr pool, const char *name) +{ VBOX_OBJECT_CHECK(pool->conn, virStorageVolPtr, NULL); vboxArray hardDisks = VBOX_ARRAY_INITIALIZER; nsresult rc; @@ -8511,7 +8575,9 @@ static virStorageVolPtr vboxStorageVolLookupByName(virStoragePoolPtr pool, const return ret; } -static virStorageVolPtr vboxStorageVolLookupByKey(virConnectPtr conn, const char *key) { +static virStorageVolPtr +vboxStorageVolLookupByKey(virConnectPtr conn, const char *key) +{ VBOX_OBJECT_CHECK(conn, virStorageVolPtr, NULL); vboxIID hddIID = VBOX_IID_INITIALIZER; unsigned char uuid[VIR_UUID_BUFLEN]; @@ -8575,7 +8641,9 @@ static virStorageVolPtr vboxStorageVolLookupByKey(virConnectPtr conn, const char return ret; } -static virStorageVolPtr vboxStorageVolLookupByPath(virConnectPtr conn, const char *path) { +static virStorageVolPtr +vboxStorageVolLookupByPath(virConnectPtr conn, const char *path) +{ VBOX_OBJECT_CHECK(conn, virStorageVolPtr, NULL); PRUnichar *hddPathUtf16 = NULL; IHardDisk *hardDisk = NULL; @@ -8928,7 +8996,9 @@ static int vboxStorageVolDelete(virStorageVolPtr vol, return ret; } -static int vboxStorageVolGetInfo(virStorageVolPtr vol, virStorageVolInfoPtr info) { +static int +vboxStorageVolGetInfo(virStorageVolPtr vol, virStorageVolInfoPtr info) +{ VBOX_OBJECT_CHECK(vol->conn, int, -1); IHardDisk *hardDisk = NULL; unsigned char uuid[VIR_UUID_BUFLEN]; -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:54PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/vbox/vbox_driver.c | 5 +- src/vbox/vbox_tmpl.c | 188 +++++++++++++++++++++++++++++++++---------------- 2 files changed, 132 insertions(+), 61 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- daemon/libvirtd-config.c | 9 +++++++-- docs/internals/command.html.in | 3 ++- examples/dominfo/info1.c | 7 ++++--- src/interface/interface_backend_netcf.c | 8 +++++--- src/interface/interface_backend_udev.c | 4 +++- src/interface/interface_driver.c | 4 +++- src/libxl/libxl_driver.c | 3 ++- src/node_device/node_device_driver.c | 5 +++-- src/secret/secret_driver.c | 8 +++++--- src/security/security_stack.c | 8 +++++--- 10 files changed, 39 insertions(+), 20 deletions(-) diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c index cff2a7e..a146340 100644 --- a/daemon/libvirtd-config.c +++ b/daemon/libvirtd-config.c @@ -1,7 +1,7 @@ /* * libvirtd-config.c: daemon start of day, guest process & i/o management * - * Copyright (C) 2006-2012 Red Hat, Inc. + * Copyright (C) 2006-2012, 2014 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -158,7 +158,12 @@ checkType(virConfValuePtr p, const char *filename, } while (0) -static int remoteConfigGetAuth(virConfPtr conf, const char *key, int *auth, const char *filename) { +static int +remoteConfigGetAuth(virConfPtr conf, + const char *key, + int *auth, + const char *filename) +{ virConfValuePtr p; p = virConfGetValue(conf, key); diff --git a/docs/internals/command.html.in b/docs/internals/command.html.in index f5c28af..fc767d9 100644 --- a/docs/internals/command.html.in +++ b/docs/internals/command.html.in @@ -560,7 +560,8 @@ <pre> int runhook(const char *drvstr, const char *id, const char *opstr, const char *subopstr, - const char *extra) { + const char *extra) +{ int ret; char *path; virCommandPtr cmd; diff --git a/examples/dominfo/info1.c b/examples/dominfo/info1.c index 4d578bc..13c45ec 100644 --- a/examples/dominfo/info1.c +++ b/examples/dominfo/info1.c @@ -19,7 +19,8 @@ * extract the domain 0 information */ static void -getDomainInfo(int id) { +getDomainInfo(int id) +{ virConnectPtr conn = NULL; /* the hypervisor connection */ virDomainPtr dom = NULL; /* the domain being checked */ virDomainInfo info; /* the information being fetched */ @@ -55,8 +56,8 @@ error: virConnectClose(conn); } -int main() { - +int main() +{ getDomainInfo(0); return 0; diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index 0948418..666b5d4 100644 --- a/src/interface/interface_backend_netcf.c +++ b/src/interface/interface_backend_netcf.c @@ -2,7 +2,7 @@ * interface_backend_netcf.c: backend driver methods to handle physical * interface configuration using the netcf library. * - * Copyright (C) 2006-2013 Red Hat, Inc. + * Copyright (C) 2006-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -900,7 +900,8 @@ cleanup: return ret; } -static int netcfInterfaceUndefine(virInterfacePtr ifinfo) { +static int netcfInterfaceUndefine(virInterfacePtr ifinfo) +{ virNetcfDriverStatePtr driver = ifinfo->conn->interfacePrivateData; struct netcf_if *iface = NULL; virInterfaceDefPtr def = NULL; @@ -1190,7 +1191,8 @@ static virStateDriver interfaceStateDriver = { .stateReload = netcfStateReload, }; -int netcfIfaceRegister(void) { +int netcfIfaceRegister(void) +{ if (virRegisterInterfaceDriver(&interfaceDriver) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to register netcf interface driver")); diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index 75d5c48..37f42bb 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -1,6 +1,7 @@ /* * interface_backend_udev.c: udev backend for virInterface * + * Copyright (C) 2014 Red Hat, Inc. * Copyright (C) 2012 Doug Goldstein <cardoe@cardoe.com> * * This library is free software; you can redistribute it and/or @@ -1186,7 +1187,8 @@ static virInterfaceDriver udevIfaceDriver = { }; int -udevIfaceRegister(void) { +udevIfaceRegister(void) +{ if (virRegisterInterfaceDriver(&udevIfaceDriver) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to register udev interface driver")); diff --git a/src/interface/interface_driver.c b/src/interface/interface_driver.c index 5668a3f..b88fad1 100644 --- a/src/interface/interface_driver.c +++ b/src/interface/interface_driver.c @@ -1,6 +1,7 @@ /* * interface_driver.c: loads the appropriate backend * + * Copyright (C) 2014 Red Hat, Inc. * Copyright (C) 2012 Doug Goldstein <cardoe@cardoe.com> * * This library is free software; you can redistribute it and/or @@ -22,7 +23,8 @@ #include "interface_driver.h" int -interfaceRegister(void) { +interfaceRegister(void) +{ #ifdef WITH_NETCF /* Attempt to load the netcf based backend first */ if (netcfIfaceRegister() == 0) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index a6ba10a..d5327a4 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -175,7 +175,8 @@ cleanup: } static char * -libxlDomainManagedSavePath(libxlDriverPrivatePtr driver, virDomainObjPtr vm) { +libxlDomainManagedSavePath(libxlDriverPrivatePtr driver, virDomainObjPtr vm) +{ char *ret; libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 999f9ab..638f074 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -1,7 +1,7 @@ /* * node_device_driver.c: node device enumeration * - * Copyright (C) 2010-2013 Red Hat, Inc. + * Copyright (C) 2010-2014 Red Hat, Inc. * Copyright (C) 2008 Virtual Iron Software, Inc. * Copyright (C) 2008 David F. Lively * @@ -626,7 +626,8 @@ out: return ret; } -int nodedevRegister(void) { +int nodedevRegister(void) +{ #if defined(WITH_HAL) && defined(WITH_UDEV) /* Register only one of these two - they conflict */ if (udevNodeRegister() == -1) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index a7c8010..4123e6e 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -1,7 +1,7 @@ /* * secret_driver.c: local driver for secret manipulation API * - * Copyright (C) 2009-2012 Red Hat, Inc. + * Copyright (C) 2009-2012, 2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -537,7 +537,8 @@ secretOpen(virConnectPtr conn, virConnectAuthPtr auth ATTRIBUTE_UNUSED, } static int -secretClose(virConnectPtr conn) { +secretClose(virConnectPtr conn) +{ conn->secretPrivateData = NULL; return 0; } @@ -631,7 +632,8 @@ secretUsageIDForDef(virSecretDefPtr def) static int secretConnectListAllSecrets(virConnectPtr conn, virSecretPtr **secrets, - unsigned int flags) { + unsigned int flags) +{ virSecretDriverStatePtr driver = conn->secretPrivateData; virSecretPtr *tmp_secrets = NULL; int nsecrets = 0; diff --git a/src/security/security_stack.c b/src/security/security_stack.c index 0d42b21..e4b2db6 100644 --- a/src/security/security_stack.c +++ b/src/security/security_stack.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2010-2013 Red Hat, Inc. + * Copyright (C) 2010-2014 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -528,8 +528,10 @@ virSecurityStackSetHugepages(virSecurityManagerPtr mgr, return rc; } -static char *virSecurityStackGetMountOptions(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, - virDomainDefPtr vm ATTRIBUTE_UNUSED) { +static char * +virSecurityStackGetMountOptions(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, + virDomainDefPtr vm ATTRIBUTE_UNUSED) +{ return NULL; } -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:55PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- daemon/libvirtd-config.c | 9 +++++++-- docs/internals/command.html.in | 3 ++- examples/dominfo/info1.c | 7 ++++--- src/interface/interface_backend_netcf.c | 8 +++++--- src/interface/interface_backend_udev.c | 4 +++- src/interface/interface_driver.c | 4 +++- src/libxl/libxl_driver.c | 3 ++- src/node_device/node_device_driver.c | 5 +++-- src/secret/secret_driver.c | 8 +++++--- src/security/security_stack.c | 8 +++++--- 10 files changed, 39 insertions(+), 20 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Although not explicitly requested, we are using K&R (or Kernel) indentation for curly braces around functions in HACKING file and most of the code. Using grep -P, this patch add the syntax-check rule for it (while skipping all the false positives with foreach constructs). Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- Notes: Unfortunately, the regexp is meant to catch as much as possible and thus one line functions must occupy two lines, e.g.: static inline int getuid(void) { return 0; } is not valid. This can be changed by appending $$ to the end of the regexp which I didn't want to do since it might not catch something else I haven't thought of. Anyway, feel free to request such change and I'll push it changed without any modifications to such one-liners. cfg.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 7a65d1e..559f719 100644 --- a/cfg.mk +++ b/cfg.mk @@ -898,6 +898,13 @@ sc_prohibit_virConnectOpen_in_virsh: halt='Use vshConnect() in virsh instead of virConnectOpen*' \ $(_sc_search_regexp) +sc_curly_braces_style: + @files=$$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); \ + $(GREP) -nHP \ +'^\s*(?!([a-zA-Z_]*for_?each[a-zA-Z_]*) ?\()([_a-zA-Z0-9]+( [_a-zA-Z0-9]+)* ?\()?(\*?[_a-zA-Z0-9]+(,? \*?[_a-zA-Z0-9\[\]]+)+|void)\) ?\{' \ + $$files && { echo '$(ME): Non-K&R style used for curly' \ + 'braces around function body, see' \ + 'HACKING' 1>&2; exit 1; } || : # We don't use this feature of maint.mk. prev_version_file = /dev/null -- 1.9.0
On Wed, Mar 19, 2014 at 12:18:56PM +0100, Martin Kletzander wrote:
Although not explicitly requested, we are using K&R (or Kernel) indentation for curly braces around functions in HACKING file and most of the code. Using grep -P, this patch add the syntax-check rule for it (while skipping all the false positives with foreach constructs).
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> ---
Notes: Unfortunately, the regexp is meant to catch as much as possible and thus one line functions must occupy two lines, e.g.:
static inline int getuid(void) { return 0; }
is not valid. This can be changed by appending $$ to the end of the regexp which I didn't want to do since it might not catch something else I haven't thought of.
I think that's an acceptable limitation. We don't have many of those single line functions, so it isn't worth worrying about them.
diff --git a/cfg.mk b/cfg.mk index 7a65d1e..559f719 100644 --- a/cfg.mk +++ b/cfg.mk @@ -898,6 +898,13 @@ sc_prohibit_virConnectOpen_in_virsh: halt='Use vshConnect() in virsh instead of virConnectOpen*' \ $(_sc_search_regexp)
+sc_curly_braces_style: + @files=$$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); \ + $(GREP) -nHP \ +'^\s*(?!([a-zA-Z_]*for_?each[a-zA-Z_]*) ?\()([_a-zA-Z0-9]+( [_a-zA-Z0-9]+)* ?\()?(\*?[_a-zA-Z0-9]+(,? \*?[_a-zA-Z0-9\[\]]+)+|void)\) ?\{' \ + $$files && { echo '$(ME): Non-K&R style used for curly' \ + 'braces around function body, see' \ + 'HACKING' 1>&2; exit 1; } || :
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (2)
-
Daniel P. Berrange -
Martin Kletzander