[libvirt] [PATCH] Partially revert "cleanup: Don't include libvirt/libvirt.h"

This reverts the changes to remote_protocol.x made in commit 2d25fd4f410f65b40ef1c3d65124775a944f4025. It turns out that if 'dwarves' is installed, 'make check' fails if any *_LAST enum values are visible from within the .o file compiled from a .x file; including <libvirt/libvirt.h> prior to "internal.h" is the documented way to avoid exposing *_LAST enum elements. --- Pushing under the build-breaker rule. src/remote/remote_protocol.x | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index d384225..b957b8e 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -36,6 +36,7 @@ * 'REMOTE_'. This makes names quite long. */ +%#include <libvirt/libvirt.h> %#include "internal.h" %#include <arpa/inet.h> -- 1.8.1.4

On 17/04/13 23:23, Eric Blake wrote:
This reverts the changes to remote_protocol.x made in commit 2d25fd4f410f65b40ef1c3d65124775a944f4025. It turns out that if 'dwarves' is installed, 'make check' fails if any *_LAST enum values are visible from within the .o file compiled from a .x file; including <libvirt/libvirt.h> prior to "internal.h" is the documented way to avoid exposing *_LAST enum elements. ---
I pushed the fix before seeing this, though I like your commit log more. Osier
participants (2)
-
Eric Blake
-
Osier Yang