[libvirt] [PATCH] check-spacing: Don't hardcode Perl interpreter path
This is particularly useful on operating systems that don't ship Perl as part of the base system (eg. FreeBSD) while still working just as well as it did before on Linux. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/check-spacing.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl index 448acf234..ca8b43491 100755 --- a/build-aux/check-spacing.pl +++ b/build-aux/check-spacing.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # # check-spacing.pl: Report any usage of 'function (..args..)' # Also check for other syntax issues, such as correct use of ';' -- 2.13.5
On Mon, Sep 18, 2017 at 02:39:39PM +0200, Andrea Bolognani wrote:
This is particularly useful on operating systems that don't ship Perl as part of the base system (eg. FreeBSD) while still working just as well as it did before on Linux.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/check-spacing.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
For the usual use case of 'make syntax-check' this should be working already, since we run it as $(PERL) with the binary path detected at configure time. But this change is an improvement. ACK if you extend it to include all perl scripts. Jan
diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl index 448acf234..ca8b43491 100755 --- a/build-aux/check-spacing.pl +++ b/build-aux/check-spacing.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # # check-spacing.pl: Report any usage of 'function (..args..)' # Also check for other syntax issues, such as correct use of ';' -- 2.13.5
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, 2017-09-18 at 17:11 +0200, Ján Tomko wrote:
On Mon, Sep 18, 2017 at 02:39:39PM +0200, Andrea Bolognani wrote:
This is particularly useful on operating systems that don't ship Perl as part of the base system (eg. FreeBSD) while still working just as well as it did before on Linux.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/check-spacing.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
For the usual use case of 'make syntax-check' this should be working already, since we run it as $(PERL) with the binary path detected at configure time.
It does.
But this change is an improvement. ACK if you extend it to include all perl scripts.
Fair enough, I failed to realize just how many more Perl scripts were affected by the issue until you pointed it out. I've just posted v2 which fixes all Perl scripts, and additionally all Python scripts since they were in a similar position. -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Ján Tomko