[libvirt] [PATCH] domblkstat: Produce error message that at least sounds like English

Compare: # virsh domblkstat freebsd hdd error: Failed to get block stats freebsd hdd error: invalid argument: invalid path: hdd with: # virsh domblkstat freebsd hdd error: Failed to get block stats for domain 'freebsd' device 'hdd' error: invalid argument: invalid path: hdd Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tools/virsh-domain-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index bd89499..bcc5526 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -957,7 +957,7 @@ cmdDomblkstat(vshControl *ctl, const vshCmd *cmd) params = vshCalloc(ctl, nparams, sizeof(*params)); if (virDomainBlockStatsFlags(dom, device, params, &nparams, 0) < 0) { - vshError(ctl, _("Failed to get block stats %s %s"), name, device); + vshError(ctl, _("Failed to get block stats for domain '%s' device '%s'"), name, device); goto cleanup; } -- 1.9.0

On Fri, Feb 28, 2014 at 10:18:21AM +0100, Michal Privoznik wrote:
Compare:
# virsh domblkstat freebsd hdd error: Failed to get block stats freebsd hdd error: invalid argument: invalid path: hdd
with:
# virsh domblkstat freebsd hdd error: Failed to get block stats for domain 'freebsd' device 'hdd' error: invalid argument: invalid path: hdd
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> ---
ACK and worth this release. Martin
participants (2)
-
Martin Kletzander
-
Michal Privoznik