The 'asprintf' -> 'virAsprintf' transition made in commit 9e5d9950a1c5069d3cc908a7316d86a2d501d8a9 introducted a build error for 'driver.c' as 'util.h' has to be included. Signed-off-by: Maximilian Wilhelm <max(a)rfc2324.org&gt; --- src/driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/driver.c b/src/driver.c index fda64dd..f9f9c7c 100644 --- a/src/driver.c +++ b/src/driver.c @@ -27,6 +27,7 @@ #include "driver.h" #include "memory.h" #include "logging.h" +#include "util.h" #define DEFAULT_DRIVER_DIR LIBDIR "/libvirt/drivers" -- 1.5.6.5

Maximilian Wilhelm <max(a)rfc2324.org&gt; wrote: Thanks for the patch. I note that this link failure happens when you configure --with-driver-modules. As you suggest with the FIXME comment, there's room for improvement in this area. For example, with more than one of the various modules, we'd actually want all of their version strings, not just the one that happens to be listed last in the code. Or perhaps, a method to obtain a list of loaded/loadable modules, and another to query a module for its version string. #if WITH_XEN if (STRCASEEQ(type, "Xen")) *typeVer = xenUnifiedVersion(); #endif #if WITH_TEST if (STRCASEEQ(type, "Test")) *typeVer = LIBVIR_VERSION_NUMBER; #endif #if WITH_QEMU if (STRCASEEQ(type, "QEMU")) *typeVer = LIBVIR_VERSION_NUMBER; #endif #if WITH_LXC if (STRCASEEQ(type, "LXC")) *typeVer = LIBVIR_VERSION_NUMBER; #endif #if WITH_OPENVZ if (STRCASEEQ(type, "OpenVZ")) *typeVer = LIBVIR_VERSION_NUMBER; #endif #if WITH_UML if (STRCASEEQ(type, "UML")) *typeVer = LIBVIR_VERSION_NUMBER; #endif #if WITH_REMOTE if (STRCASEEQ(type, "Remote")) *typeVer = remoteVersion(); #endif However, even with your patch, the latest sources don't link for me. I get this: /c/libvirt/qemud/qemud.c:840: undefined reference to `virDriverLoadModule' The patch below fixes that: From: Jim Meyering <meyering(a)redhat.com&gt; Date: Mon, 16 Feb 2009 12:57:28 +0100 Subject: [PATCH] Avoid link failure when configured --with-driver-modules * qemud/Makefile.am (WITH_DRIVER_MODULES): Link with libvirt_driver.la and libvirt_util.la. Indent for readability. --- qemud/Makefile.am | 41 ++++++++++++++++++++++------------------- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/qemud/Makefile.am b/qemud/Makefile.am index a0c161a..498f05c 100644 --- a/qemud/Makefile.am +++ b/qemud/Makefile.am @@ -104,30 +104,33 @@ libvirtd_LDADD = \ $(SASL_LIBS) \ $(POLKIT_LIBS) -if ! WITH_DRIVER_MODULES -if WITH_QEMU -libvirtd_LDADD += ../src/libvirt_driver_qemu.la -endif +if WITH_DRIVER_MODULES + libvirtd_LDADD += ../src/libvirt_driver.la + libvirtd_LDADD += ../src/libvirt_util.la +else + if WITH_QEMU + libvirtd_LDADD += ../src/libvirt_driver_qemu.la + endif -if WITH_LXC -libvirtd_LDADD += ../src/libvirt_driver_lxc.la -endif + if WITH_LXC + libvirtd_LDADD += ../src/libvirt_driver_lxc.la + endif -if WITH_UML -libvirtd_LDADD += ../src/libvirt_driver_uml.la -endif + if WITH_UML + libvirtd_LDADD += ../src/libvirt_driver_uml.la + endif -if WITH_STORAGE_DIR -libvirtd_LDADD += ../src/libvirt_driver_storage.la -endif + if WITH_STORAGE_DIR + libvirtd_LDADD += ../src/libvirt_driver_storage.la + endif -if WITH_NETWORK -libvirtd_LDADD += ../src/libvirt_driver_network.la -endif + if WITH_NETWORK + libvirtd_LDADD += ../src/libvirt_driver_network.la + endif -if WITH_NODE_DEVICES -libvirtd_LDADD += ../src/libvirt_driver_nodedev.la -endif + if WITH_NODE_DEVICES + libvirtd_LDADD += ../src/libvirt_driver_nodedev.la + endif endif libvirtd_LDADD += ../src/libvirt.la -- 1.6.2.rc0.264.g60787

Maximilian Wilhelm <max(a)rfc2324.org&gt; wrote: Thanks. I'll apply this shortly. I note that it's required when you've configured with --with-driver-modules

Maximilian Wilhelm <max(a)rfc2324.org&gt; wrote: Thanks. While it is unused in the #else block, it *is* used in the #if-block, so marking it unused like that is misleading and might even provoke its own warning some day. I'll fix it like this instead: From: Jim Meyering <meyering(a)redhat.com&gt; Date: Mon, 16 Feb 2009 12:23:27 +0100 Subject: [PATCH] avoid compiler warning about unused parameter * src/bridge.c (brProbeVnetHdr) [IFF_VNET_HDR && TUNGETFEATURES && TUNGETIFF]: Use a "(void)" case to mark the parameter as unused. Reported by Maximilian Wilhelm in http://thread.gmane.org/gmane.comp.emulators.libvirt/11918/focus=11917 --- src/bridge.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/bridge.c b/src/bridge.c index fc11429..668dcf0 100644 --- a/src/bridge.c +++ b/src/bridge.c @@ -454,6 +454,7 @@ brProbeVnetHdr(int tapfd) return 1; #else + (void) tapfd; VIR_INFO0(_("Not enabling IFF_VNET_HDR; disabled at build time")); return 0; #endif -- 1.6.2.rc0.264.g60787

Maximilian Wilhelm <max(a)rfc2324.org&gt; wrote: This is just a symptom of your using a version of automake that is too old. I see that MKDIR_P *is* automatically substituted: $ grep @MKDIR_P config.status s&@MKDIR_P@&$ac_MKDIR_P&;t t $ grep MKDIR_P.= Makefile.in MKDIR_P = @MKDIR_P@

Maximilian Wilhelm <max(a)rfc2324.org&gt; wrote: Be aware that in using versions of automake and autoconf that are too old, you are in effect reintroducing bugs that have long since been fixed. Be especially careful not to distribute for general use any distribution tarballs you make based on those older versions. And note that even for your own use, relying on automake-generated Makefiles is risky. For example, automake-1.9 has a bug (fixed in 1.10) that can make parallel builds thread-unsafe -- coincidentally, due to problems with detecting a working "mkdir -p", which is sometimes used for locking. Be sure to prod the maintainers of any packages that require anything older than the latest upstream stable releases of automake or autoconf.

On Sun, Feb 15, 2009 at 11:37:12AM +0000, Daniel P. Berrange wrote: I've verified that this patch is *not* neccessary with automake 1.9.6 that is in RHEL-5 Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|