On 03/05/2012 12:17 PM, Jim Fehlig wrote:

This patch fixes some build error I've encountered, but would prefer an ACK before pushing.

Thanks, Jim

+++ b/src/util/virnetdevvportprofile.c @@ -1071,7 +1071,7 @@ int virNetDevVPortProfileAssociate(const char *macvtap_ifname ATTRIBUTE_UNUSED, const char *linkdev ATTRIBUTE_UNUSED, const unsigned char *vmuuid ATTRIBUTE_UNUSED, enum virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED, - bool setlink_only) + bool setlink_only ATTRIBUTE_UNUSED)

Changes like these to add annotations are okay.

+++ b/src/util/virnetlink.h @@ -55,7 +55,7 @@ int virNetlinkEventServiceStart(void); /** * virNetlinkEventServiceIsRunning: returns if the netlink event service is running. */ -bool virNetlinkEventServiceIsRunning(void); +int virNetlinkEventServiceIsRunning(void);

But this hunk looks wrong. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org