[libvirt] [PATCH 1/1] Do not use virtio-serial port 0 for generic ports
Per the discussion in: https://bugzilla.redhat.com/show_bug.cgi?id=670394 The port numbering should start from 1, not 0. We assign maxport + 1, so start maxport at 0. --- src/conf/domain_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5445a4..08c21e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && chr->info.addr.vioserial.port == 0) { - int maxport = -1; + int maxport = 0; int j; for (j = 0 ; j < i ; j++) { virDomainChrDefPtr thischr = def->channels[j]; -- 1.7.3.4
On 01/24/2011 01:57 PM, David Allan wrote:
Per the discussion in:
https://bugzilla.redhat.com/show_bug.cgi?id=670394
The port numbering should start from 1, not 0. We assign maxport + 1, so start maxport at 0. --- src/conf/domain_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5445a4..08c21e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && chr->info.addr.vioserial.port == 0) { - int maxport = -1; + int maxport = 0;
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Mon, Jan 24, 2011 at 02:14:48PM -0700, Eric Blake wrote:
On 01/24/2011 01:57 PM, David Allan wrote:
Per the discussion in:
https://bugzilla.redhat.com/show_bug.cgi?id=670394
The port numbering should start from 1, not 0. We assign maxport + 1, so start maxport at 0. --- src/conf/domain_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5445a4..08c21e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && chr->info.addr.vioserial.port == 0) { - int maxport = -1; + int maxport = 0;
ACK.
Thanks, pushed. Dave
On 01/26/2011 09:05 PM, Dave Allan wrote:
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5445a4..08c21e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && chr->info.addr.vioserial.port == 0) { - int maxport = -1; + int maxport = 0;
ACK.
Thanks, pushed.
Phooey - this broke 'make check' for qemuxml2argvtest qemuxml2xmltest. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
--- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && chr->info.addr.vioserial.port == 0) { - int maxport = -1; + int maxport = 0;
ACK.
Thanks, pushed.
Phooey - this broke 'make check' for qemuxml2argvtest qemuxml2xmltest.
The attached fix fixes that... Jirka
On 01/27/2011 11:29 AM, Jiri Denemark wrote:
--- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && chr->info.addr.vioserial.port == 0) { - int maxport = -1; + int maxport = 0;
ACK.
Thanks, pushed.
Phooey - this broke 'make check' for qemuxml2argvtest qemuxml2xmltest.
The attached fix fixes that...
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (4)
-
Dave Allan -
David Allan
-
Eric Blake -
Jiri Denemark